danger-review
Passed Started
by
@gitlab-bot
🤖 GitLab Bot 🤖
1Running with gitlab-runner 16.6.0~beta.105.gd2263193 (d2263193)2 on green-6.private.runners-manager.gitlab.com/gitlab.com/gitlab-org vHriyjxu, system ID: s_44fde8db605e3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-119-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-119-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:8e85f351f9d82fa0b3b131411428675e1a69db7bcea0564dce6a9b5b4dc1d85c for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-119-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:47990bab0f60f12114bd7c0eb1ad25145af689f8efddd34b7338ea073b26299c ...11Running on runner-vhriyjxu-project-278964-concurrent-0 via runner-vhriyjxu-private-1705320785-2532928a...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 179937, done. 17remote: Counting objects: 100% (179937/179937), done. 18remote: Compressing objects: 100% (116816/116816), done. 19remote: Total 179937 (delta 85962), reused 121422 (delta 55795), pack-reused 0 20Receiving objects: 100% (179937/179937), 141.30 MiB | 26.22 MiB/s, done.21Resolving deltas: 100% (85962/85962), done.23 * [new ref] refs/pipelines/1138599124 -> refs/pipelines/113859912424Checking out a9ffca21 as detached HEAD (ref is refs/merge-requests/141765/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bullseye-ruby-3.1-16...29cache.zip is up to date 30Successfully extracted cache31Checking cache for node-modules-bullseye-test-16...32Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 33Successfully extracted cache35Using docker image sha256:8e85f351f9d82fa0b3b131411428675e1a69db7bcea0564dce6a9b5b4dc1d85c for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-119-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:47990bab0f60f12114bd7c0eb1ad25145af689f8efddd34b7338ea073b26299c ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"717$ yarn_install_script772$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command773$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command774Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb775Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb776Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/change_column_default.rb777Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/clickhouse.rb778Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb779Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb780Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb781Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb782Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb783Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb784Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb785Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/gitlab_schema_validation.rb786Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ignored_model_columns.rb787Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb788Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb789Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb790Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb791Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/rubocop.rb792Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/saas_feature.rb793Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb794Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb795Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb796Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb797Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/todos.rb798Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation799Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture800Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions801Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates802Importing rule change_column_default at /builds/gitlab-org/gitlab/danger/change_column_default803Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/changelog804Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/changes_size805/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::SEE_DOC806/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:3: warning: previous definition of SEE_DOC was here807/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::SUGGEST_MR_COMMENT808/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:9: warning: previous definition of SUGGEST_MR_COMMENT was here809Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config810Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables811Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates812Importing rule clickhouse at /builds/gitlab-org/gitlab/danger/clickhouse813Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/commit_messages814Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/commits_counter815Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files816Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success817Importing rule database at /builds/gitlab-org/gitlab/danger/database818Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam819Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation820Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies821Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint822Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments823Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag824Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly825Importing rule gitlab_schema_validation at /builds/gitlab-org/gitlab/danger/gitlab_schema_validation826Importing rule ignored_model_columns at /builds/gitlab-org/gitlab/danger/ignored_model_columns827Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/metadata828Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations829Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion830Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas831Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline832Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier833Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector834Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops835Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette836Importing rule rubocop at /builds/gitlab-org/gitlab/danger/rubocop837Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems838Importing rule saas_feature at /builds/gitlab-org/gitlab/danger/saas_feature839Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args840Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues841Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels842Importing rule specs at /builds/gitlab-org/gitlab/danger/specs843Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch844Importing rule todos at /builds/gitlab-org/gitlab/danger/todos845Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/type_label846Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css847Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation848Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/z_add_labels849Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/z_retry_link850Results:851Warnings:852- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://handbook.gitlab.com/handbook/product/ux/technical-writing/#assignments).853For more information, see:854- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).855- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.856- [ ] You've made some app changes, but didn't add any tests.857That's OK as long as you're refactoring existing code,858but please consider adding any of the ~"maintenance::pipelines", ~"maintenance::refactor", ~"maintenance::workflow", ~"documentation", ~"QA" labels.859Markdown:860## Reviewer roulette861Changes that require review have been detected!862Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:863| Category | Reviewer | Maintainer |864| -------- | -------- | ---------- |865| ~"database" | `@ck3g` [](https://gitlab.com/ck3g)  (UTC+1, 4.5 hours behind author) | `@dfrazao-gitlab` [](https://gitlab.com/dfrazao-gitlab)  (UTC+1, 4.5 hours behind author) |866**Please check reviewer's status!**867-  Reviewer is available!868-  Reviewer is unavailable!869Feel free to [override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)870if you think someone else would be better-suited871or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/)872to find other available reviewers.873To read more on how to use the reviewer roulette, please take a look at the874[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)875and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).876Please consider assigning a reviewer or maintainer who is a877[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.878Once you've decided who will review this merge request, assign them as a reviewer!879Danger does not automatically notify them for you.880**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/5931292630) that generated this comment.**882Not uploading cache ruby-gems-debian-bullseye-ruby-3.1-16 due to policy883Not uploading cache node-modules-bullseye-test-16 due to policy885Job succeeded 
