danger-review
Passed Started
by
@seggenberger
Sascha Eggenberger
1Running with gitlab-runner 16.6.0~beta.105.gd2263193 (d2263193)2 on green-5.private.runners-manager.gitlab.com/gitlab.com/gitlab-org Zi_8oswQ, system ID: s_8a4f217c24b63 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:b6ecd857a9432dbcf3db944482b11a6539f3a0be42b882ff1b2e14c381fb46ad for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:1312a2d5cbb44b0f06794cc762e3b684b200c3e4c0ba6e458c61a641293b28c0 ...11Running on runner-zi8oswq-project-278964-concurrent-0 via runner-zi8oswq-private-1700660233-300d262b...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 160062, done. 17remote: Counting objects: 100% (160062/160062), done. 18remote: Compressing objects: 100% (106046/106046), done. 19remote: Total 160062 (delta 72910), reused 107607 (delta 47788), pack-reused 0 20Receiving objects: 100% (160062/160062), 141.24 MiB | 31.17 MiB/s, done.21Resolving deltas: 100% (72910/72910), done.23 * [new ref] refs/pipelines/1081810896 -> refs/pipelines/108181089624Checking out bc34b5b9 as detached HEAD (ref is refs/merge-requests/137025/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bullseye-ruby-3.1-16...29cache.zip is up to date 30Successfully extracted cache31Checking cache for node-modules-bullseye-test-16...32cache.zip is up to date 33Successfully extracted cache35Using docker image sha256:b6ecd857a9432dbcf3db944482b11a6539f3a0be42b882ff1b2e14c381fb46ad for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:1312a2d5cbb44b0f06794cc762e3b684b200c3e4c0ba6e458c61a641293b28c0 ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"70$ yarn_install_script125$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command126$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command127Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb128Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb129Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/change_column_default.rb130Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/clickhouse.rb131Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb132Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb133Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb134Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb135Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb136Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb137Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb138Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/gitlab_schema_validation.rb139Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ignored_model_columns.rb140Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb141Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb142Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb143Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb144Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/rubocop.rb145Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/saas_feature.rb146Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb147Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb148Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb149Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb150Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/todos.rb151Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation152Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture153Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions154Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates155Importing rule change_column_default at /builds/gitlab-org/gitlab/danger/change_column_default156Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/changelog157Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/changes_size158Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config159Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables160Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates161Importing rule clickhouse at /builds/gitlab-org/gitlab/danger/clickhouse162Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/commit_messages163Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/commits_counter164Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files165Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success166Importing rule database at /builds/gitlab-org/gitlab/danger/database167Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam168Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation169Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies170Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint171Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments172Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag173Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly174Importing rule gitlab_schema_validation at /builds/gitlab-org/gitlab/danger/gitlab_schema_validation175Importing rule ignored_model_columns at /builds/gitlab-org/gitlab/danger/ignored_model_columns176Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/metadata177Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations178Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion179Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas180Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline181Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier182/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::SEE_DOC183/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:3: warning: previous definition of SEE_DOC was here184/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::SUGGEST_MR_COMMENT185/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:9: warning: previous definition of SUGGEST_MR_COMMENT was here186Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector187Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops188Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette189Importing rule rubocop at /builds/gitlab-org/gitlab/danger/rubocop190Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems191Importing rule saas_feature at /builds/gitlab-org/gitlab/danger/saas_feature192Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args193Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues194Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels195Importing rule specs at /builds/gitlab-org/gitlab/danger/specs196Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch197Importing rule todos at /builds/gitlab-org/gitlab/danger/todos198Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/type_label199Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css200Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation201Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/z_add_labels202Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/z_retry_link203Results:204Warnings:205- [ ] This MR changes code in `ee/`, but its Changelog commit is missing the [`EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes). Consider adding it to your Changelog commits.206- [ ] This merge request is quite big (576 lines changed), please consider splitting it into multiple merge requests.207- [ ] 306d409bc68f6b20d254189231c75addb7842cb8: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).208- [ ] This merge request contains lines with testid selectors. Please ensure `e2e:package-and-test` job is run.209Markdown:210### Deprecated `testid` selectors211The following changed lines in this MR contain `testid` selectors:212#### `app/views/projects/_sidebar.html.haml`213```shell214+ .project-badges.gl-mb-2{ data: { testid: 'project-badges-content' } }215+ data: { testid: 'badge-image-link', qa_link_url: badge_link_url } }>216+ .project-buttons.gl-mb-2.js-show-on-project-root{ data: { testid: 'project-buttons' } }217```218#### `app/views/projects/_invite_members_empty_project.html.haml`219```shell220-%h4.gl-mt-0.gl-mb-3{ data: { testid: 'invite-member-section',221+ %p.gl-font-weight-bold.gl-text-gray-900.gl-mt-0.gl-mt-n1.gl-mb-3{ data: { testid: 'invite-member-section',222+ %h4.gl-mt-0.gl-mb-3{ data: { testid: 'invite-member-section',223```224#### `app/views/projects/empty.html.haml`225```shell226+ .project-buttons.gl-mb-5{ data: { testid: 'quick-actions-container' } }227-.project-buttons{ data: { testid: 'quick-actions-container' } }228+ .project-buttons{ data: { testid: 'quick-actions-container' } }229```230If the `e2e:package-and-test` job in the `qa` stage has run automatically, please ensure the tests are passing.231If the job has not run, please start the `trigger-omnibus-and-follow-up-e2e` job in the `qa` stage and ensure the tests in `follow-up-e2e:package-and-test-ee` pipeline are passing.232For the list of known failures please refer to [the latest pipeline triage issue](https://gitlab.com/gitlab-org/quality/pipeline-triage/-/issues).233If your changes are under a feature flag, please check our [Testing with feature flags](https://docs.gitlab.com/ee/development/testing_guide/end_to_end/feature_flags.html#automatic-test-execution-when-a-feature-flag-definition-changes) documentation for instructions.234## Reviewer roulette235Changes that require review have been detected!236Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:237| Category | Reviewer | Maintainer |238| -------- | -------- | ---------- |239| ~"backend" | `@aakriti.gupta` [](https://gitlab.com/aakriti.gupta)  (UTC+1, same timezone as author) | `@maddievn` [](https://gitlab.com/maddievn)  (UTC+2, 1 hour ahead of author) |240| ~"frontend" | `@agulina` [](https://gitlab.com/agulina)  (UTC+1, same timezone as author) | `@deepika.guliani` [](https://gitlab.com/deepika.guliani)  (UTC+5.5, 4.5 hours ahead of author) |241| ~QA | `@dchevalier2` [](https://gitlab.com/dchevalier2)  (UTC-5, 6 hours behind author) | Maintainer review is optional for ~QA |242| ~test for `spec/features/*` | `@aakriti.gupta` [](https://gitlab.com/aakriti.gupta)  (UTC+1, same timezone as author) | Maintainer review is optional for ~test for `spec/features/*` |243| ~UX | `@ameliabauerly` [](https://gitlab.com/ameliabauerly)  (UTC-8, 9 hours behind author) | Maintainer review is optional for ~UX |244**Please check reviewer's status!**245-  Reviewer is available!246-  Reviewer is unavailable!247Feel free to [override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)248if you think someone else would be better-suited249or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/)250to find other available reviewers.251To read more on how to use the reviewer roulette, please take a look at the252[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)253and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).254Please consider assigning a reviewer or maintainer who is a255[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.256Once you've decided who will review this merge request, assign them as a reviewer!257Danger does not automatically notify them for you.258**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/5597251862) that generated this comment.**260Not uploading cache ruby-gems-debian-bullseye-ruby-3.1-16 due to policy261Not uploading cache node-modules-bullseye-test-16 due to policy263Job succeeded 
