danger-review
Passed Started
by
@vshushlin
Vladimir Shushlin
1Running with gitlab-runner 16.3.0~beta.108.g2b6048b4 (2b6048b4)2 on blue-4.shared-gitlab-org.runners-manager.gitlab.com/default 8cwZ3F43, system ID: s_df0f7e24ca8b3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true, FF_RESOLVE_FULL_TLS_CHAIN:false6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:d68252162deca904d1a0066983188b98dfe3f6fe8181458b0a55905e79ed85a1 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14@sha256:2113f34affc7e2ee40bac87419dcd7c65a94d4abfa9edb86192e1aa6a1e46590 ...11Running on runner-8cwz3f43-project-278964-concurrent-0 via runner-8cwz3f43-shared-gitlab-org-1697786222-bf8a5fbb...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 148580, done. 17remote: Counting objects: 100% (148580/148580), done. 18remote: Compressing objects: 100% (104624/104624), done. 19remote: Total 148580 (delta 64637), reused 94927 (delta 38178), pack-reused 0 20Receiving objects: 100% (148580/148580), 135.67 MiB | 27.33 MiB/s, done.21Resolving deltas: 100% (64637/64637), done.23 * [new ref] refs/pipelines/1043537122 -> refs/pipelines/104353712224Checking out 537c07c6 as detached HEAD (ref is refs/merge-requests/118829/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...29Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bullseye-ruby-3.0-16 30Successfully extracted cache31Checking cache for node-modules-bullseye-test-16...32Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 33Successfully extracted cache35Using docker image sha256:d68252162deca904d1a0066983188b98dfe3f6fe8181458b0a55905e79ed85a1 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14@sha256:2113f34affc7e2ee40bac87419dcd7c65a94d4abfa9edb86192e1aa6a1e46590 ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"70$ yarn_install_script123$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command124Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb125Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb126Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/clickhouse.rb127Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb128Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb129Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb130Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb131Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb132Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb133Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb134Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ignored_model_columns.rb135Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb136Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb137Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb138Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb139Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/rubocop.rb140Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/saas_feature.rb141Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb142Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb143Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb144Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb145Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/todos.rb146Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation147Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture148Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions149Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates150Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-4.3.2/lib/danger/rules/changelog151Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-4.3.2/lib/danger/rules/changes_size152/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Rubocop#helper153/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Rubocop#helper154/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Rubocop#helper155/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Rubocop#helper156/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Rubocop#helper157/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Rubocop#helper158/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Rubocop#helper159/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Rubocop#helper160/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Rubocop#helper161/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Rubocop#helper162/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Rubocop#helper163/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::SEE_DOC164/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:4: warning: previous definition of SEE_DOC was here165/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:7: warning: already initialized constant Danger::Dangerfile::SUGGEST_MR_COMMENT166/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:10: warning: previous definition of SUGGEST_MR_COMMENT was here167/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper168/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper169/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper170/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper171/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper172/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper173/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper174/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper175/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper176/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper177/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper178/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper179/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper180/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper181/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper182/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:35: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper183Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config184Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables185Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates186Importing rule clickhouse at /builds/gitlab-org/gitlab/danger/clickhouse187Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-4.3.2/lib/danger/rules/commit_messages188Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-4.3.2/lib/danger/rules/commits_counter189Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files190Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success191Importing rule database at /builds/gitlab-org/gitlab/danger/database192Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam193Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation194Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies195Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint196Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments197Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag198Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly199Importing rule ignored_model_columns at /builds/gitlab-org/gitlab/danger/ignored_model_columns200Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-4.3.2/lib/danger/rules/metadata201Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations202Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion203Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas204Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline205Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier206Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector207Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops208Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette209Importing rule rubocop at /builds/gitlab-org/gitlab/danger/rubocop210Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems211Importing rule saas_feature at /builds/gitlab-org/gitlab/danger/saas_feature212Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args213Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues214Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels215Importing rule specs at /builds/gitlab-org/gitlab/danger/specs216Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch217Importing rule todos at /builds/gitlab-org/gitlab/danger/todos218Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-4.3.2/lib/danger/rules/type_label219Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css220Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation221Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-4.3.2/lib/danger/rules/z_add_labels222Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-4.3.2/lib/danger/rules/z_retry_link223Results:224Messages:225- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.226Markdown:227## Documentation review228The following files require a review from a technical writer:229* `doc/api/graphql/reference/index.md` ([Link to current live version](https://docs.gitlab.com/ee/api/graphql/reference/))230The review does not need to block merging this merge request. See the:231- [Metadata for the `*.md` files](https://docs.gitlab.com/ee/development/documentation/#metadata) that you've changed. The first few lines of each `*.md` file identify the stage and group most closely associated with your docs change.232- The [Technical Writer assigned](https://about.gitlab.com/handbook/product/ux/technical-writing/#assignments) for that stage and group.233- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.234## Reviewer roulette235Changes that require review have been detected!236Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:237| Category | Reviewer | Maintainer |238| -------- | -------- | ---------- |239| ~"backend" | `@aakriti.gupta` [](https://gitlab.com/aakriti.gupta)  (UTC+2) | `@engwan` [](https://gitlab.com/engwan)  (UTC+8) |240| ~"database" | `@jarka` [](https://gitlab.com/jarka)  (UTC+2) | `@ahegyi` [](https://gitlab.com/ahegyi)  (UTC+2) |241| ~UX | `@pedroms` [](https://gitlab.com/pedroms)  (UTC+2) | Maintainer review is optional for ~UX |242| ~"Verify" | Reviewer review is optional for ~"Verify" | `@vshushlin` [](https://gitlab.com/vshushlin)  (UTC+2) |243**Please check reviewer's status!**244-  Reviewer is available!245-  Reviewer is unavailable!246Feel free to [override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)247if you think someone else would be better-suited248or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/)249to find other available reviewers.250To read more on how to use the reviewer roulette, please take a look at the251[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)252and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).253Please consider assigning a reviewer or maintainer who is a254[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.255Once you've decided who will review this merge request, assign them as a reviewer!256Danger does not automatically notify them for you.257**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/5336652553) that generated this comment.**259Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy260Not uploading cache node-modules-bullseye-test-16 due to policy262Job succeeded 
