danger-review
Passed Started
by
@dstull
Doug Stull
1Running with gitlab-runner 16.1.0~beta.59.g83c66823 (83c66823)2 on green-3.private.runners-manager.gitlab.com/gitlab.com/gitlab-org QuQPoFsC, system ID: s_fc023362bf2f3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true, FF_RESOLVE_FULL_TLS_CHAIN:false6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:3e6c24d49ca804019e2cfcf4951ed994b550043ce6af3757cb550e8c78892a99 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14@sha256:50215d6eb4fdf053dfc39bc8a540c94a214139ba2a583092099c9eac46201eee ...11Running on runner-quqpofsc-project-278964-concurrent-0 via runner-quqpofsc-private-1692359304-ba920b57...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 150271, done. 17remote: Counting objects: 100% (150271/150271), done. 18remote: Compressing objects: 100% (97595/97595), done. 19remote: Total 150271 (delta 67217), reused 103431 (delta 46893), pack-reused 0 20Receiving objects: 100% (150271/150271), 124.68 MiB | 26.66 MiB/s, done.21Resolving deltas: 100% (67217/67217), done.23 * [new ref] refs/pipelines/972262671 -> refs/pipelines/97226267124Checking out 3f92a6c3 as detached HEAD (ref is refs/merge-requests/129383/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...29Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bullseye-ruby-3.0-16 30Successfully extracted cache31Checking cache for node-modules-bullseye-test-16...32cache.zip is up to date 33Successfully extracted cache35Using docker image sha256:3e6c24d49ca804019e2cfcf4951ed994b550043ce6af3757cb550e8c78892a99 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14@sha256:50215d6eb4fdf053dfc39bc8a540c94a214139ba2a583092099c9eac46201eee ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"70$ yarn_install_script114$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command115Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb116Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb117Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb118Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb119Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb120Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb121Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb122Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb123Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb124Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb125Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb126Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb127Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb128Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb129Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb130Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb131Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb132Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation133Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture134Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions135Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates136Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/changelog137Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/changes_size138Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config139Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables140Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates141Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/commit_messages142Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/commits_counter143Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files144Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success145Importing rule database at /builds/gitlab-org/gitlab/danger/database146Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam147Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation148Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies149Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint150Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments151Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag152Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly153Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/metadata154Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations155Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion156Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas157Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline158Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier159/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper160/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper161/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper162/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper163/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper164/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper165/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper166/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper167Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector168Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops169Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette170Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems171Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args172Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues173Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels174Importing rule specs at /builds/gitlab-org/gitlab/danger/specs175Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch176Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/subtype_label177Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/type_label178Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css179Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation180Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/z_add_labels181Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/z_retry_link182Results:183Warnings:184- [ ] 07c4685b1b806f7f798dc3f489543d48c81a2fe5: The commit subject must contain at least 3 words. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).185- [ ] 2d8690b70cc85c22e2ce9e39bb1cec1eac9e2ce1: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).186- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://about.gitlab.com/handbook/product/ux/technical-writing/#assignments).187For more information, see:188- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).189- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.190Messages:191- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:192If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.193If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.194If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.195Markdown:196## Reviewer roulette197Changes that require review have been detected!198Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:199| Category | Reviewer | Maintainer |200| -------- | -------- | ---------- |201| ~"backend" | [Martin Cavoj](https://gitlab.com/mcavoj)  (`@mcavoj`) (UTC+2, 1 hour ahead of `@drosse`) | [Alex Pooley](https://gitlab.com/alexpooley)  (`@alexpooley`) (UTC+8, 7 hours ahead of `@drosse`) |202| ~"frontend" | [Scott de Jonge](https://gitlab.com/sdejonge)  (`@sdejonge`) (UTC+10, 9 hours ahead of `@drosse`) | [Miguel Rincon](https://gitlab.com/mrincon)  (`@mrincon`) (UTC+2, 1 hour ahead of `@drosse`) |203To spread load more evenly across eligible reviewers, Danger has picked a candidate for each204review slot, based on their timezone. Feel free to205[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)206if you think someone else would be better-suited207or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.208To read more on how to use the reviewer roulette, please take a look at the209[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)210and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).211Please consider assigning a reviewer or maintainer who is a212[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.213Once you've decided who will review this merge request, assign them as a reviewer!214Danger does not automatically notify them for you.215**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4900739704) that generated this comment.**217Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy218Not uploading cache node-modules-bullseye-test-16 due to policy220Job succeeded 
