danger-review
Passed Started
by
@rpereira2

Reuben Pereira
1Running with gitlab-runner 16.1.0~beta.59.g83c66823 (83c66823)2 on green-1.shared-gitlab-org.runners-manager.gitlab.com/default Mf8beF5G, system ID: s_673deea48c2a3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:17ff485d60cad0e7a2cef114c588c387f0a02ea52778bdef56b31436edf609aa for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14@sha256:87a54d6d4c6d7bdd77d0700637df7c79a35b39235baf4c412cd1273ab94788c3 ...11Running on runner-mf8bef5g-project-278964-concurrent-0 via runner-mf8bef5g-shared-gitlab-org-1692021759-75218e64...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 77123, done. 17remote: Counting objects: 100% (77123/77123), done. 18remote: Compressing objects: 100% (66244/66244), done. 19remote: Total 77123 (delta 10753), reused 43332 (delta 7288), pack-reused 0 20Receiving objects: 100% (77123/77123), 99.10 MiB | 28.92 MiB/s, done.21Resolving deltas: 100% (10753/10753), done.23 * [new ref] refs/pipelines/967068571 -> refs/pipelines/96706857124remote: Enumerating objects: 6, done. 25remote: Counting objects: 100% (6/6), done. 26remote: Compressing objects: 100% (6/6), done. 27remote: Total 6 (delta 0), reused 6 (delta 0), pack-reused 0 28 * [new tag] v16.1.0-ee -> v16.1.0-ee29 * [new tag] v16.1.0-rc42-ee -> v16.1.0-rc42-ee30 * [new tag] v16.1.1-ee -> v16.1.1-ee31 * [new tag] v16.1.2-ee -> v16.1.2-ee32 * [new tag] v16.1.3-ee -> v16.1.3-ee33 * [new tag] v16.1.4-ee -> v16.1.4-ee34Checking out d8173886 as detached HEAD (ref is refs/merge-requests/128764/merge)...35Skipping Git submodules setup36$ git remote set-url origin "${CI_REPOSITORY_URL}"38Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...39Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bullseye-ruby-3.0-16 40Successfully extracted cache41Checking cache for node-modules-bullseye-test-16...42Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 43Successfully extracted cache45Using docker image sha256:17ff485d60cad0e7a2cef114c588c387f0a02ea52778bdef56b31436edf609aa for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14@sha256:87a54d6d4c6d7bdd77d0700637df7c79a35b39235baf4c412cd1273ab94788c3 ...46$ source scripts/utils.sh47$ bundle_install_script "--with danger"843$ yarn_install_script906$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command907Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb908Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb909Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb910Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb911Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb912Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb913Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb914Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb915Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb916Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb917Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb918Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb919Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb920Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation921Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture922Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates923Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/changelog924/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper925/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper926/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper927/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper928Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/changes_size929Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config930Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables931Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates932Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/commit_messages933Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/commits_counter934Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files935Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success936Importing rule database at /builds/gitlab-org/gitlab/danger/database937Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam938Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation939Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies940Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint941Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag942Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly943Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/metadata944Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion945Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas946Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline947Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier948Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector949Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette950Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems951Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args952Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues953Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels954Importing rule specs at /builds/gitlab-org/gitlab/danger/specs955Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch956Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/subtype_label957Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/type_label958Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css959Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation960Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/z_add_labels961Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata962Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/z_retry_link963Results:964Warnings:965- [ ] This merge request does not refer to an existing milestone.966- [ ] Backporting to older releases requires an [exception request process](https://docs.gitlab.com/ee/policy/maintenance.html#backporting-to-older-releases)967- [ ] **The `e2e:package-and-test-ee` job needs to succeed or have approval from a Software Engineer in Test.**968Read the "QA e2e:package-and-test-ee" section for more details.969- [ ] Please add a [merge request subtype](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification) to this merge request.970Messages:971- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:972If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.973If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.974If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.975Markdown:976## Reviewer roulette977Changes that require review have been detected!978Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:979| Category | Reviewer | Maintainer |980| -------- | -------- | ---------- |981| ~"backend" | [Hinam Mehra](https://gitlab.com/hmehra)  (`@hmehra`) (UTC+10, 16 hours ahead of `@sabrams`) | [Roy Zwambag](https://gitlab.com/rzwambag)  (`@rzwambag`) (UTC+2, 8 hours ahead of `@sabrams`) |982| ~"maintenance::workflow" / ~"maintenance::pipelines" for CI, Danger | [Javiera Tapia](https://gitlab.com/jtapiab)  (`@jtapiab`) (UTC-4, 2 hours ahead of `@sabrams`) | [David Dieulivol](https://gitlab.com/ddieulivol)  (`@ddieulivol`) (UTC+2, 8 hours ahead of `@sabrams`) |983To spread load more evenly across eligible reviewers, Danger has picked a candidate for each984review slot, based on their timezone. Feel free to985[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)986if you think someone else would be better-suited987or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.988To read more on how to use the reviewer roulette, please take a look at the989[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)990and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).991Please consider assigning a reviewer or maintainer who is a992[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.993Once you've decided who will review this merge request, assign them as a reviewer!994Danger does not automatically notify them for you.995## QA `e2e:package-and-test-ee`996**@sabrams, the `package-and-test` job must complete before merging this merge request.***997If there are failures on the `package-and-test` pipeline, ping your team's associated Software Engineer in Test (SET) to confirm998the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the `#quality` Slack channel.999**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4869213409) that generated this comment.**1001Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy1002Not uploading cache node-modules-bullseye-test-16 due to policy1004Job succeeded