Skip to content
Snippets Groups Projects

danger-review

Passed Started by
Chloe Liu
@chloeliu
1Running with gitlab-runner 16.1.0~beta.59.g83c66823 (83c66823)
2 on green-6.private.runners-manager.gitlab.com/gitlab.com/gitlab-org vHriyjxu, system ID: s_44fde8db605e
3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true, FF_RESOLVE_FULL_TLS_CHAIN:false
4 Resolving secrets 00:00
5 Preparing the "docker+machine" executor 00:03
6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...
7Authenticating with credentials from job payload (GitLab Registry)
8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...
9Using docker image sha256:24a9e92645b17c878623efd51b7564f81e480bd281e94d7f33971082e0ca80e0 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14@sha256:ca349d228348f199cb57f574476584f42aca338747393ed93a9032a0261afc4d ...
10 Preparing environment 00:01
11Running on runner-vhriyjxu-project-278964-concurrent-0 via runner-vhriyjxu-private-1691781589-82c3e335...
12 Getting source from Git repository 01:04
13Fetching changes with git depth set to 20...
14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/
15Created fresh repository.
16remote: Enumerating objects: 156786, done.
17remote: Counting objects: 100% (156786/156786), done.
18remote: Compressing objects: 100% (99933/99933), done.
19remote: Total 156786 (delta 73045), reused 107935 (delta 51103), pack-reused 0
20Receiving objects: 100% (156786/156786), 122.33 MiB | 24.59 MiB/s, done.
21Resolving deltas: 100% (73045/73045), done.
22From https://git-us-east1-d.ci-gateway.int.gprd.gitlab.net:8989/gitlab-org/gitlab
23 * [new ref] refs/pipelines/963733087 -> refs/pipelines/963733087
24Checking out 8c7bb3e2 as detached HEAD (ref is refs/merge-requests/123454/merge)...
25Skipping Git submodules setup
26$ git remote set-url origin "${CI_REPOSITORY_URL}"
27 Restoring cache 03:39
28Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...
29cache.zip is up to date
30Successfully extracted cache
31Checking cache for node-modules-bullseye-test-16...
32Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16
33Successfully extracted cache
34 Executing "step_script" stage of the job script 01:22
35Using docker image sha256:24a9e92645b17c878623efd51b7564f81e480bd281e94d7f33971082e0ca80e0 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14@sha256:ca349d228348f199cb57f574476584f42aca338747393ed93a9032a0261afc4d ...
36$ source scripts/utils.sh
37$ bundle_install_script "--with danger"
38 Installing gems 00:15
70$ yarn_install_script
71 Installing Yarn packages 00:55
114$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command
115Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb
116Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb
117Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb
118Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb
119Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb
120Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb
121Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb
122Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb
123Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb
124Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb
125Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb
126Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb
127Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb
128Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb
129Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb
130Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb
131Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb
132Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation
133Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture
134Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions
135Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates
136Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/changelog
137Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/changes_size
138Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config
139Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables
140Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates
141Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/commit_messages
142WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
143WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
144Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/commits_counter
145Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files
146Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success
147Importing rule database at /builds/gitlab-org/gitlab/danger/database
148Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam
149Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation
150Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies
151Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint
152Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments
153Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag
154Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly
155Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/metadata
156Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations
157Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion
158Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas
159Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline
160Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier
161Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector
162Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops
163Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette
164Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems
165Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args
166Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues
167Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels
168Importing rule specs at /builds/gitlab-org/gitlab/danger/specs
169Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch
170Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/subtype_label
171Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/type_label
172Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css
173Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation
174Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/z_add_labels
175Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/z_retry_link
176Results:
177Warnings:
178- [ ] This merge request is quite big (515 lines changed), please consider splitting it into multiple merge requests.
179- [ ] 7285289bbf2406d0229fd0228a01f28cf5e1e207: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).
180- [ ] 795bee7d4caa46c8b10c5d02e08d72d7953834bb: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).
181- [ ] 5b98573ad3ba469811f09a0612efc436c1561203: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).
182- [ ] 3759ee5c10873c1a5bdcffbf42f9858d100ba1a3: The commit subject must contain at least 3 words. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).
183- [ ] 3759ee5c10873c1a5bdcffbf42f9858d100ba1a3: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).
184- [ ] 043b06d3afb8b2ccebc95bb8c6ac05127e703db0: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).
185- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://about.gitlab.com/handbook/product/ux/technical-writing/#assignments).
186For more information, see:
187- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).
188- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.
189Messages:
190- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:
191If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.
192If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.
193If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.
194Markdown:
195## Reviewer roulette
196Changes that require review have been detected!
197Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
198| Category | Reviewer | Maintainer |
199| -------- | -------- | ---------- |
200| ~QA | [John McDonnell](https://gitlab.com/john.mcdonnell) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/john.mcdonnell.svg) (`@john.mcdonnell`) (UTC+1, 4.5 hours behind `@nprabakaran`) | [Chloe Liu](https://gitlab.com/chloeliu) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/chloeliu.svg) (`@chloeliu`) (UTC-7, 12.5 hours behind `@nprabakaran`) |
201| ~"Create::IDE - Remote Development Scripts" | Reviewer review is optional for ~"Create::IDE - Remote Development Scripts" | [David O'Regan](https://gitlab.com/oregand) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/oregand.svg) (`@oregand`) (UTC-4, 9.5 hours behind `@nprabakaran`) |
202| ~"Tooling" | Reviewer review is optional for ~"Tooling" | [Chad Woolley](https://gitlab.com/cwoolley-gitlab) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/cwoolley-gitlab.svg) (`@cwoolley-gitlab`) (UTC-7, 12.5 hours behind `@nprabakaran`) |
203| ~"Create::IDE - Remote Development Backend" | Reviewer review is optional for ~"Create::IDE - Remote Development Backend" | [Chloe Liu](https://gitlab.com/chloeliu) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/chloeliu.svg) (`@chloeliu`) (UTC-7, 12.5 hours behind `@nprabakaran`) |
204To spread load more evenly across eligible reviewers, Danger has picked a candidate for each
205review slot, based on their timezone. Feel free to
206[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)
207if you think someone else would be better-suited
208or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.
209To read more on how to use the reviewer roulette, please take a look at the
210[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)
211and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).
212Please consider assigning a reviewer or maintainer who is a
213[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.
214Once you've decided who will review this merge request, assign them as a reviewer!
215Danger does not automatically notify them for you.
216**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4852330980) that generated this comment.**
217 Saving cache for successful job 00:01
218Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy
219Not uploading cache node-modules-bullseye-test-16 due to policy
220 Cleaning up project directory and file based variables 00:00
221Job succeeded