danger-review
Passed Started
by
@gitlab-bot
🤖 GitLab Bot 🤖
1Running with gitlab-runner 16.1.0~beta.59.g83c66823 (83c66823)2 on green-5.private.runners-manager.gitlab.com/gitlab.com/gitlab-org Zi_8oswQ, system ID: s_8a4f217c24b63 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:24a9e92645b17c878623efd51b7564f81e480bd281e94d7f33971082e0ca80e0 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14@sha256:ca349d228348f199cb57f574476584f42aca338747393ed93a9032a0261afc4d ...11Running on runner-zi8oswq-project-278964-concurrent-0 via runner-zi8oswq-private-1691669569-2df0bfa3...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 145438, done. 17remote: Counting objects: 100% (145438/145438), done. 18remote: Compressing objects: 100% (96447/96447), done. 19remote: Total 145438 (delta 63547), reused 98646 (delta 43407), pack-reused 0 20Receiving objects: 100% (145438/145438), 119.87 MiB | 31.07 MiB/s, done.21Resolving deltas: 100% (63547/63547), done.23 * [new ref] refs/pipelines/962009091 -> refs/pipelines/96200909124Checking out 2a9b6857 as detached HEAD (ref is refs/merge-requests/128972/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...29Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bullseye-ruby-3.0-16 30Successfully extracted cache31Checking cache for node-modules-bullseye-test-16...32Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 33Successfully extracted cache35Using docker image sha256:24a9e92645b17c878623efd51b7564f81e480bd281e94d7f33971082e0ca80e0 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.17-postgresql-14@sha256:ca349d228348f199cb57f574476584f42aca338747393ed93a9032a0261afc4d ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"70$ yarn_install_script114$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command115Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb116Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb117Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb118Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb119Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb120Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb121Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb122Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb123Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb124Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb125Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb126Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb127Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb128Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb129Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb130Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb131Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb132Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation133Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture134Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions135Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates136Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/changelog137Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/changes_size138Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config139Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables140Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates141Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/commit_messages142/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper143/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper144/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper145/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper146Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/commits_counter147Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files148Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success149Importing rule database at /builds/gitlab-org/gitlab/danger/database150Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam151Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation152Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies153Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint154Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments155Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag156Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly157Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/metadata158Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations159Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion160Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas161Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline162Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier163Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector164Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops165Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette166Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems167Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args168Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues169Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels170Importing rule specs at /builds/gitlab-org/gitlab/danger/specs171Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch172Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/subtype_label173Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/type_label174Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css175Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation176Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/z_add_labels177Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.13.0/lib/danger/rules/z_retry_link178Results:179Warnings:180- [ ] b2376a4aa5d4a9817726e8a0f1ea8902c43878ea: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).181Messages:182- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:183If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.184If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.185If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.186Markdown:187## Reviewer roulette188Changes that require review have been detected!189Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:190| Category | Reviewer | Maintainer |191| -------- | -------- | ---------- |192| ~"backend" | [Ian Anderson](https://gitlab.com/imand3r)  (`@imand3r`) (UTC-7, 12.5 hours behind `@rkadam3`) | [Drew Cimino](https://gitlab.com/drew)  (`@drew`) (UTC+0, 5.5 hours behind `@rkadam3`) |193To spread load more evenly across eligible reviewers, Danger has picked a candidate for each194review slot, based on their timezone. Feel free to195[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)196if you think someone else would be better-suited197or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.198To read more on how to use the reviewer roulette, please take a look at the199[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)200and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).201Please consider assigning a reviewer or maintainer who is a202[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.203Once you've decided who will review this merge request, assign them as a reviewer!204Danger does not automatically notify them for you.205**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4841631475) that generated this comment.**207Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy208Not uploading cache node-modules-bullseye-test-16 due to policy210Job succeeded 
