danger-review

Passed Started 1 year ago by
1Running with gitlab-runner 16.1.0~beta.59.g83c66823 (83c66823)
2  on green-2.private.runners-manager.gitlab.com/gitlab.com/gitlab-org GaSD-S1F, system ID: s_5651e5b5643b
3  feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true
 4  Resolving secrets  
  00:00
 5  Preparing the "docker+machine" executor  
  00:02
6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...
7Authenticating with credentials from job payload (GitLab Registry)
8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...
9Using docker image sha256:17ff485d60cad0e7a2cef114c588c387f0a02ea52778bdef56b31436edf609aa for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14@sha256:87a54d6d4c6d7bdd77d0700637df7c79a35b39235baf4c412cd1273ab94788c3 ...
 10  Preparing environment  
  00:01
11Running on runner-gasd-s1f-project-278964-concurrent-0 via runner-gasd-s1f-private-1690272879-4fbad7a3...
 12  Getting source from Git repository  
  00:29
13Fetching changes with git depth set to 20...
14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/
15Created fresh repository.
16remote: Enumerating objects: 154533, done.        
17remote: Counting objects: 100% (154533/154533), done.        
18remote: Compressing objects: 100% (98176/98176), done.        
19remote: Total 154533 (delta 71637), reused 106977 (delta 50691), pack-reused 0        
20Receiving objects: 100% (154533/154533), 123.77 MiB | 25.94 MiB/s, done.
21Resolving deltas: 100% (71637/71637), done.
22From https://git-us-east1-d.ci-gateway.int.gprd.gitlab.net:8989/gitlab-org/gitlab
23 * [new ref]             refs/pipelines/944651146 -> refs/pipelines/944651146
24Checking out bc95231d as detached HEAD (ref is refs/merge-requests/124311/merge)...
25Skipping Git submodules setup
26$ git remote set-url origin "${CI_REPOSITORY_URL}"
 27  Restoring cache  
  00:29
28Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...
29cache.zip is up to date                            
30Successfully extracted cache
31Checking cache for node-modules-bullseye-test-16...
32cache.zip is up to date                            
33Successfully extracted cache
 34  Executing "step_script" stage of the job script  
  00:47
35Using docker image sha256:17ff485d60cad0e7a2cef114c588c387f0a02ea52778bdef56b31436edf609aa for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14@sha256:87a54d6d4c6d7bdd77d0700637df7c79a35b39235baf4c412cd1273ab94788c3 ...
36$ source scripts/utils.sh
37$ bundle_install_script "--with danger"
 38  Installing gems  
  00:11
70$ yarn_install_script
 71  Installing Yarn packages  
  00:25
114$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command
115Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb
116Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb
117Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb
118Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb
119Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb
120Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb
121Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb
122Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb
123Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb
124Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb
125Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb
126Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb
127Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb
128Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb
129Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation
130Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture
131Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates
132Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/changelog
133Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/changes_size
134Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config
135Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables
136Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates
137Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/commit_messages
138Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/commits_counter
139Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files
140Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success
141Importing rule database at /builds/gitlab-org/gitlab/danger/database
142Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam
143Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation
144Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies
145Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint
146Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments
147Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag
148Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly
149Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/metadata
150Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion
151Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas
152Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline
153Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier
154Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector
155Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette
156Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems
157Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args
158Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues
159Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels
160Importing rule specs at /builds/gitlab-org/gitlab/danger/specs
161Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch
162Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/subtype_label
163Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/type_label
164Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css
165Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation
166Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/z_add_labels
167Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata
168Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/z_retry_link
169Results:
170Warnings:
171- [ ] **New migrations added but <a href='https://gitlab.com/gitlab-org/gitlab/blob/fb5353c2afd0e46ecb6bf981b5df73f8fc34c51f/db/structure.sql'>db/structure.sql</a> wasn't updated**
172Usually, when adding new migrations, <a href='https://gitlab.com/gitlab-org/gitlab/blob/fb5353c2afd0e46ecb6bf981b5df73f8fc34c51f/db/structure.sql'>db/structure.sql</a> should be
173updated too (unless the migration isn't changing the DB schema
174and isn't the most recent one).
175- [ ] You've made some app changes, but didn't add any tests.
176That's OK as long as you're refactoring existing code,
177but please consider adding any of the ~"maintenance::pipelines", ~"maintenance::refactor", ~"maintenance::workflow", ~"documentation", ~"QA" labels.
178Messages:
179- [ ] This merge request adds or changes files that require a review from the [Database team](https://gitlab.com/groups/gl-database/-/group_members).
180Markdown:
181This merge request requires a database review. To make sure these
182changes are reviewed, take the following steps:
1831. Ensure the merge request has ~database and ~"database::review pending" labels.
184   If the merge request modifies database files, Danger will do this for you.
1851. Prepare your MR for database review according to the
186   [docs](https://docs.gitlab.com/ee/development/database_review.html#how-to-prepare-the-merge-request-for-a-database-review).
1871. Assign and mention the database reviewer suggested by Reviewer Roulette.
1881. Kick off the `db:gitlabcom-database-testing` manual job. This job can also be used before
189   requesting review to test your migrations against production data.
190The following files require a review from the Database team:
191* `db/post_migrate/20230724085146_replace_old_fk_p_ci_builds_metadata_to_builds_v3.rb`
192* `db/post_migrate/20230724085149_replace_old_fk_p_ci_runner_machine_builds_to_builds_v3.rb`
193* `db/schema_migrations/20230724085146`
194* `db/schema_migrations/20230724085149`
195## Reviewer roulette
196Changes that require review have been detected!
197Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
198| Category | Reviewer | Maintainer |
199| -------- | -------- | ---------- |
200| ~"database" | [Carla Drago](https://gitlab.com/carlad-gl) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/carlad-gl.svg) (`@carlad-gl`) (UTC+2, 1 hour behind `@mbobin`) | [Jon Jenkins](https://gitlab.com/jon_jenkins) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/jon_jenkins.svg) (`@jon_jenkins`) (UTC-5, 8 hours behind `@mbobin`) |
201| ~"migration" | No reviewer available | No maintainer available |
202To spread load more evenly across eligible reviewers, Danger has picked a candidate for each
203review slot, based on their timezone. Feel free to
204[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)
205if you think someone else would be better-suited
206or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.
207To read more on how to use the reviewer roulette, please take a look at the
208[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)
209and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).
210Please consider assigning a reviewer or maintainer who is a
211[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.
212Once you've decided who will review this merge request, assign them as a reviewer!
213Danger does not automatically notify them for you.
214**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4735713475) that generated this comment.**
 215  Saving cache for successful job  
  00:01
216Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy
217Not uploading cache node-modules-bullseye-test-16 due to policy
 218  Cleaning up project directory and file based variables  
  00:00
219Job succeeded