danger-review
Passed Started
by
@jennli

Jennifer Li
1Running with gitlab-runner 16.1.0~beta.59.g83c66823 (83c66823)2 on green-1.shared-gitlab-org.runners-manager.gitlab.com/default Mf8beF5G, system ID: s_673deea48c2a3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:f47b23bf3b9e02a2837ddb6fe9a0b728c270e7a7d815dc582fd17281be34f20d for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14@sha256:4db9bc427d7eb1bd075d76b4e5e3e59eb0d96c2e788e6275e628f0026dd30039 ...11Running on runner-mf8bef5g-project-278964-concurrent-0 via runner-mf8bef5g-shared-gitlab-org-1687973865-b3204298...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 130941, done. 17remote: Counting objects: 100% (130941/130941), done. 18remote: Compressing objects: 100% (89372/89372), done. 19remote: Total 130941 (delta 53585), reused 87373 (delta 36556), pack-reused 0 20Receiving objects: 100% (130941/130941), 119.80 MiB | 25.37 MiB/s, done.21Resolving deltas: 100% (53585/53585), done.23 * [new ref] refs/pipelines/915103010 -> refs/pipelines/91510301024Checking out 3207a84f as detached HEAD (ref is refs/merge-requests/123420/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...29Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bullseye-ruby-3.0-16 30Successfully extracted cache31Checking cache for node-modules-bullseye-test-16...32Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 33Successfully extracted cache35Using docker image sha256:f47b23bf3b9e02a2837ddb6fe9a0b728c270e7a7d815dc582fd17281be34f20d for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14@sha256:4db9bc427d7eb1bd075d76b4e5e3e59eb0d96c2e788e6275e628f0026dd30039 ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"698$ yarn_install_script742$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command743Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb744Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb745Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb746Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb747Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb748Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb749Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb750Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb751Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb752Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb753Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb754Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb755Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb756Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation757Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture758Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates759Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/changelog760Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/changes_size761Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config762Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables763Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates764Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/commit_messages765Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/commits_counter766Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files767Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success768Importing rule database at /builds/gitlab-org/gitlab/danger/database769Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam770Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation771Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies772Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint773Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag774Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly775Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/metadata776Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion777Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas778Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline779Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier780Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector781Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette782Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems783Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args784Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues785Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels786Importing rule specs at /builds/gitlab-org/gitlab/danger/specs787Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch788Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/subtype_label789Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/type_label790Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css791Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation792Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/z_add_labels793Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata794Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/z_retry_link795Results:796Messages:797- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:798If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.799If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.800If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.801Markdown:802## Pipeline Changes803This merge request contains changes to the pipeline configuration for the GitLab project.804Please consider the effect of the changes in this merge request on the following:805- Effects on different [pipeline types](https://docs.gitlab.com/ee/development/pipelines/index.html#pipelines-types-for-merge-requests)806- Effects on non-canonical projects:807 - `gitlab-foss`808 - `security`809 - `dev`810 - personal forks811- Effects on [pipeline performance](https://about.gitlab.com/handbook/engineering/quality/performance-indicators/#average-merge-request-pipeline-duration-for-gitlab)812Please consider communicating these changes to the broader team following the [communication guideline for pipeline changes](https://about.gitlab.com/handbook/engineering/quality/engineering-productivity/#pipeline-changes)813## Reviewer roulette814Changes that require review have been detected!815Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:816| Category | Reviewer | Maintainer |817| -------- | -------- | ---------- |818| ~"maintenance::workflow" / ~"maintenance::pipelines" for CI, Danger | [Ross Byrne](https://gitlab.com/robyrne)  (`@robyrne`) (UTC+1, 8 hours ahead of `@jennli`) | [David Dieulivol](https://gitlab.com/ddieulivol)  (`@ddieulivol`) (UTC+2, 9 hours ahead of `@jennli`) |819| ~"Engineering Productivity" | Reviewer review is optional for ~"Engineering Productivity" | [David Dieulivol](https://gitlab.com/ddieulivol)  (`@ddieulivol`) (UTC+2, 9 hours ahead of `@jennli`) |820To spread load more evenly across eligible reviewers, Danger has picked a candidate for each821review slot, based on their timezone. Feel free to822[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)823if you think someone else would be better-suited824or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.825To read more on how to use the reviewer roulette, please take a look at the826[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)827and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).828Please consider assigning a reviewer or maintainer who is a829[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.830Once you've decided who will review this merge request, assign them as a reviewer!831Danger does not automatically notify them for you.832**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4560916405) that generated this comment.**834Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy835Not uploading cache node-modules-bullseye-test-16 due to policy837Job succeeded