danger-review
Passed Started
by
@thiagocsf

Thiago Figueiró
1Running with gitlab-runner 16.1.0~beta.59.g83c66823 (83c66823)2 on green-2.private.runners-manager.gitlab.com/gitlab.com/gitlab-org GaSD-S1F, system ID: s_5651e5b5643b3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:f47b23bf3b9e02a2837ddb6fe9a0b728c270e7a7d815dc582fd17281be34f20d for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14@sha256:4db9bc427d7eb1bd075d76b4e5e3e59eb0d96c2e788e6275e628f0026dd30039 ...11Running on runner-gasd-s1f-project-278964-concurrent-0 via runner-gasd-s1f-private-1687921846-23e626fd...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 131786, done. 17remote: Counting objects: 100% (131786/131786), done. 18remote: Compressing objects: 100% (88646/88646), done. 19remote: Total 131786 (delta 54309), reused 89056 (delta 38089), pack-reused 0 20Receiving objects: 100% (131786/131786), 119.84 MiB | 26.52 MiB/s, done.21Resolving deltas: 100% (54309/54309), done.23 * [new ref] refs/pipelines/914221454 -> refs/pipelines/91422145424Checking out 3e5745a5 as detached HEAD (ref is refs/merge-requests/124397/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...29cache.zip is up to date 30Successfully extracted cache31Checking cache for node-modules-bullseye-test-16...32cache.zip is up to date 33Successfully extracted cache35Using docker image sha256:f47b23bf3b9e02a2837ddb6fe9a0b728c270e7a7d815dc582fd17281be34f20d for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14@sha256:4db9bc427d7eb1bd075d76b4e5e3e59eb0d96c2e788e6275e628f0026dd30039 ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"698$ yarn_install_script742$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command743Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb744Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb745Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb746Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb747Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb748Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb749Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb750Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb751Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb752Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb753Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb754Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb755Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb756Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation757Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture758Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates759Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/changelog760Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/changes_size761Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config762Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables763Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates764Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/commit_messages765Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/commits_counter766Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files767Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success768Importing rule database at /builds/gitlab-org/gitlab/danger/database769Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam770Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation771Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies772Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint773Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag774Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly775Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/metadata776Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion777Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas778Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline779Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier780/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper781/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper782/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper783/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper784/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper785/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper786/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper787/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper788/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper789/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper790/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper791/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper792Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector793Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette794Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems795Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args796Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues797Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels798Importing rule specs at /builds/gitlab-org/gitlab/danger/specs799Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch800Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/subtype_label801Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/type_label802Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css803Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation804Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/z_add_labels805Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata806Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/z_retry_link807Results:808Warnings:809- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://about.gitlab.com/handbook/product/ux/technical-writing/#assignments).810For more information, see:811- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).812- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.813Markdown:814## Reviewer roulette815Changes that require review have been detected!816Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:817| Category | Reviewer | Maintainer |818| -------- | -------- | ---------- |819| ~"backend" | [Minahil Nichols](https://gitlab.com/minahilnichols)  (`@minahilnichols`) (UTC-4, 14 hours behind `@thiagocsf`) | [Charlie Ablett](https://gitlab.com/cablett)  (`@cablett`) (UTC+12, 2 hours ahead of `@thiagocsf`) |820| ~"frontend" | [Scott de Jonge](https://gitlab.com/sdejonge)  (`@sdejonge`) (UTC+10, same timezone as `@thiagocsf`) | [Ezekiel Kigbo](https://gitlab.com/ekigbo)  (`@ekigbo`) (UTC+10, same timezone as `@thiagocsf`) |821To spread load more evenly across eligible reviewers, Danger has picked a candidate for each822review slot, based on their timezone. Feel free to823[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)824if you think someone else would be better-suited825or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.826To read more on how to use the reviewer roulette, please take a look at the827[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)828and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).829Please consider assigning a reviewer or maintainer who is a830[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.831Once you've decided who will review this merge request, assign them as a reviewer!832Danger does not automatically notify them for you.833**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4555483524) that generated this comment.**835Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy836Not uploading cache node-modules-bullseye-test-16 due to policy838Job succeeded