danger-review
Passed Started
by
@cngo
Coung Ngo
1Running with gitlab-runner 16.1.0~beta.59.g83c66823 (83c66823)2 on green-1.shared-gitlab-org.runners-manager.gitlab.com/default Mf8beF5G, system ID: s_673deea48c2a3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:f47b23bf3b9e02a2837ddb6fe9a0b728c270e7a7d815dc582fd17281be34f20d for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14@sha256:4db9bc427d7eb1bd075d76b4e5e3e59eb0d96c2e788e6275e628f0026dd30039 ...11Running on runner-mf8bef5g-project-278964-concurrent-0 via runner-mf8bef5g-shared-gitlab-org-1687792519-dc9bad49...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 151057, done. 17remote: Counting objects: 100% (151057/151057), done. 18remote: Compressing objects: 100% (96618/96618), done. 19remote: Total 151057 (delta 69882), reused 104096 (delta 49064), pack-reused 0 20Receiving objects: 100% (151057/151057), 123.18 MiB | 27.70 MiB/s, done.21Resolving deltas: 100% (69882/69882), done.23 * [new ref] refs/pipelines/912134552 -> refs/pipelines/91213455224Checking out 63456beb as detached HEAD (ref is refs/merge-requests/123969/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...29Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bullseye-ruby-3.0-16 30Successfully extracted cache31Checking cache for node-modules-bullseye-test-16...32Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 33Successfully extracted cache35Using docker image sha256:f47b23bf3b9e02a2837ddb6fe9a0b728c270e7a7d815dc582fd17281be34f20d for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14@sha256:4db9bc427d7eb1bd075d76b4e5e3e59eb0d96c2e788e6275e628f0026dd30039 ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"698$ yarn_install_script742$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command743Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb744Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb745Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb746Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb747Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb748Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb749Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb750Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb751Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb752Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb753Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb754Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb755Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb756Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation757Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture758Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates759Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/changelog760Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/changes_size761Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config762Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables763Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates764Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/commit_messages765Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/commits_counter766Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files767Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success768Importing rule database at /builds/gitlab-org/gitlab/danger/database769Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam770Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation771Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies772Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint773Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag774Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly775Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/metadata776Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion777Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas778Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline779Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier780/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper781/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper782/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper783/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper784/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper785/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper786/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper787/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper788/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper789/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper790/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper791/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper792Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector793Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette794Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems795Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args796Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues797Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels798Importing rule specs at /builds/gitlab-org/gitlab/danger/specs799Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch800Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/subtype_label801Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/type_label802Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css803Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation804Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/z_add_labels805Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata806Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/z_retry_link807Results:808Markdown:809## Reviewer roulette810Changes that require review have been detected!811Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:812| Category | Reviewer | Maintainer |813| -------- | -------- | ---------- |814| ~"backend" | [Ross Byrne](https://gitlab.com/robyrne)  (`@robyrne`) (UTC+1, 5 hours ahead of `@dstull`) | [Vitali Tatarintev](https://gitlab.com/ck3g)  (`@ck3g`) (UTC+2, 6 hours ahead of `@dstull`) |815| ~"frontend" | [James Rushford](https://gitlab.com/jrushford)  (`@jrushford`) (UTC+2, 6 hours ahead of `@dstull`) | [Vitaly Slobodin](https://gitlab.com/vitallium)  (`@vitallium`) (UTC+2, 6 hours ahead of `@dstull`) |816| ~test for `spec/features/*` | [Ross Byrne](https://gitlab.com/robyrne)  (`@robyrne`) (UTC+1, 5 hours ahead of `@dstull`) | Maintainer review is optional for ~test for `spec/features/*` |817| ~UX | [Kevin Comoli](https://gitlab.com/kcomoli)  (`@kcomoli`) (UTC+2, 6 hours ahead of `@dstull`) | Maintainer review is optional for ~UX |818To spread load more evenly across eligible reviewers, Danger has picked a candidate for each819review slot, based on their timezone. Feel free to820[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)821if you think someone else would be better-suited822or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.823To read more on how to use the reviewer roulette, please take a look at the824[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)825and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).826Please consider assigning a reviewer or maintainer who is a827[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.828Once you've decided who will review this merge request, assign them as a reviewer!829Danger does not automatically notify them for you.830**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4541970966) that generated this comment.**832Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy833Not uploading cache node-modules-bullseye-test-16 due to policy835Job succeeded 
