danger-review
Passed Started
by
@mlunoe

Michael Lunøe
1Running with gitlab-runner 16.1.0~beta.5.gf131a6a2 (f131a6a2)2 on blue-3.shared-gitlab-org.runners-manager.gitlab.com/default sUrYYgEG, system ID: s_35f98e2af4653 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:29b87d4e8d17fad91e09f1f9dc70458f075b8cefe102c904d6043b52d87d157a for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14@sha256:8e1b76424e73a366225f410eabe5c92d13aaff628e0f8517cbd9416c0e2a2ac1 ...11Running on runner-suryygeg-project-278964-concurrent-0 via runner-suryygeg-shared-gitlab-org-1686744717-b02d844e...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 140430, done. 17remote: Counting objects: 100% (140430/140430), done. 18remote: Compressing objects: 100% (92239/92239), done. 19remote: Total 140430 (delta 61210), reused 95705 (delta 42879), pack-reused 0 20Receiving objects: 100% (140430/140430), 121.31 MiB | 25.38 MiB/s, done.21Resolving deltas: 100% (61210/61210), done.23 * [new ref] refs/pipelines/899794941 -> refs/pipelines/89979494124Checking out 376ec61a as detached HEAD (ref is refs/merge-requests/123440/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...29cache.zip is up to date 30Successfully extracted cache31Checking cache for node-modules-bullseye-test-16...32Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 33Successfully extracted cache35Using docker image sha256:29b87d4e8d17fad91e09f1f9dc70458f075b8cefe102c904d6043b52d87d157a for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14@sha256:8e1b76424e73a366225f410eabe5c92d13aaff628e0f8517cbd9416c0e2a2ac1 ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"695$ yarn_install_script739$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command740Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb741Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb742Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb743Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb744Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb745Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb746Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb747Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb748Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb749Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb750Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb751Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb752Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb753Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation754Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture755Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates756Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/changelog757Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/changes_size758Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config759Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables760Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates761Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/commit_messages762Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/commits_counter763Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files764Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success765Importing rule database at /builds/gitlab-org/gitlab/danger/database766Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam767Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation768Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies769Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint770Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag771Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly772Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/metadata773Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion774Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas775Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline776Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier777/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper778/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper779/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper780/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper781/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper782/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper783/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper784/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper785/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper786/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper787/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper788/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper789Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector790Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette791Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems792Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args793Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues794Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels795Importing rule specs at /builds/gitlab-org/gitlab/danger/specs796Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch797Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/subtype_label798Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/type_label799Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css800Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation801Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/z_add_labels802Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata803Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/z_retry_link804Results:805Warnings:806- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://about.gitlab.com/handbook/product/ux/technical-writing/#assignments).807For more information, see:808- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).809- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.810- [ ] This merge request contains lines with QA selectors. Please ensure `e2e:package-and-test` job is run.811Markdown:812## QA Selectors813The following changed lines in this MR contain QA selectors:814* file `ee/app/assets/javascripts/compliance_dashboard/components/shared/framework_badge.vue`:815* - data-qa-selector="framework_badge"816Please ensure `e2e:package-and-test` job is run and the tests are passing.817For the list of known failures please refer to [the latest pipeline triage issue](https://gitlab.com/gitlab-org/quality/pipeline-triage/-/issues).818If your changes are under a feature flag, please check our [Testing with feature flags](https://docs.gitlab.com/ee/development/testing_guide/end_to_end/feature_flags.html#automatic-test-execution-when-a-feature-flag-definition-changes) documentation for instructions.819## Reviewer roulette820Changes that require review have been detected!821Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:822| Category | Reviewer | Maintainer |823| -------- | -------- | ---------- |824| ~"frontend" | [Scott de Jonge](https://gitlab.com/sdejonge)  (`@sdejonge`) (UTC+10) | [Michael Lunøe](https://gitlab.com/mlunoe)  (`@mlunoe`) (UTC+2) |825| ~QA | [Jay McCure](https://gitlab.com/jay_mccure)  (`@jay_mccure`) (UTC+10) | Maintainer review is optional for ~QA |826| ~UX | [Matthew Nearents](https://gitlab.com/mnearents)  (`@mnearents`) (UTC-7) | Maintainer review is optional for ~UX |827To spread load more evenly across eligible reviewers, Danger has picked a candidate for each828review slot, based on their timezone. Feel free to829[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)830if you think someone else would be better-suited831or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.832To read more on how to use the reviewer roulette, please take a look at the833[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)834and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).835Please consider assigning a reviewer or maintainer who is a836[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.837Once you've decided who will review this merge request, assign them as a reviewer!838Danger does not automatically notify them for you.839**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4472720002) that generated this comment.**841Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy842Not uploading cache node-modules-bullseye-test-16 due to policy844Job succeeded