danger-review
Passed Started
by
@gitlab-bot

🤖 GitLab Bot 🤖
1Running with gitlab-runner 16.1.0~beta.5.gf131a6a2 (f131a6a2)2 on blue-2.shared-gitlab-org.runners-manager.gitlab.com/default NL4gfoBe, system ID: s_74c3e13161643 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:29b87d4e8d17fad91e09f1f9dc70458f075b8cefe102c904d6043b52d87d157a for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14@sha256:8e1b76424e73a366225f410eabe5c92d13aaff628e0f8517cbd9416c0e2a2ac1 ...11Running on runner-nl4gfobe-project-278964-concurrent-0 via runner-nl4gfobe-shared-gitlab-org-1686560659-bb7fcf53...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 180952, done. 17remote: Counting objects: 100% (180952/180952), done. 18remote: Compressing objects: 100% (105489/105489), done. 19remote: Total 180952 (delta 93076), reused 131160 (delta 69054), pack-reused 0 20Receiving objects: 100% (180952/180952), 137.58 MiB | 27.86 MiB/s, done.21Resolving deltas: 100% (93076/93076), done.23 * [new ref] refs/pipelines/897104546 -> refs/pipelines/89710454624Checking out ca107c6d as detached HEAD (ref is refs/merge-requests/123352/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...29cache.zip is up to date 30Successfully extracted cache31Checking cache for node-modules-bullseye-test-16...32Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 33Successfully extracted cache35Using docker image sha256:29b87d4e8d17fad91e09f1f9dc70458f075b8cefe102c904d6043b52d87d157a for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14@sha256:8e1b76424e73a366225f410eabe5c92d13aaff628e0f8517cbd9416c0e2a2ac1 ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"695$ yarn_install_script739$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command740Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb741Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb742Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb743Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb744Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb745Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb746Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb747Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb748Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb749Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb750Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb751Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb752Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb753Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation754Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture755Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates756Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/changelog757Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/changes_size758Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config759Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables760Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates761Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/commit_messages762Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/commits_counter763Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files764Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success765Importing rule database at /builds/gitlab-org/gitlab/danger/database766Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam767Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation768Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies769Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint770Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag771Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly772Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/metadata773Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion774Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas775Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline776Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier777Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector778Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette779Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems780Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args781Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues782Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels783Importing rule specs at /builds/gitlab-org/gitlab/danger/specs784Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch785Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/subtype_label786Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/type_label787Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css788Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation789Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/z_add_labels790Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata791Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/z_retry_link792Results:793Warnings:794- [ ] You've made some app changes, but didn't add any tests.795That's OK as long as you're refactoring existing code,796but please consider adding any of the ~"maintenance::pipelines", ~"maintenance::refactor", ~"maintenance::workflow", ~"documentation", ~"QA" labels.797Markdown:798## Reviewer roulette799Changes that require review have been detected!800Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:801| Category | Reviewer | Maintainer |802| -------- | -------- | ---------- |803| ~"backend" | [Thomas Hutterer](https://gitlab.com/thutterer)  (`@thutterer`) (UTC+2, 1 hour ahead of `@robotmay_gitlab`) | [Kassio Borges](https://gitlab.com/kassio)  (`@kassio`) (UTC+1, same timezone as `@robotmay_gitlab`) |804| ~"frontend" | [Lorenz van Herwaarden](https://gitlab.com/lorenzvanherwaarden)  (`@lorenzvanherwaarden`) (UTC+2, 1 hour ahead of `@robotmay_gitlab`) | [Lukas Eipert](https://gitlab.com/leipert)  (`@leipert`) (UTC+2, 1 hour ahead of `@robotmay_gitlab`) |805To spread load more evenly across eligible reviewers, Danger has picked a candidate for each806review slot, based on their timezone. Feel free to807[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)808if you think someone else would be better-suited809or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.810To read more on how to use the reviewer roulette, please take a look at the811[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)812and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).813Please consider assigning a reviewer or maintainer who is a814[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.815Once you've decided who will review this merge request, assign them as a reviewer!816Danger does not automatically notify them for you.817**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4456683661) that generated this comment.**819Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy820Not uploading cache node-modules-bullseye-test-16 due to policy822Job succeeded