danger-review
Passed Started
by
@himkp
Himanshu Kapoor
1Running with gitlab-runner 16.1.0~beta.59.g83c66823 (83c66823)2 on green-4.private.runners-manager.gitlab.com/gitlab.com/gitlab-org rpvz2FF9, system ID: s_d704414ba02a3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:29b87d4e8d17fad91e09f1f9dc70458f075b8cefe102c904d6043b52d87d157a for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14@sha256:8e1b76424e73a366225f410eabe5c92d13aaff628e0f8517cbd9416c0e2a2ac1 ...11Running on runner-rpvz2ff9-project-278964-concurrent-0 via runner-rpvz2ff9-private-1686249030-f0930ee4...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 132962, done. 17remote: Counting objects: 100% (132962/132962), done. 18remote: Compressing objects: 100% (88262/88262), done. 19remote: Total 132962 (delta 55393), reused 90855 (delta 39683), pack-reused 0 20Receiving objects: 100% (132962/132962), 116.61 MiB | 27.44 MiB/s, done.21Resolving deltas: 100% (55393/55393), done.23 * [new ref] refs/pipelines/894275018 -> refs/pipelines/89427501824Checking out 3853282a as detached HEAD (ref is refs/merge-requests/122037/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...29cache.zip is up to date 30Successfully extracted cache31Checking cache for node-modules-bullseye-test-16...32cache.zip is up to date 33Successfully extracted cache35Using docker image sha256:29b87d4e8d17fad91e09f1f9dc70458f075b8cefe102c904d6043b52d87d157a for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-14@sha256:8e1b76424e73a366225f410eabe5c92d13aaff628e0f8517cbd9416c0e2a2ac1 ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"696$ yarn_install_script759$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command760Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb761Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb762Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb763Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb764Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb765Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb766Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb767Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb768Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb769Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb770Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb771Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb772Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb773Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation774Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture775Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates776Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/changelog777Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/changes_size778Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config779Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables780Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates781Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/commit_messages782Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/commits_counter783Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files784Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success785Importing rule database at /builds/gitlab-org/gitlab/danger/database786Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam787Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation788Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies789Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint790Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag791Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly792Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/metadata793Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion794Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas795Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline796Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier797/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper798/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper799/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper800/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper801/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper802/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper803/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper804/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper805Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector806Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette807Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems808Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args809Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues810Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels811Importing rule specs at /builds/gitlab-org/gitlab/danger/specs812Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch813Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/subtype_label814Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/type_label815Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css816Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation817Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/z_add_labels818Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata819Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/z_retry_link820Results:821Warnings:822- [ ] be1ba565130ffbc1b4bb57f955eba105498262f8: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).823Messages:824- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:825If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.826If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.827If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.828Markdown:829## Reviewer roulette830Changes that require review have been detected!831Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:832| Category | Reviewer | Maintainer |833| -------- | -------- | ---------- |834| ~"backend" | [Sylvester Chin](https://gitlab.com/schin1)  (`@schin1`) (UTC+8, 4 hours behind `@tristan.read`) | [Jarka Košanová](https://gitlab.com/jarka)  (`@jarka`) (UTC+2, 10 hours behind `@tristan.read`) |835| ~"frontend" | [Lorenz van Herwaarden](https://gitlab.com/lorenzvanherwaarden)  (`@lorenzvanherwaarden`) (UTC+2, 10 hours behind `@tristan.read`) | [Himanshu Kapoor](https://gitlab.com/himkp)  (`@himkp`) (UTC+2, 10 hours behind `@tristan.read`) |836To spread load more evenly across eligible reviewers, Danger has picked a candidate for each837review slot, based on their timezone. Feel free to838[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)839if you think someone else would be better-suited840or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.841To read more on how to use the reviewer roulette, please take a look at the842[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)843and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).844Please consider assigning a reviewer or maintainer who is a845[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.846Once you've decided who will review this merge request, assign them as a reviewer!847Danger does not automatically notify them for you.848**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4440957835) that generated this comment.**850Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy851Not uploading cache node-modules-bullseye-test-16 due to policy853Job succeeded 
