danger-review
Passed Started
by
@fabiopitino
Fabio Pitino
1Running with gitlab-runner 16.1.0~beta.5.gf131a6a2 (f131a6a2)2 on blue-2.private.runners-manager.gitlab.com/gitlab.com/gitlab-org QvBVRoXM, system ID: s_49b872f8ccf63 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:61b59025d0d646cd177f654d8f81df859675be528f37dcc2ce6f39a49c7a5dd9 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-13@sha256:25367d41b1034f1ecacfc9cb8eebc70cb30c6fdade3781cf295488255bf61614 ...11Running on runner-qvbvroxm-project-278964-concurrent-0 via runner-qvbvroxm-private-1685686185-45d12d26...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 139970, done. 17remote: Counting objects: 100% (139970/139970), done. 18remote: Compressing objects: 100% (94736/94736), done. 19remote: Total 139970 (delta 61223), reused 92025 (delta 39894), pack-reused 0 20Receiving objects: 100% (139970/139970), 123.36 MiB | 32.80 MiB/s, done.21Resolving deltas: 100% (61223/61223), done.23 * [new ref] refs/pipelines/887306308 -> refs/pipelines/88730630824Checking out 95754c79 as detached HEAD (ref is refs/merge-requests/122015/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...29Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bullseye-ruby-3.0-16 30Successfully extracted cache31Checking cache for node-modules-bullseye-test-16...32Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 33Successfully extracted cache35Using docker image sha256:61b59025d0d646cd177f654d8f81df859675be528f37dcc2ce6f39a49c7a5dd9 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-18.16-postgresql-13@sha256:25367d41b1034f1ecacfc9cb8eebc70cb30c6fdade3781cf295488255bf61614 ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"696$ yarn_install_script740$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command741Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb742Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb743Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb744Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb745Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb746Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb747Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb748Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb749Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb750Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb751Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb752Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb753Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb754Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation755Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture756Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates757Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/changelog758Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/changes_size759Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config760Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables761Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates762Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/commit_messages763Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/commits_counter764Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files765Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success766Importing rule database at /builds/gitlab-org/gitlab/danger/database767Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam768Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation769Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies770Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint771Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag772Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly773Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/metadata774Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion775Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas776Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline777Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier778/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper779/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper780/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper781/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper782/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper783/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper784/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper785/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper786/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper787/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper788/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper789/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper790/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper791/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper792/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper793/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper794/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper795/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper796/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper797/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper798Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector799Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette800Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems801Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args802Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues803Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels804Importing rule specs at /builds/gitlab-org/gitlab/danger/specs805Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch806Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/subtype_label807Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/type_label808Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css809Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation810Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/z_add_labels811Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata812Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/z_retry_link813Results:814Warnings:815- [ ] There were no new or modified feature flag YAML files detected in this MR.816If the changes here are already controlled under an existing feature flag, please add817the ~"feature flag::exists". Otherwise, if you think the changes here don't need818to be under a feature flag, please add the label ~"feature flag::skipped", and819add a short comment about why we skipped the feature flag.820For guidance on when to use a feature flag, please see the [documentation](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#when-to-use-feature-flags).821Messages:822- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.823Markdown:824## Documentation review825The following files require a review from a technical writer:826* `doc/api/graphql/reference/index.md` ([Link to current live version](https://docs.gitlab.com/ee/api/graphql/reference/))827* `doc/ci/pipelines/cicd_minutes.md` ([Link to current live version](https://docs.gitlab.com/ee/ci/pipelines/cicd_minutes/))828The review does not need to block merging this merge request. See the:829- [Metadata for the `*.md` files](https://docs.gitlab.com/ee/development/documentation/#metadata) that you've changed. The first few lines of each `*.md` file identify the stage and group most closely associated with your docs change.830- The [Technical Writer assigned](https://about.gitlab.com/handbook/product/ux/technical-writing/#assignments) for that stage and group.831- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.832## Multiversion compatibility833This merge request updates GraphQL backend and frontend code.834To prevent an incident, ensure the updated frontend code is backwards compatible.835For more information, see the [multiversion compatibility documentation](https://docs.gitlab.com/ee/development/graphql_guide/reviewing.html#multiversion-compatibility).836## Reviewer roulette837Changes that require review have been detected!838Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:839| Category | Reviewer | Maintainer |840| -------- | -------- | ---------- |841| ~"backend" | [Dzmitry Meshcharakou](https://gitlab.com/dmeshcharakou)  (`@dmeshcharakou`) (UTC+2, 7 hours behind `@marcel.amirault`) | [Vitali Tatarintev](https://gitlab.com/ck3g)  (`@ck3g`) (UTC+2, 7 hours behind `@marcel.amirault`) |842| ~"frontend" | [Sheldon Led](https://gitlab.com/sheldonled)  (`@sheldonled`) (UTC+1, 8 hours behind `@marcel.amirault`) | [Lukas Eipert](https://gitlab.com/leipert)  (`@leipert`) (UTC+2, 7 hours behind `@marcel.amirault`) |843| ~test for `spec/features/*` | [Tiffany Rea](https://gitlab.com/treagitlab)  (`@treagitlab`) (UTC-7, 16 hours behind `@marcel.amirault`) | Maintainer review is optional for ~test for `spec/features/*` |844| ~"Verify" | Reviewer review is optional for ~"Verify" | [Stan Hu](https://gitlab.com/stanhu)  (`@stanhu`) (UTC-7, 16 hours behind `@marcel.amirault`) |845| ~"Verify" | Reviewer review is optional for ~"Verify" | [Sheldon Led](https://gitlab.com/sheldonled)  (`@sheldonled`) (UTC+1, 8 hours behind `@marcel.amirault`) |846To spread load more evenly across eligible reviewers, Danger has picked a candidate for each847review slot, based on their timezone. Feel free to848[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)849if you think someone else would be better-suited850or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.851To read more on how to use the reviewer roulette, please take a look at the852[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)853and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).854Please consider assigning a reviewer or maintainer who is a855[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.856Once you've decided who will review this merge request, assign them as a reviewer!857Danger does not automatically notify them for you.858**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4400964986) that generated this comment.**860Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy861Not uploading cache node-modules-bullseye-test-16 due to policy863Job succeeded 
