danger-review
Passed Started
by
@ntepluhina

Natalia Tepluhina
1Running with gitlab-runner 15.9.0~beta.212.g8ccc65e7 (8ccc65e7)2 on green-3.private.runners-manager.gitlab.com/gitlab.com/gitlab-org QuQPoFsC, system ID: s_fc023362bf2f3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:e2241823d5bdc5e6df7c49ebc7b24c52db10bbb41407a5256c7f2d24ff464f7f for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13@sha256:f20112d766000374a74ca341735b93b35180b88d806027d821aa8800d0522906 ...11Running on runner-quqpofsc-project-278964-concurrent-0 via runner-quqpofsc-private-1684460130-3b770e02...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 144008, done. 18remote: Counting objects: 100% (144008/144008), done. 19remote: Compressing objects: 100% (102076/102076), done. 20remote: Total 144008 (delta 64387), reused 89305 (delta 36415), pack-reused 0 21Receiving objects: 100% (144008/144008), 126.62 MiB | 27.80 MiB/s, done.22Resolving deltas: 100% (64387/64387), done.24 * [new ref] refs/pipelines/872240128 -> refs/pipelines/87224012825Checking out 4e5a698c as detached HEAD (ref is refs/merge-requests/120843/merge)...26Skipping Git submodules setup27$ git remote set-url origin "${CI_REPOSITORY_URL}"29Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...30cache.zip is up to date 31Successfully extracted cache32Checking cache for node-modules-bullseye-test-16...33Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 34Successfully extracted cache36Using docker image sha256:e2241823d5bdc5e6df7c49ebc7b24c52db10bbb41407a5256c7f2d24ff464f7f for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13@sha256:f20112d766000374a74ca341735b93b35180b88d806027d821aa8800d0522906 ...37$ source scripts/utils.sh38$ bundle_install_script "--with danger"694$ yarn_install_script704$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command705$ bundle exec danger --fail-on-errors=true --verbose --danger_id="2677df" --dangerfile="Dangerfile"706Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb707Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb708Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb709Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb710Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb711Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb712Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb713Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb714Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb715Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb716Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb717Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb718Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation719Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture720Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates721Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/changelog722Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/changes_size723Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config724Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables725Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates726Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/commit_messages727Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/commits_counter728Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files729Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success730Importing rule database at /builds/gitlab-org/gitlab/danger/database731Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam732Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation733Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies734Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint735Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag736Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly737Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/metadata738Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion739Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas740Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline741Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier742/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper743/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper744/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper745/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper746/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper747/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper748/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper749/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper750/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper751/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper752/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper753/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper754/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper755/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper756/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper757/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper758/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper759/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper760/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper761/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper762/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper763/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper764/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper765/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper766/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper767/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper768/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper769/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper770Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector771Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette772Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems773Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args774Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues775Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels776Importing rule specs at /builds/gitlab-org/gitlab/danger/specs777Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch778Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/subtype_label779Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/type_label780Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css781Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation782Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/z_add_labels783Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata784Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/z_retry_link785Results:786Markdown:787## Reviewer roulette788Changes that require review have been detected!789Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:790| Category | Reviewer | Maintainer |791| -------- | -------- | ---------- |792| ~"frontend" | [Tomas Vik](https://gitlab.com/viktomas)  (`@viktomas`) (UTC+2, same timezone as `@mrincon`) | [Tristan Read](https://gitlab.com/tristan.read)  (`@tristan.read`) (UTC+12, 10 hours ahead of `@mrincon`) |793To spread load more evenly across eligible reviewers, Danger has picked a candidate for each794review slot, based on their timezone. Feel free to795[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)796if you think someone else would be better-suited797or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.798To read more on how to use the reviewer roulette, please take a look at the799[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)800and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).801Please consider assigning a reviewer or maintainer who is a802[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.803Once you've decided who will review this merge request, assign them as a reviewer!804Danger does not automatically notify them for you.805**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4313143668) that generated this comment.**806==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id="2677df" --dangerfile="Dangerfile"' succeeded in 7 seconds.808Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy809Not uploading cache node-modules-bullseye-test-16 due to policy811Job succeeded