danger-review
Passed Started
by
@nrosandich
Nate Rosandich
1Running with gitlab-runner 15.9.0~beta.212.g8ccc65e7 (8ccc65e7)2 on green-2.private.runners-manager.gitlab.com/gitlab.com/gitlab-org GaSD-S1F, system ID: s_5651e5b5643b3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:e2241823d5bdc5e6df7c49ebc7b24c52db10bbb41407a5256c7f2d24ff464f7f for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13@sha256:f20112d766000374a74ca341735b93b35180b88d806027d821aa8800d0522906 ...11Running on runner-gasd-s1f-project-278964-concurrent-0 via runner-gasd-s1f-private-1683828254-0ad35b27...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 168019, done. 18remote: Counting objects: 100% (168019/168019), done. 19remote: Compressing objects: 100% (110073/110073), done. 20remote: Total 168019 (delta 80514), reused 112321 (delta 51347), pack-reused 0 21Receiving objects: 100% (168019/168019), 136.28 MiB | 30.60 MiB/s, done.22Resolving deltas: 100% (80514/80514), done.24 * [new ref] refs/pipelines/864956492 -> refs/pipelines/86495649225Checking out 51d0ff9d as detached HEAD (ref is refs/merge-requests/119008/merge)...26Skipping Git submodules setup27$ git remote set-url origin "${CI_REPOSITORY_URL}"29Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...30cache.zip is up to date 31Successfully extracted cache32Checking cache for node-modules-bullseye-test-16...33Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 34Successfully extracted cache36Using docker image sha256:e2241823d5bdc5e6df7c49ebc7b24c52db10bbb41407a5256c7f2d24ff464f7f for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13@sha256:f20112d766000374a74ca341735b93b35180b88d806027d821aa8800d0522906 ...37$ source scripts/utils.sh38$ bundle_install_script "--with danger"696$ yarn_install_script706$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command707$ bundle exec danger --fail-on-errors=true --verbose --danger_id="2677df" --dangerfile="Dangerfile"708Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb709Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb710Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb711Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb712Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb713Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb714Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb715Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb716Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb717Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb718Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb719Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb720Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture721Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates722Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/changelog723Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/changes_size724Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config725Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables726Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates727Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/commit_messages728/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper729/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper730/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper731/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper732Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/commits_counter733Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files734Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success735Importing rule database at /builds/gitlab-org/gitlab/danger/database736Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam737Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation738Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies739Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint740Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag741Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly742Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/metadata743Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion744Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas745Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline746Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier747Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence748Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector749Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette750Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems751Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args752Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues753Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels754Importing rule specs at /builds/gitlab-org/gitlab/danger/specs755Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch756Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/subtype_label757Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/type_label758Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css759Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation760Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/z_add_labels761Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata762Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.10.0/lib/danger/rules/z_retry_link763Results:764Warnings:765- [ ] Please add a [merge request subtype](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification) to this merge request.766Markdown:767## Reviewer roulette768Changes that require review have been detected!769Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:770| Category | Reviewer | Maintainer |771| -------- | -------- | ---------- |772| ~"backend" | [Dzmitry Meshcharakou](https://gitlab.com/dmeshcharakou)  (`@dmeshcharakou`) (UTC+2) | [Brian Williams](https://gitlab.com/bwill)  (`@bwill`) (UTC-5) |773| ~"frontend" | [Ross Byrne](https://gitlab.com/robyrne)  (`@robyrne`) (UTC+1) | [Simon Knox](https://gitlab.com/psimyn)  (`@psimyn`) (UTC+10) |774| ~"group::compliance" | Reviewer review is optional for ~"group::compliance" | [Jay Montal](https://gitlab.com/jmontal)  (`@jmontal`) (UTC-6) |775To spread load more evenly across eligible reviewers, Danger has picked a candidate for each776review slot, based on their timezone. Feel free to777[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)778if you think someone else would be better-suited779or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.780To read more on how to use the reviewer roulette, please take a look at the781[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)782and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).783Please consider assigning a reviewer or maintainer who is a784[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.785Once you've decided who will review this merge request, assign them as a reviewer!786Danger does not automatically notify them for you.787**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4271566419) that generated this comment.**788==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id="2677df" --dangerfile="Dangerfile"' succeeded in 7 seconds.790Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy791Not uploading cache node-modules-bullseye-test-16 due to policy793Job succeeded 
