Skip to content
Snippets Groups Projects

danger-review

Passed Started by
Sincheol (David) Kim
@dskim_gitlab
1Running with gitlab-runner 15.9.0~beta.212.g8ccc65e7 (8ccc65e7)
2 on green-4.private.runners-manager.gitlab.com/gitlab.com/gitlab-org rpvz2FF9, system ID: s_d704414ba02a
3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true
4 Resolving secrets 00:00
5 Preparing the "docker+machine" executor 00:03
6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...
7Authenticating with credentials from job payload (GitLab Registry)
8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...
9Using docker image sha256:552b81110cdd830e05d17c8e7365f72e1dd96842217d7225636cb55a75777ea7 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13@sha256:a386dd1acb1341f710f3c3c320984f70512694bcfec8cb1c771365058ac7c475 ...
10 Preparing environment 00:01
11Running on runner-rpvz2ff9-project-278964-concurrent-0 via runner-rpvz2ff9-private-1682570791-53753f8b...
12 Getting source from Git repository 00:34
13$ eval "$CI_PRE_CLONE_SCRIPT"
14Fetching changes with git depth set to 20...
15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/
16Created fresh repository.
17remote: Enumerating objects: 162343, done.
18remote: Counting objects: 100% (162343/162343), done.
19remote: Compressing objects: 100% (98372/98372), done.
20remote: Total 162343 (delta 79431), reused 115386 (delta 58039), pack-reused 0
21Receiving objects: 100% (162343/162343), 129.76 MiB | 26.41 MiB/s, done.
22Resolving deltas: 100% (79431/79431), done.
23From https://git-us-east1-d.ci-gateway.int.gprd.gitlab.net:8989/gitlab-org/gitlab
24 * [new ref] refs/pipelines/850455016 -> refs/pipelines/850455016
25Checking out 997198e5 as detached HEAD (ref is refs/merge-requests/118423/merge)...
26Skipping Git submodules setup
27$ git remote set-url origin "${CI_REPOSITORY_URL}"
28 Restoring cache 00:24
29Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...
30cache.zip is up to date
31Successfully extracted cache
32Checking cache for node-modules-bullseye-test-16...
33Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16
34Successfully extracted cache
35 Executing "step_script" stage of the job script 00:22
36Using docker image sha256:552b81110cdd830e05d17c8e7365f72e1dd96842217d7225636cb55a75777ea7 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13@sha256:a386dd1acb1341f710f3c3c320984f70512694bcfec8cb1c771365058ac7c475 ...
37$ source scripts/utils.sh
38$ bundle_install_script "--with danger"
39 Installing gems 00:12
695$ yarn_install_script
696 Installing Yarn packages 00:01
705$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command
706$ bundle exec danger --fail-on-errors=true --verbose --danger_id="2677df" --dangerfile="Dangerfile"
707Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb
708Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb
709Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb
710Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb
711Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb
712Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb
713Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb
714Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb
715Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb
716Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb
717Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb
718Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture
719Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates
720Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/changelog
721Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/changes_size
722/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper
723/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper
724/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper
725/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper
726/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper
727/builds/gitlab-org/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper
728/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper
729/builds/gitlab-org/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper
730Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config
731Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates
732Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/commit_messages
733Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/commits_counter
734Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files
735Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success
736Importing rule database at /builds/gitlab-org/gitlab/danger/database
737Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam
738Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation
739Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies
740Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint
741Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag
742Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly
743Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/metadata
744Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion
745Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas
746Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline
747Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier
748Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence
749Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector
750Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette
751Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems
752Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args
753Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues
754Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels
755Importing rule specs at /builds/gitlab-org/gitlab/danger/specs
756Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch
757Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/subtype_label
758Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/type_label
759Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css
760Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation
761Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/z_add_labels
762Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata
763Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/z_retry_link
764Results:
765Warnings:
766- [ ] This MR changes code in `ee/`, but its Changelog commit is missing the [`EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes). Consider adding it to your Changelog commits.
767Messages:
768- [ ] This merge request adds or changes files that require a review from the [Database team](https://gitlab.com/groups/gl-database/-/group_members).
769Markdown:
770This merge request requires a database review. To make sure these
771changes are reviewed, take the following steps:
7721. Ensure the merge request has ~database and ~"database::review pending" labels.
773 If the merge request modifies database files, Danger will do this for you.
7741. Prepare your MR for database review according to the
775 [docs](https://docs.gitlab.com/ee/development/database_review.html#how-to-prepare-the-merge-request-for-a-database-review).
7761. Assign and mention the database reviewer suggested by Reviewer Roulette.
777The following files require a review from the Database team:
778* `app/finders/merge_requests_finder/params.rb`
779* `app/finders/snippets_finder.rb`
780## Reviewer roulette
781Changes that require review have been detected!
782Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
783| Category | Reviewer | Maintainer |
784| -------- | -------- | ---------- |
785| ~"backend" | [Marcos Rocha](https://gitlab.com/mc_rocha) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/mc_rocha.svg) (`@mc_rocha`) (UTC-4) | [Vasilii Iakliushin](https://gitlab.com/vyaklushin) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/vyaklushin.svg) (`@vyaklushin`) (UTC+2) |
786| ~"database" | [Tianwen Chen](https://gitlab.com/tianwenchen) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/tianwenchen.svg) (`@tianwenchen`) (UTC+10) | [Michał Zając](https://gitlab.com/Quintasan) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/Quintasan.svg) (`@Quintasan`) (UTC+2) |
787| ~QA | [Will Meek](https://gitlab.com/willmeek) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/willmeek.svg) (`@willmeek`) (UTC+1) | Maintainer review is optional for ~QA |
788| ~"group::compliance" | Reviewer review is optional for ~"group::compliance" | [Harsimar Sandhu](https://gitlab.com/harsimarsandhu) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/harsimarsandhu.svg) (`@harsimarsandhu`) (UTC+5.5) |
789| ~"group::authentication and authorization" | Reviewer review is optional for ~"group::authentication and authorization" | [Smriti Garg](https://gitlab.com/sgarg_gitlab) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/sgarg_gitlab.svg) (`@sgarg_gitlab`) (UTC+5.5) |
790| ~"Merge Requests" | Reviewer review is optional for ~"Merge Requests" | [Sincheol (David) Kim](https://gitlab.com/dskim_gitlab) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/dskim_gitlab.svg) (`@dskim_gitlab`) (UTC+9.5) |
791To spread load more evenly across eligible reviewers, Danger has picked a candidate for each
792review slot, based on their timezone. Feel free to
793[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)
794if you think someone else would be better-suited
795or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.
796To read more on how to use the reviewer roulette, please take a look at the
797[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)
798and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).
799Please consider assigning a reviewer or maintainer who is a
800[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.
801Once you've decided who will review this merge request, assign them as a reviewer!
802Danger does not automatically notify them for you.
803**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4187656352) that generated this comment.**
804==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id="2677df" --dangerfile="Dangerfile"' succeeded in 9 seconds.
805 Saving cache for successful job 00:01
806Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy
807Not uploading cache node-modules-bullseye-test-16 due to policy
808 Cleaning up project directory and file based variables 00:00
809Job succeeded