danger-review
Passed Started
by
@gitlab-qa
GitLab QA Bot
1Running with gitlab-runner 15.9.0~beta.212.g8ccc65e7 (8ccc65e7)2 on green-1.private.runners-manager.gitlab.com/gitlab.com/gitlab-org 4bq1s9yM, system ID: s_9d15f3e4e7ae3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:552b81110cdd830e05d17c8e7365f72e1dd96842217d7225636cb55a75777ea7 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13@sha256:a386dd1acb1341f710f3c3c320984f70512694bcfec8cb1c771365058ac7c475 ...11Running on runner-4bq1s9ym-project-278964-concurrent-0 via runner-4bq1s9ym-private-1682028833-10481414...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 166246, done. 18remote: Counting objects: 100% (166246/166246), done. 19remote: Compressing objects: 100% (100787/100787), done. 20remote: Total 166246 (delta 82806), reused 117863 (delta 59428), pack-reused 0 21Receiving objects: 100% (166246/166246), 131.69 MiB | 28.38 MiB/s, done.22Resolving deltas: 100% (82806/82806), done.24 * [new ref] refs/pipelines/844067117 -> refs/pipelines/84406711725Checking out fe87a17e as detached HEAD (ref is refs/merge-requests/118288/merge)...26Skipping Git submodules setup27$ git remote set-url origin "${CI_REPOSITORY_URL}"29Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...30cache.zip is up to date 31Successfully extracted cache32Checking cache for node-modules-bullseye-test-16...33Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 34Successfully extracted cache36Using docker image sha256:552b81110cdd830e05d17c8e7365f72e1dd96842217d7225636cb55a75777ea7 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13@sha256:a386dd1acb1341f710f3c3c320984f70512694bcfec8cb1c771365058ac7c475 ...37$ source scripts/utils.sh38$ bundle_install_script "--with danger"694$ yarn_install_script704$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command705$ bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"706Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb707Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb708Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb709Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb710Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb711Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb712Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb713Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb714Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb715Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb716Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb717Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture718Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates719Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/changelog720Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/changes_size721Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config722Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates723Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/commit_messages724Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/commits_counter725Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files726Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success727Importing rule database at /builds/gitlab-org/gitlab/danger/database728Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam729Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation730Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies731Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint732Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag733Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly734Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/metadata735Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion736Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas737Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline738Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier739Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence740Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector741Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette742Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems743Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args744Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues745Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels746Importing rule specs at /builds/gitlab-org/gitlab/danger/specs747Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch748Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/subtype_label749Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/type_label750Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css751Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation752Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/z_add_labels753Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata754Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/z_retry_link755Results:756Warnings:757- [ ] 3cfbf5045bedbb10aed964a6c382a9b66c510678: The commit body should not contain more than 72 characters per line. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).758- [ ] This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time.759- [ ] This merge request does not refer to an existing milestone.760- [ ] Please add a [merge request subtype](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification) to this merge request.761- [ ] Please add a [merge request type](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification) to this merge request.762Messages:763- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:764If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.765If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.766If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.767Markdown:768## Reviewer roulette769Changes that require review have been detected!770Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:771| Category | Reviewer | Maintainer |772| -------- | -------- | ---------- |773| ~QA | [Will Meek](https://gitlab.com/willmeek)  (`@willmeek`) (UTC+1) | [Tiffany Rea](https://gitlab.com/treagitlab)  (`@treagitlab`) (UTC-7) |774To spread load more evenly across eligible reviewers, Danger has picked a candidate for each775review slot, based on their timezone. Feel free to776[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)777if you think someone else would be better-suited778or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.779To read more on how to use the reviewer roulette, please take a look at the780[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)781and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).782Please consider assigning a reviewer or maintainer who is a783[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.784Once you've decided who will review this merge request, assign them as a reviewer!785Danger does not automatically notify them for you.786**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4152531100) that generated this comment.**787==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"' succeeded in 6 seconds.789Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy790Not uploading cache node-modules-bullseye-test-16 due to policy792Job succeeded 
