Skip to content
Snippets Groups Projects

danger-review

Passed Started by
Aleksei Lipniagov
@alipniagov
1Running with gitlab-runner 15.9.0~beta.212.g8ccc65e7 (8ccc65e7)
2 on green-3.private.runners-manager.gitlab.com/gitlab.com/gitlab-org QuQPoFsC, system ID: s_fc023362bf2f
3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true
4 Resolving secrets 00:00
5 Preparing the "docker+machine" executor 00:04
6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...
7Authenticating with credentials from job payload (GitLab Registry)
8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...
9Using docker image sha256:667531aab48d3d73584a6ae24a2aea1de3972ab11b24d34d65740089d1635940 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13@sha256:32a5178f22d0b62740cacea13dc02b6d5a1c9528c0a9af52124abe4455dd0a15 ...
10 Preparing environment 00:00
11Running on runner-quqpofsc-project-278964-concurrent-0 via runner-quqpofsc-private-1681304106-a7dd8144...
12 Getting source from Git repository 00:58
13$ eval "$CI_PRE_CLONE_SCRIPT"
14Fetching changes with git depth set to 20...
15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/
16Created fresh repository.
17remote: Enumerating objects: 141454, done.
18remote: Counting objects: 100% (141454/141454), done.
19remote: Compressing objects: 100% (90831/90831), done.
20remote: Total 141454 (delta 62790), reused 98369 (delta 45315), pack-reused 0
21Receiving objects: 100% (141454/141454), 122.90 MiB | 17.26 MiB/s, done.
22Resolving deltas: 100% (62790/62790), done.
23From https://git-us-east1-c.ci-gateway.int.gprd.gitlab.net:8989/gitlab-org/gitlab
24 * [new ref] refs/pipelines/835170457 -> refs/pipelines/835170457
25Checking out aa21306d as detached HEAD (ref is refs/merge-requests/116974/merge)...
26Skipping Git submodules setup
27$ git remote set-url origin "${CI_REPOSITORY_URL}"
28 Restoring cache 00:26
29Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...
30cache.zip is up to date
31Successfully extracted cache
32Checking cache for node-modules-bullseye-test-16...
33Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16
34Successfully extracted cache
35 Executing "step_script" stage of the job script 00:51
36Using docker image sha256:667531aab48d3d73584a6ae24a2aea1de3972ab11b24d34d65740089d1635940 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13@sha256:32a5178f22d0b62740cacea13dc02b6d5a1c9528c0a9af52124abe4455dd0a15 ...
37$ source scripts/utils.sh
38$ bundle_install_script "--with danger"
39 Installing gems 00:40
695$ yarn_install_script
696 Installing Yarn packages 00:01
705$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command
706$ bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"
707Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb
708Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb
709Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb
710Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb
711Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb
712Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb
713Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb
714Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb
715Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb
716Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb
717Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb
718Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture
719Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates
720Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/changelog
721Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/changes_size
722Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config
723Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates
724Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/commit_messages
725Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/commits_counter
726Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files
727Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success
728Importing rule database at /builds/gitlab-org/gitlab/danger/database
729Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam
730Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation
731Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies
732Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint
733Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag
734Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly
735Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/metadata
736Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion
737Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas
738Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline
739Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier
740Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence
741Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector
742Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette
743Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems
744Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args
745Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues
746Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels
747Importing rule specs at /builds/gitlab-org/gitlab/danger/specs
748Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch
749Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/subtype_label
750Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/type_label
751Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css
752Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation
753Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/z_add_labels
754Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata
755Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/z_retry_link
756Results:
757Markdown:
758## Reviewer roulette
759Changes that require review have been detected!
760Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
761| Category | Reviewer | Maintainer |
762| -------- | -------- | ---------- |
763| ~"frontend" | [Lukas Eipert](https://gitlab.com/leipert) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/leipert.svg) (`@leipert`) (UTC+2, same timezone as `@alipniagov`) | [Anna Vovchenko](https://gitlab.com/anna_vovchenko) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/anna_vovchenko.svg) (`@anna_vovchenko`) (UTC+3, 1 hour ahead of `@alipniagov`) |
764To spread load more evenly across eligible reviewers, Danger has picked a candidate for each
765review slot, based on their timezone. Feel free to
766[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)
767if you think someone else would be better-suited
768or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.
769To read more on how to use the reviewer roulette, please take a look at the
770[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)
771and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).
772Please consider assigning a reviewer or maintainer who is a
773[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.
774Once you've decided who will review this merge request, assign them as a reviewer!
775Danger does not automatically notify them for you.
776**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4101395165) that generated this comment.**
777==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"' succeeded in 9 seconds.
778 Saving cache for successful job 00:01
779Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy
780Not uploading cache node-modules-bullseye-test-16 due to policy
781 Cleaning up project directory and file based variables 00:01
782Job succeeded