danger-review

Passed Started 1 year ago by
1Running with gitlab-runner 15.9.0~beta.115.g598a7c91 (598a7c91)
2  on green-3.shared-gitlab-org.runners-manager.gitlab.com/default EuhiQzPR, system ID: s_360bc9544527
3  feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true
 4  Resolving secrets  
  00:00
 5  Preparing the "docker+machine" executor  
  00:03
6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...
7Authenticating with credentials from job payload (GitLab Registry)
8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...
9Using docker image sha256:667531aab48d3d73584a6ae24a2aea1de3972ab11b24d34d65740089d1635940 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13@sha256:32a5178f22d0b62740cacea13dc02b6d5a1c9528c0a9af52124abe4455dd0a15 ...
 10  Preparing environment  
  00:00
11Running on runner-euhiqzpr-project-278964-concurrent-0 via runner-euhiqzpr-shared-gitlab-org-1681198547-9dc95ae7...
 12  Getting source from Git repository  
  00:27
13$ eval "$CI_PRE_CLONE_SCRIPT"
14Fetching changes with git depth set to 20...
15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/
16Created fresh repository.
17remote: Enumerating objects: 136974, done.        
18remote: Counting objects: 100% (136974/136974), done.        
19remote: Compressing objects: 100% (89496/89496), done.        
20remote: Total 136974 (delta 58728), reused 95295 (delta 42246), pack-reused 0        
21Receiving objects: 100% (136974/136974), 122.14 MiB | 26.57 MiB/s, done.
22Resolving deltas: 100% (58728/58728), done.
23From https://git-us-east1-c.ci-gateway.int.gprd.gitlab.net:8989/gitlab-org/gitlab
24 * [new ref]             refs/pipelines/833458834 -> refs/pipelines/833458834
25Checking out fe7c646b as detached HEAD (ref is refs/merge-requests/116910/merge)...
26Skipping Git submodules setup
27$ git remote set-url origin "${CI_REPOSITORY_URL}"
 28  Restoring cache  
  00:21
29Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...
30cache.zip is up to date                            
31Successfully extracted cache
32Checking cache for node-modules-bullseye-test-16...
33Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 
34Successfully extracted cache
 35  Executing "step_script" stage of the job script  
  00:23
36Using docker image sha256:667531aab48d3d73584a6ae24a2aea1de3972ab11b24d34d65740089d1635940 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13@sha256:32a5178f22d0b62740cacea13dc02b6d5a1c9528c0a9af52124abe4455dd0a15 ...
37$ source scripts/utils.sh
38$ bundle_install_script "--with danger"
 39  Installing gems  
  00:13
691$ yarn_install_script
 692  Installing Yarn packages  
  00:01
701$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command
702$ bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"
703Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb
704Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb
705Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb
706Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb
707Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb
708Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb
709Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb
710Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb
711Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb
712Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb
713Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb
714Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture
715Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates
716Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/changelog
717Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/changes_size
718Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config
719Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates
720Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/commit_messages
721Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/commits_counter
722Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files
723Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success
724Importing rule database at /builds/gitlab-org/gitlab/danger/database
725Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam
726Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation
727Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies
728Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint
729Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag
730Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly
731Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/metadata
732Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion
733Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas
734Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline
735Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier
736Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence
737Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector
738Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette
739Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems
740Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args
741Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues
742Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels
743Importing rule specs at /builds/gitlab-org/gitlab/danger/specs
744Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch
745Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/subtype_label
746Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/type_label
747Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css
748Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation
749Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/z_add_labels
750Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata
751Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/z_retry_link
752Results:
753Warnings:
754- [ ] You've made some app changes, but didn't add any tests.
755That's OK as long as you're refactoring existing code,
756but please consider adding any of the ~"maintenance::pipelines", ~"maintenance::refactor", ~"maintenance::workflow", ~"documentation", ~"QA" labels.
757Markdown:
758## Reviewer roulette
759Changes that require review have been detected!
760Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
761| Category | Reviewer | Maintainer |
762| -------- | -------- | ---------- |
763| ~"frontend" | [Tomáš Bulva](https://gitlab.com/tbulva) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/tbulva.svg) (`@tbulva`) (UTC+2) | [Peter Hegman](https://gitlab.com/peterhegman) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/peterhegman.svg) (`@peterhegman`) (UTC-7) |
764To spread load more evenly across eligible reviewers, Danger has picked a candidate for each
765review slot, based on their timezone. Feel free to
766[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)
767if you think someone else would be better-suited
768or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.
769To read more on how to use the reviewer roulette, please take a look at the
770[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)
771and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).
772Please consider assigning a reviewer or maintainer who is a
773[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.
774Once you've decided who will review this merge request, assign them as a reviewer!
775Danger does not automatically notify them for you.
776**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4091289844) that generated this comment.**
777==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"' succeeded in 8 seconds.
 778  Saving cache for successful job  
  00:00
779Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy
780Not uploading cache node-modules-bullseye-test-16 due to policy
 781  Cleaning up project directory and file based variables  
  00:01
782Job succeeded