danger-review
Passed Started
by
@peterhegman
Peter Hegman
1Running with gitlab-runner 15.9.0~beta.212.g8ccc65e7 (8ccc65e7)2 on green-1.private.runners-manager.gitlab.com/gitlab.com/gitlab-org 4bq1s9yM, system ID: s_9d15f3e4e7ae3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:0a7a7c2f9aabd4679c452ef6b0b8799152afdbf9e25a5512e125b526f50086c8 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13@sha256:446301029b2bb26682cbec9a06392f5356d76d2b9b0839accae7923d9645b98c ...11Running on runner-4bq1s9ym-project-278964-concurrent-0 via runner-4bq1s9ym-private-1680621279-7d66b023...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 141056, done. 18remote: Counting objects: 100% (141056/141056), done. 19remote: Compressing objects: 100% (90600/90600), done. 20remote: Total 141056 (delta 62431), reused 98851 (delta 45075), pack-reused 0 21Receiving objects: 100% (141056/141056), 124.32 MiB | 32.09 MiB/s, done.22Resolving deltas: 100% (62431/62431), done.24 * [new ref] refs/pipelines/827852665 -> refs/pipelines/82785266525Checking out 25aeee04 as detached HEAD (ref is refs/merge-requests/116472/merge)...26Skipping Git submodules setup27$ git remote set-url origin "${CI_REPOSITORY_URL}"29Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...30Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bullseye-ruby-3.0-16 31Successfully extracted cache32Checking cache for node-modules-bullseye-test-16...33Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 34Successfully extracted cache36Using docker image sha256:0a7a7c2f9aabd4679c452ef6b0b8799152afdbf9e25a5512e125b526f50086c8 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.19-rust-1.65-node-16.14-postgresql-13@sha256:446301029b2bb26682cbec9a06392f5356d76d2b9b0839accae7923d9645b98c ...37$ source scripts/utils.sh38$ bundle_install_script "--with danger"691$ yarn_install_script701$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command702$ bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"703Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb704Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb705Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb706Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb707Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb708Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb709Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb710Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb711Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb712Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb713Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture714Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates715Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/changelog716Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/changes_size717Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config718Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates719Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/commit_messages720Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/commits_counter721Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files722Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success723Importing rule database at /builds/gitlab-org/gitlab/danger/database724Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam725Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation726Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies727Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint728Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag729Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly730Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/metadata731Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas732Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline733Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier734Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence735Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector736Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette737Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems738Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args739Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues740Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels741Importing rule specs at /builds/gitlab-org/gitlab/danger/specs742Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch743Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/subtype_label744Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/type_label745Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css746Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation747Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/z_add_labels748Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata749Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/z_retry_link750Results:751Warnings:752- [ ] This merge request does not refer to an existing milestone.753- [ ] Please add a [merge request subtype](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification) to this merge request.754- [ ] Please add a [merge request type](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification) to this merge request.755Messages:756- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.757Markdown:758## Documentation review759The following files require a review from a technical writer:760* `doc/user/profile/img/profile-preferences-syntax-themes_v15_11.png` ([Link to current live version](https://docs.gitlab.com/ee/user/profile/img/profile-preferences-syntax-themes_v15_11.png))761* `doc/user/profile/preferences.md` ([Link to current live version](https://docs.gitlab.com/ee/user/profile/preferences/))762The review does not need to block merging this merge request. See the:763- [Metadata for the `*.md` files](https://docs.gitlab.com/ee/development/documentation/#metadata) that you've changed. The first few lines of each `*.md` file identify the stage and group most closely associated with your docs change.764- The [Technical Writer assigned](https://about.gitlab.com/handbook/product/ux/technical-writing/#assignments) for that stage and group.765- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.766## Reviewer roulette767Changes that require review have been detected!768Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:769| Category | Reviewer | Maintainer |770| -------- | -------- | ---------- |771| ~"backend" | [Siddharth Dungarwal](https://gitlab.com/sdungarwal)  (`@sdungarwal`) (UTC+5.5) | [John Mason](https://gitlab.com/john-mason)  (`@john-mason`) (UTC-4) |772| ~"frontend" | [Diana Zubova](https://gitlab.com/dzubova)  (`@dzubova`) (UTC+2) | [Frédéric Caplette](https://gitlab.com/f_caplette)  (`@f_caplette`) (UTC-4) |773To spread load more evenly across eligible reviewers, Danger has picked a candidate for each774review slot, based on their timezone. Feel free to775[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)776if you think someone else would be better-suited777or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.778To read more on how to use the reviewer roulette, please take a look at the779[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)780and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).781Please consider assigning a reviewer or maintainer who is a782[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.783Once you've decided who will review this merge request, assign them as a reviewer!784Danger does not automatically notify them for you.785**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4060135236) that generated this comment.**786==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"' succeeded in 7 seconds.788Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy789Not uploading cache node-modules-bullseye-test-16 due to policy791Job succeeded