Skip to content
Snippets Groups Projects

danger-review

Passed Started by
🤖 GitLab Bot 🤖
@gitlab-bot
1Running with gitlab-runner 15.9.0~beta.212.g8ccc65e7 (8ccc65e7)
2 on green-2.private.runners-manager.gitlab.com/gitlab.com/gitlab-org GaSD-S1F, system ID: s_5651e5b5643b
3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true
4 Resolving secrets 00:00
5 Preparing the "docker+machine" executor 00:04
6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...
7Authenticating with credentials from job payload (GitLab Registry)
8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...
9Using docker image sha256:7a1b51158a1ee23b080b514ce6ebbf52ac51585877198fb52709e5cd01805a77 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-13@sha256:412d55913d43377094427ced549cb422ed2f2c7223e6a605d0d3e0151cb892b0 ...
10 Preparing environment 00:00
11Running on runner-gasd-s1f-project-278964-concurrent-0 via runner-gasd-s1f-private-1680164359-5307efed...
12 Getting source from Git repository 00:49
13$ eval "$CI_PRE_CLONE_SCRIPT"
14Fetching changes with git depth set to 20...
15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/
16Created fresh repository.
17remote: Enumerating objects: 135903, done.
18remote: Counting objects: 100% (135903/135903), done.
19remote: Compressing objects: 100% (88558/88558), done.
20remote: Total 135903 (delta 58315), reused 94619 (delta 42154), pack-reused 0
21Receiving objects: 100% (135903/135903), 121.35 MiB | 29.74 MiB/s, done.
22Resolving deltas: 100% (58315/58315), done.
23From https://git-us-east1-d.ci-gateway.int.gprd.gitlab.net:8989/gitlab-org/gitlab
24 * [new ref] refs/pipelines/822866544 -> refs/pipelines/822866544
25Checking out 523abdde as detached HEAD (ref is refs/merge-requests/116270/merge)...
26Skipping Git submodules setup
27$ git remote set-url origin "${CI_REPOSITORY_URL}"
28 Restoring cache 00:22
29Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...
30cache.zip is up to date
31Successfully extracted cache
32Checking cache for node-modules-bullseye-test-16...
33Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16
34Successfully extracted cache
35 Executing "step_script" stage of the job script 00:21
36Using docker image sha256:7a1b51158a1ee23b080b514ce6ebbf52ac51585877198fb52709e5cd01805a77 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-13:rubygems-3.4-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-13@sha256:412d55913d43377094427ced549cb422ed2f2c7223e6a605d0d3e0151cb892b0 ...
37$ source scripts/utils.sh
38$ bundle_install_script "--with danger"
39 Installing gems 00:11
690$ yarn_install_script
691 Installing Yarn packages 00:03
700$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command
701$ bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"
702Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb
703Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb
704Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb
705Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb
706Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb
707Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb
708Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb
709Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb
710Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb
711Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb
712Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture
713Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates
714Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/changelog
715Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/changes_size
716Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config
717Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates
718Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/commit_messages
719Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/commits_counter
720Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files
721Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success
722Importing rule database at /builds/gitlab-org/gitlab/danger/database
723Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam
724Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation
725Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies
726Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint
727Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag
728Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly
729Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/metadata
730Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas
731Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline
732Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier
733Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence
734Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector
735Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette
736Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems
737Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args
738Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues
739Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels
740Importing rule specs at /builds/gitlab-org/gitlab/danger/specs
741Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch
742Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/subtype_label
743Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/type_label
744Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css
745Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation
746Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/z_add_labels
747Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata
748Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.8.0/lib/danger/rules/z_retry_link
749Results:
750Markdown:
751## Pipeline Changes
752This merge request contains changes to the pipeline configuration for the GitLab project.
753Please consider the effect of the changes in this merge request on the following:
754- Effects on different [pipeline types](https://docs.gitlab.com/ee/development/pipelines/index.html#pipelines-types-for-merge-requests)
755- Effects on non-canonical projects:
756 - `gitlab-foss`
757 - `security`
758 - `dev`
759 - personal forks
760- Effects on [pipeline performance](https://about.gitlab.com/handbook/engineering/quality/performance-indicators/#average-merge-request-pipeline-duration-for-gitlab)
761Please consider communicating these changes to the broader team following the [communication guideline for pipeline changes](https://about.gitlab.com/handbook/engineering/quality/engineering-productivity/#pipeline-changes)
762## Reviewer roulette
763Changes that require review have been detected!
764Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
765| Category | Reviewer | Maintainer |
766| -------- | -------- | ---------- |
767| ~"backend" | [Pedro Pombeiro](https://gitlab.com/pedropombeiro) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/pedropombeiro.svg) (`@pedropombeiro`) (UTC+2, 6 hours behind `@godfat-gitlab`) | [Thong Kuah](https://gitlab.com/tkuah) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/tkuah.svg) (`@tkuah`) (UTC+13, 5 hours ahead of `@godfat-gitlab`) |
768| ~"maintenance::workflow" / ~"maintenance::pipelines" for CI, Danger | [Ravi Kumar](https://gitlab.com/rkumar555) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/rkumar555.svg) (`@rkumar555`) (UTC+2, 6 hours behind `@godfat-gitlab`) | [Rémy Coutable](https://gitlab.com/rymai) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/rymai.svg) (`@rymai`) (UTC+2, 6 hours behind `@godfat-gitlab`) |
769| ~"Engineering Productivity" | Reviewer review is optional for ~"Engineering Productivity" | [Ash McKenzie](https://gitlab.com/ashmckenzie) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/ashmckenzie.svg) (`@ashmckenzie`) (UTC+11, 3 hours ahead of `@godfat-gitlab`) |
770To spread load more evenly across eligible reviewers, Danger has picked a candidate for each
771review slot, based on their timezone. Feel free to
772[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)
773if you think someone else would be better-suited
774or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.
775To read more on how to use the reviewer roulette, please take a look at the
776[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)
777and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).
778Please consider assigning a reviewer or maintainer who is a
779[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.
780Once you've decided who will review this merge request, assign them as a reviewer!
781Danger does not automatically notify them for you.
782**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/4031139423) that generated this comment.**
783==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"' succeeded in 6 seconds.
784 Saving cache for successful job 00:01
785Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy
786Not uploading cache node-modules-bullseye-test-16 due to policy
787 Cleaning up project directory and file based variables 00:00
788Job succeeded