danger-review
Passed Started
by
@peterhegman
Peter Hegman
1Running with gitlab-runner 15.9.0~beta.115.g598a7c91 (598a7c91)2 on blue-2.private.runners-manager.gitlab.com/gitlab.com/gitlab-org QvBVRoXM, system ID: s_49b872f8ccf63 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:9647ab58a24f01d9656480de7327b15c03b75409f917503a25ba607241a02877 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-12@sha256:c76282e4162e4b925b0c4aa7bc47c6abd77a28d5d16451b7f168c893b15eebde ...11Running on runner-qvbvroxm-project-278964-concurrent-0 via runner-qvbvroxm-private-1677274475-d2de4df8...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 160498, done. 18remote: Counting objects: 100% (160498/160498), done. 19remote: Compressing objects: 100% (103318/103318), done. 20remote: Total 160498 (delta 76542), reused 110270 (delta 50602), pack-reused 0 21Receiving objects: 100% (160498/160498), 134.94 MiB | 30.16 MiB/s, done.22Resolving deltas: 100% (76542/76542), done.24 * [new ref] refs/pipelines/788583210 -> refs/pipelines/78858321025Checking out b66e6172 as detached HEAD (ref is refs/merge-requests/111659/merge)...26Skipping Git submodules setup27$ git remote set-url origin "${CI_REPOSITORY_URL}"29Checking cache for ruby-gems-debian-bullseye-ruby-3.0-16...30cache.zip is up to date 31Successfully extracted cache32Checking cache for node-modules-bullseye-test-16...33Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 34Successfully extracted cache36Using docker image sha256:9647ab58a24f01d9656480de7327b15c03b75409f917503a25ba607241a02877 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-109-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.18-rust-1.65-node-16.14-postgresql-12@sha256:c76282e4162e4b925b0c4aa7bc47c6abd77a28d5d16451b7f168c893b15eebde ...37$ source scripts/utils.sh38$ bundle_install_script "--with danger"672$ yarn_install_script682$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command683$ bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"684Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb685Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb686Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb687Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb688Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb689Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb690Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb691Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb692Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb693Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb694Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture695Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates696Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.7.0/lib/danger/rules/changelog697Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.7.0/lib/danger/rules/changes_size698Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config699Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates700Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.7.0/lib/danger/rules/commit_messages701Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.7.0/lib/danger/rules/commits_counter702Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files703Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success704Importing rule database at /builds/gitlab-org/gitlab/danger/database705Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam706Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation707Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies708Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint709Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag710Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly711Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas712Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline713Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier714Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence715Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector716Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette717Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems718Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args719Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues720Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels721Importing rule specs at /builds/gitlab-org/gitlab/danger/specs722Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch723Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.7.0/lib/danger/rules/subtype_label724Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.7.0/lib/danger/rules/type_label725Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css726Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation727Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.7.0/lib/danger/rules/z_add_labels728Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata729Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.7.0/lib/danger/rules/z_retry_link730Results:731Warnings:732- [ ] This merge request is quite big (702 lines changed), please consider splitting it into multiple merge requests.733- [ ] 66c6e452ce5f34381509eda3c36d58ded1306088: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).734- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://about.gitlab.com/handbook/product/ux/technical-writing/#assignments).735For more information, see:736- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).737- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.738Markdown:739## Reviewer roulette740Changes that require review have been detected!741Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:742| Category | Reviewer | Maintainer |743| -------- | -------- | ---------- |744| ~"backend" | [Halil Coban](https://gitlab.com/halilcoban)  (`@halilcoban`) (UTC+1, same timezone as `@eduardosanz`) | [Douglas Barbosa Alexandre](https://gitlab.com/dbalexandre)  (`@dbalexandre`) (UTC+0, 1 hour behind `@eduardosanz`) |745| ~"frontend" | [Diana Zubova](https://gitlab.com/dzubova)  (`@dzubova`) (UTC+1, same timezone as `@eduardosanz`) | [Denys Mishunov](https://gitlab.com/dmishunov)  (`@dmishunov`) (UTC+1, same timezone as `@eduardosanz`) |746| ~"group::authentication and authorization" | Reviewer review is optional for ~"group::authentication and authorization" | [Imre Farkas](https://gitlab.com/ifarkas)  (`@ifarkas`) (UTC+1, same timezone as `@eduardosanz`) |747To spread load more evenly across eligible reviewers, Danger has picked a candidate for each748review slot, based on their timezone. Feel free to749[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)750if you think someone else would be better-suited751or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.752To read more on how to use the reviewer roulette, please take a look at the753[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)754and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).755Please consider assigning a reviewer or maintainer who is a756[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.757Once you've decided who will review this merge request, assign them as a reviewer!758Danger does not automatically notify them for you.759**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/3833032062) that generated this comment.**760==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"' succeeded in 11 seconds.762Not uploading cache ruby-gems-debian-bullseye-ruby-3.0-16 due to policy763Not uploading cache node-modules-bullseye-test-16 due to policy765Job succeeded