danger-review
Passed Started
by
@psimyn
Simon Knox
1Running with gitlab-runner 15.6.0~beta.186.ga889181a (a889181a)2 on blue-1.private.runners-manager.gitlab.com/gitlab.com/gitlab-org 1zzGUpzq3 feature flags: FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-106-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-106-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:9f9846a4ac0697e6010265e736ea0ed08cd0506c4323c4e2a29d17e1b28665ce for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-106-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12@sha256:9229dfe0f4ee76cecfd8411f6668b0b2a5fd730d1d3688013b3a721189fcccb5 ...11Running on runner-1zzgupzq-project-278964-concurrent-0 via runner-1zzgupzq-private-1671020746-3e4fb221...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 190399, done. 18remote: Counting objects: 100% (190399/190399), done. 19remote: Compressing objects: 100% (107225/107225), done. 20remote: Total 190399 (delta 105428), reused 139382 (delta 76464), pack-reused 0 21Receiving objects: 100% (190399/190399), 136.51 MiB | 32.08 MiB/s, done.22Resolving deltas: 100% (105428/105428), done.24 * [new ref] refs/pipelines/722348674 -> refs/pipelines/72234867425Checking out e7ec402b as refs/merge-requests/106486/merge...26Skipping Git submodules setup27$ git remote set-url origin "${CI_REPOSITORY_URL}"29Checking cache for ruby-gems-debian-bullseye-ruby-2.7-16...30cache.zip is up to date 31Successfully extracted cache32Checking cache for node-modules-bullseye-test-16...33cache.zip is up to date 34Successfully extracted cache36Using docker image sha256:9f9846a4ac0697e6010265e736ea0ed08cd0506c4323c4e2a29d17e1b28665ce for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-106-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12@sha256:9229dfe0f4ee76cecfd8411f6668b0b2a5fd730d1d3688013b3a721189fcccb5 ...37$ source scripts/utils.sh38$ bundle_install_script "--with danger"668$ yarn_install_script678$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command679$ bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"680Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb681Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb682Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb683Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb684Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb685Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb686Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb687Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb688Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb689Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/user_types.rb690Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture691Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates692Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.3/lib/danger/rules/changelog693Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.3/lib/danger/rules/changes_size694/builds/gitlab-org/gitlab/danger/gitaly/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE695/builds/gitlab-org/gitlab/danger/ci_templates/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here696Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config697Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates698Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.3/lib/danger/rules/commit_messages699Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.3/lib/danger/rules/commits_counter700Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files701Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success702Importing rule database at /builds/gitlab-org/gitlab/danger/database703Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam704Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation705Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies706Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint707Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag708Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly709Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas710Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline711Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier712Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence713Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector714Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette715Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems716Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues717Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels718Importing rule specs at /builds/gitlab-org/gitlab/danger/specs719Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch720Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.3/lib/danger/rules/subtype_label721Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.3/lib/danger/rules/type_label722Importing rule user_types at /builds/gitlab-org/gitlab/danger/user_types723Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css724Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation725Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.3/lib/danger/rules/z_add_labels726Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata727Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.3/lib/danger/rules/z_retry_link728Results:729Warnings:730- [ ] This merge request is quite big (505 lines changed), please consider splitting it into multiple merge requests.731- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://about.gitlab.com/handbook/product/ux/technical-writing/#assignments).732For more information, see:733- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).734- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.735Markdown:736## Reviewer roulette737Changes that require review have been detected!738Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:739| Category | Reviewer | Maintainer |740| -------- | -------- | ---------- |741| ~"backend" | [Tyler Amos](https://gitlab.com/tyleramos)  (`@tyleramos`) (UTC-5, 7 hours behind `@xanf`) | [Doug Stull](https://gitlab.com/dstull)  (`@dstull`) (UTC-5, 7 hours behind `@xanf`) |742| ~"frontend" | [Andrei Zubov](https://gitlab.com/andrei.zubov)  (`@andrei.zubov`) (UTC+1, 1 hour behind `@xanf`) | [Himanshu Kapoor](https://gitlab.com/himkp)  (`@himkp`) (UTC+1, 1 hour behind `@xanf`) |743To spread load more evenly across eligible reviewers, Danger has picked a candidate for each744review slot, based on their timezone. Feel free to745[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)746if you think someone else would be better-suited747or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.748To read more on how to use the reviewer roulette, please take a look at the749[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)750and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).751Please consider assigning a reviewer or maintainer who is a752[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.753Once you've decided who will review this merge request, assign them as a reviewer!754Danger does not automatically notify them for you.755**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/3473258288) that generated this comment.**756==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"' succeeded in 9 seconds.758Not uploading cache ruby-gems-debian-bullseye-ruby-2.7-16 due to policy759Not uploading cache node-modules-bullseye-test-16 due to policy761Job succeeded