danger-review
Passed Started
by
@jannik_lehmann

Jannik Lehmann
1Running with gitlab-runner 15.6.0~beta.186.ga889181a (a889181a)2 on green-1.shared-gitlab-org.runners-manager.gitlab.com/default Mf8beF5G3 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-106-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-106-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:9f9846a4ac0697e6010265e736ea0ed08cd0506c4323c4e2a29d17e1b28665ce for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-106-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12@sha256:9229dfe0f4ee76cecfd8411f6668b0b2a5fd730d1d3688013b3a721189fcccb5 ...11Running on runner-mf8bef5g-project-278964-concurrent-0 via runner-mf8bef5g-shared-gitlab-org-1670509605-1ff594e3...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 143169, done. 18remote: Counting objects: 100% (143169/143169), done. 19remote: Compressing objects: 100% (88001/88001), done. 20remote: Total 143169 (delta 68220), reused 101961 (delta 50196), pack-reused 0 21Receiving objects: 100% (143169/143169), 118.47 MiB | 29.40 MiB/s, done.22Resolving deltas: 100% (68220/68220), done.24 * [new ref] refs/pipelines/717196226 -> refs/pipelines/71719622625Checking out 4926e79d as refs/merge-requests/101563/merge...26Skipping Git submodules setup27$ git remote set-url origin "${CI_REPOSITORY_URL}"29Checking cache for ruby-gems-debian-bullseye-ruby-2.7-16...30Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bullseye-ruby-2.7-16 31Successfully extracted cache32Checking cache for node-modules-bullseye-test-16...33Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 34Successfully extracted cache36Using docker image sha256:9f9846a4ac0697e6010265e736ea0ed08cd0506c4323c4e2a29d17e1b28665ce for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-106-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12@sha256:9229dfe0f4ee76cecfd8411f6668b0b2a5fd730d1d3688013b3a721189fcccb5 ...37$ source scripts/utils.sh38$ bundle_install_script "--with danger"668$ yarn_install_script678$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command679$ bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"680Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb681Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb682Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb683Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb684Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb685Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb686Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb687Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb688Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb689Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture690Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates691Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.3/lib/danger/rules/changelog692Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.3/lib/danger/rules/changes_size693Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config694Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates695Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.3/lib/danger/rules/commit_messages696/builds/gitlab-org/gitlab/danger/gitaly/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE697/builds/gitlab-org/gitlab/danger/ci_templates/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here698Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.3/lib/danger/rules/commits_counter699Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files700Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success701Importing rule database at /builds/gitlab-org/gitlab/danger/database702Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam703Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation704Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies705Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint706Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag707Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly708Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas709Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline710Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier711Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence712Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette713Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems714Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues715Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels716Importing rule specs at /builds/gitlab-org/gitlab/danger/specs717Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch718Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.3/lib/danger/rules/subtype_label719Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.3/lib/danger/rules/type_label720Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css721Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation722Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.3/lib/danger/rules/z_add_labels723Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata724Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.3/lib/danger/rules/z_retry_link725Results:726Warnings:727- [ ] This MR changes code in `ee/`, but its Changelog commit is missing the [`EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes). Consider adding it to your Changelog commits.728- [ ] This merge request is quite big (818 lines changed), please consider splitting it into multiple merge requests.729- [ ] be684d98a459aae553418880baf3ee50df245a74: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).730- [ ] 81798a4ab4ea92ae24c1e24982381c8899260c94: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).731Messages:732- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.733Markdown:734## Documentation review735The following files require a review from a technical writer:736* `doc/api/graphql/reference/index.md` ([Link to current live version](https://docs.gitlab.com/ee/api/graphql/reference/))737The review does not need to block merging this merge request. See the:738- [Metadata for the `*.md` files](https://docs.gitlab.com/ee/development/documentation/#metadata) that you've changed. The first few lines of each `*.md` file identify the stage and group most closely associated with your docs change.739- The [Technical Writer assigned](https://about.gitlab.com/handbook/engineering/technical-writing/#assignments) for that stage and group.740- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.741## Reviewer roulette742Changes that require review have been detected!743Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:744| Category | Reviewer | Maintainer |745| -------- | -------- | ---------- |746| ~"backend" | [Kassio Borges](https://gitlab.com/kassio)  (`@kassio`) (UTC+0) | [Tetiana Chupryna](https://gitlab.com/brytannia)  (`@brytannia`) (UTC+1) |747| ~"frontend" | [Deepika Guliani](https://gitlab.com/deepika.guliani)  (`@deepika.guliani`) (UTC+5.5) | [Jose Ivan Vargas](https://gitlab.com/jivanvl)  (`@jivanvl`) (UTC-6) |748To spread load more evenly across eligible reviewers, Danger has picked a candidate for each749review slot, based on their timezone. Feel free to750[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)751if you think someone else would be better-suited752or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.753To read more on how to use the reviewer roulette, please take a look at the754[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)755and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).756Please consider assigning a reviewer or maintainer who is a757[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.758Once you've decided who will review this merge request, assign them as a reviewer!759Danger does not automatically notify them for you.760**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/3445383725) that generated this comment.**761==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"' succeeded in 14 seconds.763Not uploading cache ruby-gems-debian-bullseye-ruby-2.7-16 due to policy764Not uploading cache node-modules-bullseye-test-16 due to policy766Job succeeded