Skip to content
Snippets Groups Projects

danger-review

Passed Started by
Miguel Rincon
@mrincon
1Running with gitlab-runner 15.6.0~beta.186.ga889181a (a889181a)
2 on blue-3.private.runners-manager.gitlab.com/gitlab.com/gitlab-org 6io2xoDD
3 feature flags: FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true
4 Resolving secrets 00:00
5 Preparing the "docker+machine" executor 00:04
6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-103-yarn-1.22-graphicsmagick-1.3.36 ...
7Authenticating with credentials from job payload (GitLab Registry)
8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-103-yarn-1.22-graphicsmagick-1.3.36 ...
9Using docker image sha256:5c5404ecc69273636c3ef49645be715ef30ea99e51ad146a2efbeac2a1875f9c for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-103-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12@sha256:b032fe79dc0bf3ebfaeb610c82eacc500fbd0ec6e01889444011cf5a72b4135d ...
10 Preparing environment 00:00
11Running on runner-6io2xodd-project-278964-concurrent-0 via runner-6io2xodd-private-1668421665-fdf2ef73...
12 Getting source from Git repository 00:48
13$ eval "$CI_PRE_CLONE_SCRIPT"
14Fetching changes with git depth set to 20...
15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/
16Created fresh repository.
17remote: Enumerating objects: 134386, done.
18remote: Counting objects: 100% (134386/134386), done.
19remote: Compressing objects: 100% (87585/87585), done.
20remote: Total 134386 (delta 60654), reused 92571 (delta 41765), pack-reused 0
21Receiving objects: 100% (134386/134386), 116.33 MiB | 20.24 MiB/s, done.
22Resolving deltas: 100% (60654/60654), done.
23From https://git-us-east1-c.ci-gateway.int.gprd.gitlab.net:8989/gitlab-org/gitlab
24 * [new ref] refs/pipelines/693894100 -> refs/pipelines/693894100
25Checking out 5648e5c9 as refs/merge-requests/102535/merge...
26Skipping Git submodules setup
27$ git remote set-url origin "${CI_REPOSITORY_URL}"
28 Restoring cache 00:43
29Checking cache for ruby-gems-debian-bullseye-ruby-2.7-16...
30Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bullseye-ruby-2.7-16
31Successfully extracted cache
32Checking cache for node-modules-bullseye-test-16...
33cache.zip is up to date
34Successfully extracted cache
35 Executing "step_script" stage of the job script 00:50
36Using docker image sha256:5c5404ecc69273636c3ef49645be715ef30ea99e51ad146a2efbeac2a1875f9c for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-103-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12@sha256:b032fe79dc0bf3ebfaeb610c82eacc500fbd0ec6e01889444011cf5a72b4135d ...
37$ source scripts/utils.sh
38$ bundle_install_script "--with danger"
39 Installing gems 00:41
671$ yarn_install_script
672 Installing Yarn packages 00:01
681$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command
682$ bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"
683Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb
684Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb
685Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb
686Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb
687Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb
688Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb
689Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb
690Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb
691Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture
692Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates
693Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.2/lib/danger/rules/changelog
694Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.2/lib/danger/rules/changes_size
695/builds/gitlab-org/gitlab/danger/gitaly/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE
696/builds/gitlab-org/gitlab/danger/ci_templates/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here
697Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config
698Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates
699Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.2/lib/danger/rules/commit_messages
700Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.2/lib/danger/rules/commits_counter
701Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files
702Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success
703Importing rule database at /builds/gitlab-org/gitlab/danger/database
704Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam
705Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation
706Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies
707Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint
708Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag
709Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly
710Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas
711Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline
712Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier
713Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence
714Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette
715Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems
716Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues
717Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels
718Importing rule specs at /builds/gitlab-org/gitlab/danger/specs
719Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.2/lib/danger/rules/subtype_label
720Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.2/lib/danger/rules/type_label
721Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css
722Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation
723Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.2/lib/danger/rules/z_add_labels
724Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata
725Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.6.2/lib/danger/rules/z_retry_link
726Results:
727Warnings:
728- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://about.gitlab.com/handbook/product/ux/technical-writing/#assignments).
729For more information, see:
730- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).
731- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.
732Markdown:
733## Reviewer roulette
734Changes that require review have been detected!
735Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
736| Category | Reviewer | Maintainer |
737| -------- | -------- | ---------- |
738| ~"frontend" | [Ammar Alakkad](https://gitlab.com/aalakkad) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/aalakkad.svg) (`@aalakkad`) (UTC+3, 2 hours ahead of `@mrincon`) | [Vitaly Slobodin](https://gitlab.com/vitallium) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/vitallium.svg) (`@vitallium`) (UTC+1, same timezone as `@mrincon`) |
739| ~UX | [Sunjung Park](https://gitlab.com/sunjungp) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-svg/sunjungp.svg) (`@sunjungp`) (UTC+1, same timezone as `@mrincon`) | Maintainer review is optional for ~UX |
740To spread load more evenly across eligible reviewers, Danger has picked a candidate for each
741review slot, based on their timezone. Feel free to
742[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)
743if you think someone else would be better-suited
744or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.
745To read more on how to use the reviewer roulette, please take a look at the
746[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)
747and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).
748Please consider assigning a reviewer or maintainer who is a
749[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.
750Once you've decided who will review this merge request, assign them as a reviewer!
751Danger does not automatically notify them for you.
752**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/3318206663) that generated this comment.**
753==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"' succeeded in 8 seconds.
754 Saving cache for successful job 00:00
755Not uploading cache ruby-gems-debian-bullseye-ruby-2.7-16 due to policy
756Not uploading cache node-modules-bullseye-test-16 due to policy
757 Cleaning up project directory and file based variables 00:01
758Job succeeded