danger-review
Passed Started
by
@dbalexandre
Douglas Barbosa Alexandre
1Running with gitlab-runner 15.4.0~beta.5.gdefc7017 (defc7017)2 on blue-2.private.runners-manager.gitlab.com/gitlab.com/gitlab-org QvBVRoXM3 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-103-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-103-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:0de04b8fae6d288f2674c8ee330dead655389b1f4c48fa027d76f2d798deadaf for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-103-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12@sha256:3632d3da2a61b74f7c4724eb8752b609c16b498daf20e9800a9c44629adab0bc ...11Running on runner-qvbvroxm-project-278964-concurrent-0 via runner-qvbvroxm-private-1661357844-4806eac5...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 115695, done. 18remote: Counting objects: 100% (115695/115695), done. 19remote: Compressing objects: 100% (77168/77168), done. 20remote: Total 115695 (delta 47766), reused 80641 (delta 34098), pack-reused 0 21Receiving objects: 100% (115695/115695), 110.33 MiB | 23.73 MiB/s, done.22Resolving deltas: 100% (47766/47766), done.24 * [new ref] refs/pipelines/621982466 -> refs/pipelines/62198246625Checking out 63997366 as refs/merge-requests/95971/merge...26Skipping Git submodules setup27$ git remote set-url origin "${CI_REPOSITORY_URL}"29Checking cache for ruby-gems-debian-bullseye-ruby-2.7-14...30cache.zip is up to date 31Successfully extracted cache32Checking cache for node-modules-bullseye-test-14...33cache.zip is up to date 34Successfully extracted cache36Using docker image sha256:0de04b8fae6d288f2674c8ee330dead655389b1f4c48fa027d76f2d798deadaf for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-103-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12@sha256:3632d3da2a61b74f7c4724eb8752b609c16b498daf20e9800a9c44629adab0bc ...37$ source scripts/utils.sh38$ bundle_install_script "--with danger"393.2.3340Bundler version 2.2.3341Successfully installed bundler-2.3.15421 gem installed43production:development44Settings are listed in order of priority. The top value will be used.45clean46Set for your local app (/builds/gitlab-org/gitlab/.bundle/config): true47frozen48Set via BUNDLE_FROZEN: true49install_flags50Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"51path52Set for your local app (/builds/gitlab-org/gitlab/.bundle/config): "/builds/gitlab-org/gitlab/vendor"53without54Set via BUNDLE_WITHOUT: [:production, :development]55$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check56[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local with 'danger'`, and stop using this flag57Don't run Bundler as root. Bundler can ask for sudo if it is needed, and58installing your bundle as root will break this application for all non-root59users on this machine.60The Gemfile's dependencies are satisfied61==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 2 seconds.62$ bundle pristine pg63Installing pg 1.4.1 with native extensions64==> 'bundle pristine pg' succeeded in 10 seconds.65$ run_timed_command "retry yarn install --frozen-lockfile"66$ retry yarn install --frozen-lockfile67yarn install v1.22.1768[1/5] Validating package.json...69[2/5] Resolving packages...70success Already up-to-date.71$ node ./scripts/frontend/postinstall.js72success Dependency postinstall check passed.73success Packages successfully patched.74Done in 1.09s.75==> 'retry yarn install --frozen-lockfile' succeeded in 2 seconds.76$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command77$ bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"78Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb79Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb80Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb81Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb82Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb83Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb84Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb85Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates86Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.5.0/lib/danger/rules/changelog87Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.5.0/lib/danger/rules/changes_size88Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config89Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates90Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.5.0/lib/danger/rules/commit_messages91/builds/gitlab-org/gitlab/danger/gitaly/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE92/builds/gitlab-org/gitlab/danger/ci_templates/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here93Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.5.0/lib/danger/rules/commits_counter94Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success95Importing rule database at /builds/gitlab-org/gitlab/danger/database96Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam97Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation98Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies99Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint100Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag101Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly102Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas103Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline104Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier105Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence106Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette107Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues108Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels109Importing rule specs at /builds/gitlab-org/gitlab/danger/specs110Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.5.0/lib/danger/rules/subtype_label111Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.5.0/lib/danger/rules/type_label112Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css113Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation114Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.5.0/lib/danger/rules/z_add_labels115Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata116Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.5.0/lib/danger/rules/z_retry_link117Results:118Warnings:119- [ ] c9008ad4cdbad7862d9490344896b4f975bcf109: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).120Markdown:121## Reviewer roulette122Changes that require review have been detected!123Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:124| Category | Reviewer | Maintainer |125| -------- | -------- | ---------- |126| ~"backend" | [Aman Luthra](https://gitlab.com/aluthra2) (`@aluthra2`) (UTC+5.5, 4.5 hours behind `@thiagocsf`) | [Douglas Barbosa Alexandre](https://gitlab.com/dbalexandre) (`@dbalexandre`) (UTC-3, 13 hours behind `@thiagocsf`) |127| ~"Compliance" | Reviewer review is optional for ~"Compliance" | [Huzaifa Iftikhar](https://gitlab.com/huzaifaiftikhar1) (`@huzaifaiftikhar1`) (UTC+5.5, 4.5 hours behind `@thiagocsf`) |128To spread load more evenly across eligible reviewers, Danger has picked a candidate for each129review slot, based on their timezone. Feel free to130[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)131if you think someone else would be better-suited132or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.133To read more on how to use the reviewer roulette, please take a look at the134[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)135and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).136Please consider assigning a reviewer or maintainer who is a137[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.138Once you've decided who will review this merge request, assign them as a reviewer!139Danger does not automatically notify them for you.140**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/2929379687) that generated this comment.**141==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id="2ee1c7" --dangerfile="Dangerfile"' succeeded in 7 seconds.143Not uploading cache ruby-gems-debian-bullseye-ruby-2.7-14 due to policy144Not uploading cache node-modules-bullseye-test-14 due to policy146Job succeeded