danger-review
Passed Started
by
@furkanayhan
Furkan Ayhan
1Running with gitlab-runner 15.3.0~beta.42.gdb7789ca (db7789ca)2 on green-1.private.runners-manager.gitlab.com/gitlab.com/gitlab-org 4bq1s9yM3 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-103-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-103-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:dbe958b16798d63b4e9b087c16e159dd892084397f3133389f4c4deb62bf68b1 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-103-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12@sha256:0fbceb489337ce4ef10255420b84e2b2c53ec5a6b07d2c52e11d96e44fb977f1 ...11Running on runner-4bq1s9ym-project-278964-concurrent-0 via runner-4bq1s9ym-private-1660803448-4360eccf...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 104748, done. 18remote: Counting objects: 100% (104748/104748), done. 19remote: Compressing objects: 100% (72895/72895), done. 20remote: Total 104748 (delta 39197), reused 71764 (delta 27764), pack-reused 0 21Receiving objects: 100% (104748/104748), 107.60 MiB | 30.72 MiB/s, done.22Resolving deltas: 100% (39197/39197), done.24 * [new ref] refs/pipelines/616624931 -> refs/pipelines/61662493125Checking out ca1c1b5e as refs/merge-requests/95682/merge...26Skipping Git submodules setup27$ git remote set-url origin "${CI_REPOSITORY_URL}"29Checking cache for ruby-gems-debian-bullseye-ruby-2.7-14...30cache.zip is up to date 31Successfully extracted cache32Checking cache for node-modules-bullseye-test-14...33Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-14 34Successfully extracted cache36Using docker image sha256:dbe958b16798d63b4e9b087c16e159dd892084397f3133389f4c4deb62bf68b1 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-103-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12@sha256:0fbceb489337ce4ef10255420b84e2b2c53ec5a6b07d2c52e11d96e44fb977f1 ...37$ source scripts/utils.sh38$ bundle_install_script "--with danger"393.2.3340Bundler version 2.2.3341Successfully installed bundler-2.3.15421 gem installed43production:development44Settings are listed in order of priority. The top value will be used.45clean46Set for your local app (/builds/gitlab-org/gitlab/.bundle/config): true47frozen48Set via BUNDLE_FROZEN: true49install_flags50Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"51path52Set for your local app (/builds/gitlab-org/gitlab/.bundle/config): "/builds/gitlab-org/gitlab/vendor"53without54Set via BUNDLE_WITHOUT: [:production, :development]55$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check56[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local with 'danger'`, and stop using this flag57Don't run Bundler as root. Bundler can ask for sudo if it is needed, and58installing your bundle as root will break this application for all non-root59users on this machine.60The Gemfile's dependencies are satisfied61==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 2 seconds.62$ bundle pristine pg63Installing pg 1.4.1 with native extensions64$ run_timed_command "retry yarn install --frozen-lockfile"65==> 'bundle pristine pg' succeeded in 10 seconds.66$ retry yarn install --frozen-lockfile67yarn install v1.22.1768[1/5] Validating package.json...69[2/5] Resolving packages...70[3/5] Fetching packages...71[4/5] Linking dependencies...72warning "@gitlab/eslint-plugin > eslint-plugin-jest > @typescript-eslint/experimental-utils > @typescript-eslint/typescript-estree > tsutils@3.17.1" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".73warning "@graphql-eslint/eslint-plugin > graphql-config > @endemolshinegroup/cosmiconfig-typescript-loader > ts-node@9.1.1" has unmet peer dependency "typescript@>=2.7".74warning " > eslint-import-resolver-jest@3.0.2" has unmet peer dependency "eslint-plugin-import@>=1.4.0".75warning " > eslint-import-resolver-webpack@0.13.2" has unmet peer dependency "eslint-plugin-import@>=1.4.0".76warning Workspaces can only be enabled in private projects.77[5/5] Building fresh packages...78$ node ./scripts/frontend/postinstall.js79success Dependency postinstall check passed.80success Packages successfully patched.81Done in 72.25s.82==> 'retry yarn install --frozen-lockfile' succeeded in 74 seconds.83$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command84$ bundle exec danger --fail-on-errors=true --verbose --danger_id="7feab8" --dangerfile="Dangerfile"85Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb86Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb87Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb88Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb89Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb90Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb91Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb92Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates93Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.5.0/lib/danger/rules/changelog94Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.5.0/lib/danger/rules/changes_size95/builds/gitlab-org/gitlab/danger/gitaly/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE96/builds/gitlab-org/gitlab/danger/ci_templates/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here97Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config98Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates99Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.5.0/lib/danger/rules/commit_messages100Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.5.0/lib/danger/rules/commits_counter101Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success102Importing rule database at /builds/gitlab-org/gitlab/danger/database103Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam104Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation105Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies106Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint107Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag108Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly109Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas110Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline111Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier112Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence113Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette114Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues115Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels116Importing rule specs at /builds/gitlab-org/gitlab/danger/specs117Importing rule subtype_label at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.5.0/lib/danger/rules/subtype_label118Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.5.0/lib/danger/rules/type_label119Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css120Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation121Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.5.0/lib/danger/rules/z_add_labels122Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata123Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.5.0/lib/danger/rules/z_retry_link124Results:125Warnings:126- [ ] This merge request changed CI config files but did not update the schema. Please consider updating [the schema](app/assets/javascripts/editor/schema/ci.json) to reflect these changes:127- `lib/gitlab/ci/config/entry/processable.rb`128- `lib/gitlab/ci/config/entry/variables.rb`129- `spec/lib/gitlab/ci/config/entry/root_spec.rb`.130Refer to the [docs](https://docs.gitlab.com/ee/development/cicd/schema.html#write-specs) for help on how to run and write specs for the CI schema.131Messages:132- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:133If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.134If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.135If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.136Markdown:137## Reviewer roulette138Changes that require review have been detected!139Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:140| Category | Reviewer | Maintainer |141| -------- | -------- | ---------- |142| ~"backend" | [Serhii Yarynovskyi](https://gitlab.com/syarynovskyi) (`@syarynovskyi`) (UTC+3, 1 hour ahead of `@furkanayhan`) | [Doug Stull](https://gitlab.com/dstull) (`@dstull`) (UTC-4, 6 hours behind `@furkanayhan`) |143To spread load more evenly across eligible reviewers, Danger has picked a candidate for each144review slot, based on their timezone. Feel free to145[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)146if you think someone else would be better-suited147or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.148To read more on how to use the reviewer roulette, please take a look at the149[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)150and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).151Please consider assigning a reviewer or maintainer who is a152[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.153Once you've decided who will review this merge request, assign them as a reviewer!154Danger does not automatically notify them for you.155**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/2900523006) that generated this comment.**156==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id="7feab8" --dangerfile="Dangerfile"' succeeded in 9 seconds.158Not uploading cache ruby-gems-debian-bullseye-ruby-2.7-14 due to policy159Not uploading cache node-modules-bullseye-test-14 due to policy161Job succeeded