danger-review

Passed Started 2 years ago by
1Running with gitlab-runner 15.2.0~beta.17.g34ae4a68 (34ae4a68)
2  on green-2.private.runners-manager.gitlab.com/gitlab.com/gitlab-org GaSD-S1F
3  feature flags: FF_USE_FASTZIP:true
 4  Resolving secrets  
  00:00
 5  Preparing the "docker+machine" executor  
  00:03
6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 ...
7Authenticating with credentials from job payload (GitLab Registry)
8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 ...
9Using docker image sha256:fd40b0aa863019e7fe9616bf6665ba24d356a369a8b92582a8df89544e3b7544 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12@sha256:fc314d19087f24a5d21b479ce7a6dc7778b8c941d21ecbe4d62760c7dc533470 ...
 10  Preparing environment  
  00:00
11Running on runner-gasd-s1f-project-278964-concurrent-0 via runner-gasd-s1f-private-1657874528-6b27e72e...
 12  Getting source from Git repository  
  00:25
13$ eval "$CI_PRE_CLONE_SCRIPT"
14Fetching changes with git depth set to 20...
15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/
16Created fresh repository.
17remote: Enumerating objects: 110290, done.        
18remote: Counting objects: 100% (110290/110290), done.        
19remote: Compressing objects: 100% (78141/78141), done.        
20remote: Total 110290 (delta 44797), reused 71039 (delta 28035), pack-reused 0        
21Receiving objects: 100% (110290/110290), 107.16 MiB | 22.58 MiB/s, done.
22Resolving deltas: 100% (44797/44797), done.
23From https://git-us-east1-d.ci-gateway.int.gprd.gitlab.net:8989/gitlab-org/gitlab
24 * [new ref]             refs/pipelines/588834597 -> refs/pipelines/588834597
25Checking out daeb34bc as refs/merge-requests/92351/merge...
26Skipping Git submodules setup
27$ git remote set-url origin "${CI_REPOSITORY_URL}"
 28  Restoring cache  
  00:45
29Checking cache for ruby-gems-debian-bullseye-ruby-2.7-14...
30cache.zip is up to date                            
31Successfully extracted cache
32Checking cache for node-modules-bullseye-test-14...
33cache.zip is up to date                            
34Successfully extracted cache
 35  Executing "step_script" stage of the job script  
  00:23
36Using docker image sha256:fd40b0aa863019e7fe9616bf6665ba24d356a369a8b92582a8df89544e3b7544 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12@sha256:fc314d19087f24a5d21b479ce7a6dc7778b8c941d21ecbe4d62760c7dc533470 ...
37$ source scripts/utils.sh
38$ bundle_install_script "--with danger"
393.2.33
40Bundler version 2.2.33
41Successfully installed bundler-2.3.15
421 gem installed
43production:development
44Settings are listed in order of priority. The top value will be used.
45clean
46Set for your local app (/builds/gitlab-org/gitlab/.bundle/config): true
47frozen
48Set via BUNDLE_FROZEN: true
49install_flags
50Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"
51path
52Set for your local app (/builds/gitlab-org/gitlab/.bundle/config): "/builds/gitlab-org/gitlab/vendor"
53without
54Set via BUNDLE_WITHOUT: [:production, :development]
55$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check
56[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local with 'danger'`, and stop using this flag
57Don't run Bundler as root. Bundler can ask for sudo if it is needed, and
58installing your bundle as root will break this application for all non-root
59users on this machine.
60The Gemfile's dependencies are satisfied
61==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 2 seconds.
62$ bundle pristine pg
63Installing pg 1.3.5 with native extensions
64==> 'bundle pristine pg' succeeded in 11 seconds.
65$ run_timed_command "retry yarn install --frozen-lockfile"
66$ retry yarn install --frozen-lockfile
67yarn install v1.22.17
68[1/5] Validating package.json...
69[2/5] Resolving packages...
70success Already up-to-date.
71$ node ./scripts/frontend/postinstall.js
72success Dependency postinstall check passed.
73success Packages successfully patched.
74Done in 1.19s.
75==> 'retry yarn install --frozen-lockfile' succeeded in 3 seconds.
76$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command
77$ bundle exec danger --fail-on-errors=true --verbose --danger_id=7feab8
78Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb
79Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb
80Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb
81Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb
82Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb
83Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb
84Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates
85Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.3/lib/danger/rules/changelog
86Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.3/lib/danger/rules/changes_size
87/builds/gitlab-org/gitlab/danger/gitaly/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE
88/builds/gitlab-org/gitlab/danger/ci_templates/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here
89Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config
90Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates
91Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.3/lib/danger/rules/commit_messages
92Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.3/lib/danger/rules/commits_counter
93Importing rule database at /builds/gitlab-org/gitlab/danger/database
94Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam
95Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation
96Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies
97Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint
98Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag
99Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly
100Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas
101Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline
102Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier
103Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence
104Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette
105Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues
106Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels
107Importing rule specs at /builds/gitlab-org/gitlab/danger/specs
108Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.3/lib/danger/rules/type_label
109Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css
110Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation
111Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.3/lib/danger/rules/z_add_labels
112Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata
113Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.3/lib/danger/rules/z_retry_link
114Results:
115Warnings:
116- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://about.gitlab.com/handbook/engineering/ux/technical-writing/#assignments).
117For more information, see:
118- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).
119- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.
120Markdown:
121## Reviewer roulette
122Changes that require review have been detected!
123Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
124| Category | Reviewer | Maintainer |
125| -------- | -------- | ---------- |
126| ~backend | [Zamir Martins Filho](https://gitlab.com/zmartins) (`@zmartins`) (UTC-4, 6 hours behind `@alexbuijs`) | [Alexandru Croitor](https://gitlab.com/acroitor) (`@acroitor`) (UTC+3, 1 hour ahead of `@alexbuijs`) |
127| ~frontend | [Minahil Nichols](https://gitlab.com/minahilnichols) (`@minahilnichols`) (UTC-4, 6 hours behind `@alexbuijs`) | [Natalia Tepluhina](https://gitlab.com/ntepluhina) (`@ntepluhina`) (UTC+2, same timezone as `@alexbuijs`) |
128| ~test for `spec/features/*` | [Zamir Martins Filho](https://gitlab.com/zmartins) (`@zmartins`) (UTC-4, 6 hours behind `@alexbuijs`) | Maintainer review is optional for ~test for `spec/features/*` |
129| ~UX | [Becka Lippert](https://gitlab.com/beckalippert) (`@beckalippert`) (UTC-4, 6 hours behind `@alexbuijs`) | [Amelia Bauerly](https://gitlab.com/ameliabauerly) (`@ameliabauerly`) (UTC-7, 9 hours behind `@alexbuijs`) |
130To spread load more evenly across eligible reviewers, Danger has picked a candidate for each
131review slot, based on their timezone. Feel free to
132[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)
133if you think someone else would be better-suited
134or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.
135To read more on how to use the reviewer roulette, please take a look at the
136[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)
137and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).
138Please consider assigning a reviewer or maintainer who is a
139[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.
140Once you've decided who will review this merge request, assign them as a reviewer!
141Danger does not automatically notify them for you.
142**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/2726974141) that generated this comment.**
143==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id=7feab8' succeeded in 5 seconds.
 144  Saving cache for successful job  
  00:01
145Not uploading cache ruby-gems-debian-bullseye-ruby-2.7-14 due to policy
146Not uploading cache node-modules-bullseye-test-14 due to policy
 147  Cleaning up project directory and file based variables  
  00:00
148Job succeeded