danger-review
Passed Started
by
@fguibert
Florie Guibert
1Running with gitlab-runner 15.2.0~beta.17.g34ae4a68 (34ae4a68)2 on green-1.private.runners-manager.gitlab.com/gitlab.com/gitlab-org 4bq1s9yM3 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:fd40b0aa863019e7fe9616bf6665ba24d356a369a8b92582a8df89544e3b7544 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12@sha256:fc314d19087f24a5d21b479ce7a6dc7778b8c941d21ecbe4d62760c7dc533470 ...11Running on runner-4bq1s9ym-project-278964-concurrent-0 via runner-4bq1s9ym-private-1657155259-5c1b7243...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 107798, done. 18remote: Counting objects: 100% (107798/107798), done. 19remote: Compressing objects: 100% (76542/76542), done. 20remote: Total 107798 (delta 42645), reused 69839 (delta 27219), pack-reused 0 21Receiving objects: 100% (107798/107798), 104.24 MiB | 30.09 MiB/s, done.22Resolving deltas: 100% (42645/42645), done.24 * [new ref] refs/pipelines/581948065 -> refs/pipelines/58194806525Checking out 5ef8e465 as refs/merge-requests/91652/merge...26Skipping Git submodules setup27$ git remote set-url origin "${CI_REPOSITORY_URL}"29Checking cache for ruby-gems-debian-bullseye-ruby-2.7-14...30Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bullseye-ruby-2.7-14 31Successfully extracted cache32Checking cache for node-modules-bullseye-test-14...33Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-14 34Successfully extracted cache36Using docker image sha256:fd40b0aa863019e7fe9616bf6665ba24d356a369a8b92582a8df89544e3b7544 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12@sha256:fc314d19087f24a5d21b479ce7a6dc7778b8c941d21ecbe4d62760c7dc533470 ...37$ source scripts/utils.sh38$ bundle_install_script "--with danger"393.2.3340Bundler version 2.2.3341Successfully installed bundler-2.3.15421 gem installed43production:development44Settings are listed in order of priority. The top value will be used.45clean46Set for your local app (/builds/gitlab-org/gitlab/.bundle/config): true47frozen48Set via BUNDLE_FROZEN: true49install_flags50Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"51path52Set for your local app (/builds/gitlab-org/gitlab/.bundle/config): "/builds/gitlab-org/gitlab/vendor"53without54Set via BUNDLE_WITHOUT: [:production, :development]55$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check56[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local with 'danger'`, and stop using this flag57Don't run Bundler as root. Bundler can ask for sudo if it is needed, and58installing your bundle as root will break this application for all non-root59users on this machine.60The Gemfile's dependencies are satisfied61==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 2 seconds.62$ bundle pristine pg63Installing pg 1.3.5 with native extensions64==> 'bundle pristine pg' succeeded in 10 seconds.65$ run_timed_command "retry yarn install --frozen-lockfile"66$ retry yarn install --frozen-lockfile67yarn install v1.22.1768[1/5] Validating package.json...69[2/5] Resolving packages...70success Already up-to-date.71$ node ./scripts/frontend/postinstall.js72success Dependency postinstall check passed.73success Packages successfully patched.74Done in 1.17s.75==> 'retry yarn install --frozen-lockfile' succeeded in 2 seconds.76$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command77$ bundle exec danger --fail-on-errors=true --verbose --danger_id=7feab878Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb79Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb80Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb81Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb82Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb83Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb84Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates85Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/changelog86Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/changes_size87/builds/gitlab-org/gitlab/danger/gitaly/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE88/builds/gitlab-org/gitlab/danger/ci_templates/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here89Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config90Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates91Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/commit_messages92Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/commits_counter93Importing rule database at /builds/gitlab-org/gitlab/danger/database94Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam95Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation96Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies97Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint98Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag99Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly100Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas101Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline102Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier103Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence104Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette105Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues106Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels107Importing rule specs at /builds/gitlab-org/gitlab/danger/specs108Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/type_label109Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css110Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation111Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/z_add_labels112Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata113Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/z_retry_link114Results:115Markdown:116## Reviewer roulette117Changes that require review have been detected!118Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:119| Category | Reviewer | Maintainer |120| -------- | -------- | ---------- |121| ~backend | [Thomas Hutterer](https://gitlab.com/thutterer) (`@thutterer`) (UTC+2, 3.5 hours behind `@snachnolkar`) | [Alex Pooley](https://gitlab.com/alexpooley) (`@alexpooley`) (UTC+8, 2.5 hours ahead of `@snachnolkar`) |122| ~frontend | [Samantha Ming](https://gitlab.com/sming-gitlab) (`@sming-gitlab`) (UTC+2, 3.5 hours behind `@snachnolkar`) | [Florie Guibert](https://gitlab.com/fguibert) (`@fguibert`) (UTC+10, 4.5 hours ahead of `@snachnolkar`) |123| ~test for `spec/features/*` | [Sean Gregory](https://gitlab.com/sgregory2) (`@sgregory2`) (UTC-4, 9.5 hours behind `@snachnolkar`) | Maintainer review is optional for ~test for `spec/features/*` |124To spread load more evenly across eligible reviewers, Danger has picked a candidate for each125review slot, based on their timezone. Feel free to126[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)127if you think someone else would be better-suited128or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.129To read more on how to use the reviewer roulette, please take a look at the130[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)131and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).132Please consider assigning a reviewer or maintainer who is a133[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.134Once you've decided who will review this merge request, assign them as a reviewer!135Danger does not automatically notify them for you.136**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/2688595249) that generated this comment.**137==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id=7feab8' succeeded in 6 seconds.139Not uploading cache ruby-gems-debian-bullseye-ruby-2.7-14 due to policy140Not uploading cache node-modules-bullseye-test-14 due to policy142Job succeeded