Skip to content
Snippets Groups Projects

danger-review

Passed Started by
Max Woolf
@mwoolf
1Running with gitlab-runner 15.2.0~beta.17.g34ae4a68 (34ae4a68)
2 on green-2.private.runners-manager.gitlab.com/gitlab.com/gitlab-org GaSD-S1F
3 feature flags: FF_USE_FASTZIP:true
4 Resolving secrets 00:00
5 Preparing the "docker+machine" executor 00:03
6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 ...
7Authenticating with credentials from job payload (GitLab Registry)
8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 ...
9Using docker image sha256:34c44820e60f494e1559bdea8f2b0eb5619bbc57a994ebb31f7d526da51356d6 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12@sha256:49a3c3782def290d9f2cd6a3d317363184f5a73cd3ba5f465c6916aca94644f6 ...
10 Preparing environment 00:01
11Running on runner-gasd-s1f-project-278964-concurrent-0 via runner-gasd-s1f-private-1657096851-4df630cc...
12 Getting source from Git repository 00:20
13$ eval "$CI_PRE_CLONE_SCRIPT"
14Fetching changes with git depth set to 20...
15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/
16Created fresh repository.
17remote: Enumerating objects: 105656, done.
18remote: Counting objects: 100% (105656/105656), done.
19remote: Compressing objects: 100% (75924/75924), done.
20remote: Total 105656 (delta 40856), reused 67955 (delta 25743), pack-reused 0
21Receiving objects: 100% (105656/105656), 103.98 MiB | 34.19 MiB/s, done.
22Resolving deltas: 100% (40856/40856), done.
23From https://git-us-east1-d.ci-gateway.int.gprd.gitlab.net:8989/gitlab-org/gitlab
24 * [new ref] refs/pipelines/581337618 -> refs/pipelines/581337618
25Checking out e4b447a9 as refs/merge-requests/91869/merge...
26Skipping Git submodules setup
27$ git remote set-url origin "${CI_REPOSITORY_URL}"
28 Restoring cache 00:32
29Checking cache for ruby-gems-debian-bullseye-ruby-2.7-14...
30Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bullseye-ruby-2.7-14
31Successfully extracted cache
32Checking cache for node-modules-bullseye-test-14...
33Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-14
34Successfully extracted cache
35 Executing "step_script" stage of the job script 00:23
36Using docker image sha256:34c44820e60f494e1559bdea8f2b0eb5619bbc57a994ebb31f7d526da51356d6 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12@sha256:49a3c3782def290d9f2cd6a3d317363184f5a73cd3ba5f465c6916aca94644f6 ...
37$ source scripts/utils.sh
38$ bundle_install_script "--with danger"
393.2.33
40Bundler version 2.2.33
41Successfully installed bundler-2.3.15
421 gem installed
43production:development
44Settings are listed in order of priority. The top value will be used.
45clean
46Set for your local app (/builds/gitlab-org/gitlab/.bundle/config): true
47frozen
48Set via BUNDLE_FROZEN: true
49install_flags
50Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"
51path
52Set for your local app (/builds/gitlab-org/gitlab/.bundle/config): "/builds/gitlab-org/gitlab/vendor"
53without
54Set via BUNDLE_WITHOUT: [:production, :development]
55$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check
56[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local with 'danger'`, and stop using this flag
57Don't run Bundler as root. Bundler can ask for sudo if it is needed, and
58installing your bundle as root will break this application for all non-root
59users on this machine.
60The Gemfile's dependencies are satisfied
61==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 1 seconds.
62$ bundle pristine pg
63Installing pg 1.3.5 with native extensions
64==> 'bundle pristine pg' succeeded in 9 seconds.
65$ run_timed_command "retry yarn install --frozen-lockfile"
66$ retry yarn install --frozen-lockfile
67yarn install v1.22.17
68[1/5] Validating package.json...
69[2/5] Resolving packages...
70success Already up-to-date.
71$ node ./scripts/frontend/postinstall.js
72success Dependency postinstall check passed.
73success Packages successfully patched.
74Done in 1.09s.
75==> 'retry yarn install --frozen-lockfile' succeeded in 3 seconds.
76$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command
77$ bundle exec danger --fail-on-errors=true --verbose --danger_id=7feab8
78Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb
79Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb
80Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb
81Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb
82Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb
83Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb
84Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates
85Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/changelog
86Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/changes_size
87/builds/gitlab-org/gitlab/danger/gitaly/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE
88/builds/gitlab-org/gitlab/danger/ci_templates/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here
89Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config
90Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates
91Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/commit_messages
92Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/commits_counter
93Importing rule database at /builds/gitlab-org/gitlab/danger/database
94Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam
95Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation
96Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies
97Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint
98Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag
99Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly
100Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas
101Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline
102Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier
103Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence
104Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette
105Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues
106Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels
107Importing rule specs at /builds/gitlab-org/gitlab/danger/specs
108Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/type_label
109Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css
110Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation
111Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/z_add_labels
112Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata
113Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/z_retry_link
114Results:
115Messages:
116- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.
117Markdown:
118## Documentation review
119The following files require a review from a technical writer:
120* `doc/api/audit_events.md`
121* `doc/api/index.md`
122The review does not need to block merging this merge request. See the:
123- [Metadata for the `*.md` files](https://docs.gitlab.com/ee/development/documentation/#metadata) that you've changed. The first few lines of each `*.md` file identify the stage and group most closely associated with your docs change.
124- The [Technical Writer assigned](https://about.gitlab.com/handbook/engineering/technical-writing/#assignments) for that stage and group.
125- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.
126## Reviewer roulette
127Changes that require review have been detected!
128Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
129| Category | Reviewer | Maintainer |
130| -------- | -------- | ---------- |
131| ~backend | [Jonathan Schafer](https://gitlab.com/jschafer) (`@jschafer`) (UTC-5, 6 hours behind `@mwoolf`) | [James Fargher](https://gitlab.com/proglottis) (`@proglottis`) (UTC+12, 11 hours ahead of `@mwoolf`) |
132To spread load more evenly across eligible reviewers, Danger has picked a candidate for each
133review slot, based on their timezone. Feel free to
134[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)
135if you think someone else would be better-suited
136or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.
137To read more on how to use the reviewer roulette, please take a look at the
138[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)
139and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).
140Please consider assigning a reviewer or maintainer who is a
141[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.
142Once you've decided who will review this merge request, assign them as a reviewer!
143Danger does not automatically notify them for you.
144**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/2685192285) that generated this comment.**
145==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id=7feab8' succeeded in 6 seconds.
146 Saving cache for successful job 00:00
147Not uploading cache ruby-gems-debian-bullseye-ruby-2.7-14 due to policy
148Not uploading cache node-modules-bullseye-test-14 due to policy
149 Cleaning up project directory and file based variables 00:01
150Job succeeded