danger-review
Passed Started
by
@leetickett
Lee Tickett
1Running with gitlab-runner 15.2.0~beta.17.g34ae4a68 (34ae4a68)2 on green-2.private.runners-manager.gitlab.com/gitlab.com/gitlab-org GaSD-S1F3 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:642191311550aaa03aba1d11d8d921042ead8ee5afeb833fc7e4e3f933b7ed04 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12@sha256:f0990c59018be757dd56365bb2cc6791d65f3f4bf99a431c3b26e3df08260f6a ...11Running on runner-gasd-s1f-project-278964-concurrent-0 via runner-gasd-s1f-private-1656912748-e3e523ac...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 115982, done. 18remote: Counting objects: 100% (115982/115982), done. 19remote: Compressing objects: 100% (81018/81018), done. 20remote: Total 115982 (delta 48513), reused 75495 (delta 30560), pack-reused 0 21Receiving objects: 100% (115982/115982), 108.44 MiB | 27.47 MiB/s, done.22Resolving deltas: 100% (48513/48513), done.24 * [new ref] refs/pipelines/579176392 -> refs/pipelines/57917639225Checking out 204b4379 as refs/merge-requests/91556/merge...26Skipping Git submodules setup27$ git remote set-url origin "${CI_REPOSITORY_URL}"29Checking cache for ruby-gems-debian-bullseye-ruby-2.7-10...30cache.zip is up to date 31Successfully extracted cache32Checking cache for node-modules-bullseye-test-10...33Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-10 34Successfully extracted cache36Using docker image sha256:642191311550aaa03aba1d11d8d921042ead8ee5afeb833fc7e4e3f933b7ed04 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12@sha256:f0990c59018be757dd56365bb2cc6791d65f3f4bf99a431c3b26e3df08260f6a ...37$ source scripts/utils.sh38$ bundle_install_script "--with danger"393.2.3340Bundler version 2.2.3341Successfully installed bundler-2.3.15421 gem installed43production:development44Settings are listed in order of priority. The top value will be used.45clean46Set for your local app (/builds/gitlab-org/gitlab/.bundle/config): true47frozen48Set via BUNDLE_FROZEN: true49install_flags50Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"51path52Set for your local app (/builds/gitlab-org/gitlab/.bundle/config): "/builds/gitlab-org/gitlab/vendor"53without54Set via BUNDLE_WITHOUT: [:production, :development]55$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check56[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local with 'danger'`, and stop using this flag57Don't run Bundler as root. Bundler can ask for sudo if it is needed, and58installing your bundle as root will break this application for all non-root59users on this machine.60The Gemfile's dependencies are satisfied61==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 1 seconds.62$ bundle pristine pg63Installing pg 1.3.5 with native extensions64==> 'bundle pristine pg' succeeded in 9 seconds.65$ run_timed_command "retry yarn install --frozen-lockfile"66$ retry yarn install --frozen-lockfile67yarn install v1.22.1768[1/5] Validating package.json...69[2/5] Resolving packages...70success Already up-to-date.71$ node ./scripts/frontend/postinstall.js72success Dependency postinstall check passed.73success Packages successfully patched.74Done in 1.12s.75==> 'retry yarn install --frozen-lockfile' succeeded in 2 seconds.76$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command77$ bundle exec danger --fail-on-errors=true --verbose --danger_id=7feab878Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb79Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb80Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/product_intelligence.rb81Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb82Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb83Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb84Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates85Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/changelog86Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/changes_size87/builds/gitlab-org/gitlab/danger/gitaly/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE88/builds/gitlab-org/gitlab/danger/ci_templates/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here89Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config90Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates91Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/commit_messages92Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/commits_counter93Importing rule database at /builds/gitlab-org/gitlab/danger/database94Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam95Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation96Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies97Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint98Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag99Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly100Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas101Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline102Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier103Importing rule product_intelligence at /builds/gitlab-org/gitlab/danger/product_intelligence104Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette105Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues106Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels107Importing rule specs at /builds/gitlab-org/gitlab/danger/specs108Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/type_label109Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css110Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation111Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/z_add_labels112Importing rule z_metadata at /builds/gitlab-org/gitlab/danger/z_metadata113Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/gitlab-dangerfiles-3.4.2/lib/danger/rules/z_retry_link114Results:115Warnings:116- [ ] Please add a [merge request type](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification) to this merge request.117Messages:118- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:119If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.120If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.121If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.122Markdown:123## Reviewer roulette124Changes that require review have been detected!125Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:126| Category | Reviewer | Maintainer |127| -------- | -------- | ---------- |128| ~backend | [Mehmet Emin Inac](https://gitlab.com/minac) (`@minac`) (UTC+3) | [Dylan Griffith](https://gitlab.com/DylanGriffith) (`@DylanGriffith`) (UTC+10) |129To spread load more evenly across eligible reviewers, Danger has picked a candidate for each130review slot, based on their timezone. Feel free to131[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)132if you think someone else would be better-suited133or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.134To read more on how to use the reviewer roulette, please take a look at the135[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)136and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).137Please consider assigning a reviewer or maintainer who is a138[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.139Once you've decided who will review this merge request, assign them as a reviewer!140Danger does not automatically notify them for you.141**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/2673338082) that generated this comment.**142==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id=7feab8' succeeded in 6 seconds.144Not uploading cache ruby-gems-debian-bullseye-ruby-2.7-10 due to policy145Not uploading cache node-modules-bullseye-test-10 due to policy147Job succeeded