danger-review
Passed Started
by
@splattael
Peter Leitzen
1Running with gitlab-runner 15.1.0~beta.20.g62206bb2 (62206bb2)2 on blue-2.private.runners-manager.gitlab.com/gitlab.com/gitlab-org QvBVRoXM3 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:1c23a0bd0711f9f7944305c4b25ce8e4301c16167671a7873aad77579270806d for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12@sha256:d0052322332df372b949caf19e910c0ce6859c1e7ed29ff609ebec91b1dead87 ...11Running on runner-qvbvroxm-project-278964-concurrent-0 via runner-qvbvroxm-private-1656532361-7d6e4104...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 108133, done. 18remote: Counting objects: 100% (108133/108133), done. 19remote: Compressing objects: 100% (78029/78029), done. 20remote: Total 108133 (delta 41971), reused 69318 (delta 25782), pack-reused 0 21Receiving objects: 100% (108133/108133), 107.22 MiB | 35.06 MiB/s, done.22Resolving deltas: 100% (41971/41971), done.24 * [new ref] refs/pipelines/576349587 -> refs/pipelines/57634958725Checking out ab4209a5 as refs/merge-requests/91088/merge...26Skipping Git submodules setup27$ git remote set-url origin "${CI_REPOSITORY_URL}"29Checking cache for ruby-gems-debian-bullseye-ruby-2.7-10...30Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bullseye-ruby-2.7-10 31Successfully extracted cache32Checking cache for node-modules-bullseye-test-10...33Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-10 34Successfully extracted cache36Using docker image sha256:1c23a0bd0711f9f7944305c4b25ce8e4301c16167671a7873aad77579270806d for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12@sha256:d0052322332df372b949caf19e910c0ce6859c1e7ed29ff609ebec91b1dead87 ...37$ source scripts/utils.sh38$ bundle_install_script "--with danger"393.2.3340Bundler version 2.2.3341Successfully installed bundler-2.3.15421 gem installed43production:development44Settings are listed in order of priority. The top value will be used.45clean46Set for your local app (/builds/gitlab-org/gitlab/.bundle/config): true47frozen48Set via BUNDLE_FROZEN: true49install_flags50Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"51path52Set for your local app (/builds/gitlab-org/gitlab/.bundle/config): "/builds/gitlab-org/gitlab/vendor"53without54Set via BUNDLE_WITHOUT: [:production, :development]55$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check56[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local with 'danger'`, and stop using this flag57Don't run Bundler as root. Bundler can ask for sudo if it is needed, and58installing your bundle as root will break this application for all non-root59users on this machine.60The Gemfile's dependencies are satisfied61==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 1 seconds.62$ bundle pristine pg63Installing pg 1.3.5 with native extensions64==> 'bundle pristine pg' succeeded in 8 seconds.65$ run_timed_command "retry yarn install --frozen-lockfile"66$ retry yarn install --frozen-lockfile67yarn install v1.22.1768[1/5] Validating package.json...69[2/5] Resolving packages...70success Already up-to-date.71$ node ./scripts/frontend/postinstall.js72success Dependency postinstall check passed.73success Packages successfully patched.74Done in 1.02s.75==> 'retry yarn install --frozen-lockfile' succeeded in 2 seconds.76$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command77$ bundle exec danger --fail-on-errors=true --verbose --danger_id=7feab878/builds/gitlab-org/gitlab/danger/gitaly/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE79/builds/gitlab-org/gitlab/danger/ci_templates/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here80Results:81Warnings:82- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://about.gitlab.com/handbook/engineering/ux/technical-writing/#assignments).83For more information, see:84- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).85- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.86- [ ] You've made some app changes, but didn't add any tests.87That's OK as long as you're refactoring existing code,88but please consider adding any of the ~"maintenance::pipelines", ~"maintenance::workflow", ~"documentation", ~"QA" labels.89Messages:90- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:91If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.92If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.93If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.94Markdown:95**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/2658553632) that generated this comment.**96## Reviewer roulette97Changes that require review have been detected!98Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:99| Category | Reviewer | Maintainer |100| -------- | -------- | ---------- |101| ~backend | [George Koltsov](https://gitlab.com/georgekoltsov) (`@georgekoltsov`) (UTC+1) | [Sincheol (David) Kim](https://gitlab.com/dskim_gitlab) (`@dskim_gitlab`) (UTC+9.5) |102To spread load more evenly across eligible reviewers, Danger has picked a candidate for each103review slot, based on their timezone. Feel free to104[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)105if you think someone else would be better-suited106or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.107To read more on how to use the reviewer roulette, please take a look at the108[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)109and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).110Please consider assigning a reviewer or maintainer who is a111[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.112Once you've decided who will review this merge request, assign them as a reviewer!113Danger does not automatically notify them for you.114==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id=7feab8' succeeded in 6 seconds.116Not uploading cache ruby-gems-debian-bullseye-ruby-2.7-10 due to policy117Not uploading cache node-modules-bullseye-test-10 due to policy119Job succeeded