danger-review
Passed Started
by
@kushalpandya
Kushal Pandya
1Running with gitlab-runner 15.1.0~beta.20.g62206bb2 (62206bb2)2 on blue-2.private.runners-manager.gitlab.com/gitlab.com/gitlab-org QvBVRoXM3 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:d19c30f084fb0f7a53cdb4bf56787499b2a43230be73bb91da79942a3e5b190d for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12@sha256:956c4ddc071a3c94fbf823c6871e057abbd6752ae82c10c383995e7762050540 ...11Running on runner-qvbvroxm-project-278964-concurrent-0 via runner-qvbvroxm-private-1655266988-c8834f25...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 153031, done. 18remote: Counting objects: 100% (153031/153031), done. 19remote: Compressing objects: 100% (107917/107917), done. 20remote: Total 153031 (delta 69528), reused 97445 (delta 39083), pack-reused 0 21Receiving objects: 100% (153031/153031), 146.52 MiB | 29.59 MiB/s, done.22Resolving deltas: 100% (69528/69528), done.24 * [new ref] refs/pipelines/564052815 -> refs/pipelines/56405281525Checking out 6aecd6d7 as refs/merge-requests/88937/merge...26Skipping Git submodules setup27$ git remote set-url origin "${CI_REPOSITORY_URL}"29Checking cache for ruby-gems-bullseye-10...30Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-bullseye-10 31Successfully extracted cache32Checking cache for node-modules-bullseye-test-10...33Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-10 34Successfully extracted cache36Using docker image sha256:d19c30f084fb0f7a53cdb4bf56787499b2a43230be73bb91da79942a3e5b190d for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12:git-2.36-lfs-2.9-chrome-101-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.17-node-16.14-postgresql-12@sha256:956c4ddc071a3c94fbf823c6871e057abbd6752ae82c10c383995e7762050540 ...37$ source scripts/utils.sh38$ bundle_install_script "--with danger"39Successfully installed bundler-2.3.15401 gem installed41Bundler version 2.3.1542production:development43Settings are listed in order of priority. The top value will be used.44clean45Set for your local app (/builds/gitlab-org/gitlab/.bundle/config): true46frozen47Set via BUNDLE_FROZEN: true48install_flags49Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"50path51Set for your local app (/builds/gitlab-org/gitlab/.bundle/config): "/builds/gitlab-org/gitlab/vendor"52without53Set via BUNDLE_WITHOUT: [:production, :development]54$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check55[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local with 'danger'`, and stop using this flag56Don't run Bundler as root. Bundler can ask for sudo if it is needed, and57installing your bundle as root will break this application for all non-root58users on this machine.59The Gemfile's dependencies are satisfied60==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 2 seconds.61$ bundle pristine pg62Installing pg 1.3.5 with native extensions63==> 'bundle pristine pg' succeeded in 7 seconds.64$ run_timed_command "retry yarn install --frozen-lockfile"65$ retry yarn install --frozen-lockfile66yarn install v1.22.1767[1/5] Validating package.json...68[2/5] Resolving packages...69success Already up-to-date.70$ node ./scripts/frontend/postinstall.js71success Dependency postinstall check passed.72success Packages successfully patched.73Done in 0.97s.74==> 'retry yarn install --frozen-lockfile' succeeded in 1 seconds.75$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command76$ bundle exec danger --fail-on-errors=true --verbose --danger_id=7feab877/builds/gitlab-org/gitlab/danger/gitaly/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE78/builds/gitlab-org/gitlab/danger/ci_templates/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here79Results:80Warnings:81- [ ] This merge request is quite big (607 lines changed), please consider splitting it into multiple merge requests.82- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://about.gitlab.com/handbook/engineering/ux/technical-writing/#assignments).83For more information, see:84- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).85- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.86Messages:87- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:88If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.89If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.90If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.91Markdown:92**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/2591766455) that generated this comment.**93## Reviewer roulette94Changes that require review have been detected!95Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:96| Category | Reviewer | Maintainer |97| -------- | -------- | ---------- |98| ~backend | [George Koltsov](https://gitlab.com/georgekoltsov) (`@georgekoltsov`) (UTC+1, same timezone as `@iamphill`) | [Sean Arnold](https://gitlab.com/seanarnold) (`@seanarnold`) (UTC+12, 11 hours ahead of `@iamphill`) |99| ~frontend | [Mireya Andres](https://gitlab.com/mgandres) (`@mgandres`) (UTC+8, 7 hours ahead of `@iamphill`) | [Michael Lunøe](https://gitlab.com/mlunoe) (`@mlunoe`) (UTC+2, 1 hour ahead of `@iamphill`) |100| ~test ~Quality for `spec/features/*` | [John McDonnell](https://gitlab.com/john.mcdonnell) (`@john.mcdonnell`) (UTC+12, 11 hours ahead of `@iamphill`) | Maintainer review is optional for ~test ~Quality for `spec/features/*` |101To spread load more evenly across eligible reviewers, Danger has picked a candidate for each102review slot, based on their timezone. Feel free to103[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)104if you think someone else would be better-suited105or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.106To read more on how to use the reviewer roulette, please take a look at the107[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)108and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).109Please consider assigning a reviewer or maintainer who is a110[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.111Once you've decided who will review this merge request, assign them as a reviewer!112Danger does not automatically notify them for you.113==> 'bundle exec danger --fail-on-errors=true --verbose --danger_id=7feab8' succeeded in 9 seconds.115Not uploading cache ruby-gems-bullseye-10 due to policy116Not uploading cache node-modules-bullseye-test-10 due to policy118Job succeeded