danger-review
Passed Started
by
@peterhegman
Peter Hegman
1Running with gitlab-runner 14.8.0~beta.44.g57df0d52 (57df0d52)2 on green-1.private.runners-manager.gitlab.com/gitlab.com/gitlab-org 4bq1s9yM3 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:debian-bullseye-ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-97-node-16.14-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:debian-bullseye-ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-97-node-16.14-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...9Using docker image sha256:05ef9d4530defd286a1afb1c11aa54387d674a2b01197ea21cb1e90be04384bf for registry.gitlab.com/gitlab-org/gitlab-build-images:debian-bullseye-ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-97-node-16.14-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:6a51c0d95cda96bf7eb8b8fcc2390ee8267ad187f6728fbc74a650836638ac1e ...11Running on runner-4bq1s9ym-project-278964-concurrent-0 via runner-4bq1s9ym-private-1647443229-7f34771a...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 126113, done. 18remote: Counting objects: 100% (126113/126113), done. 19remote: Compressing objects: 100% (87616/87616), done. 20remote: Total 126113 (delta 54658), reused 84328 (delta 33485), pack-reused 0 21Receiving objects: 100% (126113/126113), 120.87 MiB | 31.35 MiB/s, done.22Resolving deltas: 100% (54658/54658), done.24 * [new ref] refs/pipelines/493851578 -> refs/pipelines/49385157825Checking out 2deaa99b as refs/merge-requests/76050/merge...26Skipping Git submodules setup28Checking cache for ruby-gems-bullseye-9...29cache.zip is up to date 30Successfully extracted cache31Checking cache for node-modules-bullseye-test-9...32Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-9 33Successfully extracted cache35Using docker image sha256:05ef9d4530defd286a1afb1c11aa54387d674a2b01197ea21cb1e90be04384bf for registry.gitlab.com/gitlab-org/gitlab-build-images:debian-bullseye-ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-97-node-16.14-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:6a51c0d95cda96bf7eb8b8fcc2390ee8267ad187f6728fbc74a650836638ac1e ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"38Successfully installed bundler-2.3.6391 gem installed40Bundler version 2.3.641production:development42Settings are listed in order of priority. The top value will be used.43clean44Set for the current user (/root/.bundle/config): true45install_flags46Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"47path48Set for the current user (/root/.bundle/config): "/builds/gitlab-org/gitlab/vendor"49without50Set via BUNDLE_WITHOUT: [:production, :development]51$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check52[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local with 'danger'`, and stop using this flag53Don't run Bundler as root. Bundler can ask for sudo if it is needed, and54installing your bundle as root will break this application for all non-root55users on this machine.56The Gemfile's dependencies are satisfied57==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 5 seconds.58$ bundle pristine pg59Installing pg 1.2.3 with native extensions60==> 'bundle pristine pg' succeeded in 11 seconds.61$ run_timed_command "retry yarn install --frozen-lockfile"62$ retry yarn install --frozen-lockfile63yarn install v1.22.1764[1/5] Validating package.json...65[2/5] Resolving packages...66success Already up-to-date.67$ node ./scripts/frontend/postinstall.js68success Dependency postinstall check passed.69Done in 1.00s.70==> 'retry yarn install --frozen-lockfile' succeeded in 2 seconds.71$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command72$ bundle exec danger --fail-on-errors=true --verbose73danger/ci_templates/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE74danger/gitaly/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here75Results:76Warnings:77- [ ] b729ad4abab291f6b5e10b555f8ec1f930f6cbb7: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).78- [ ] This merge request changed files with disabled eslint rules. Please consider fixing them.79- [ ] This merge request changed undocumented Vue components in `vue_shared/`. Please consider [creating Stories](https://docs.gitlab.com/ce/development/fe_guide/storybook) for these components:80- `app/assets/javascripts/vue_shared/components/user_popover/user_popover.vue`81Messages:82- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.83Markdown:84**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/2211764212) that generated this comment.**85## Documentation review86The following files require a review from a technical writer:87* `doc/api/users.md`88The review does not need to block merging this merge request. See the:89- [Metadata for the `*.md` files](https://docs.gitlab.com/ee/development/documentation/#metadata) that you've changed. The first few lines of each `*.md` file identify the stage and group most closely associated with your docs change.90- The [Technical Writer assigned](https://about.gitlab.com/handbook/engineering/technical-writing/#assignments) for that stage and group.91- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.92## Disabled eslint rules93The following files have disabled `eslint` rules. Please consider fixing them:94* `app/assets/javascripts/user_popovers.js`95Run the following command for more details96```97node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \98 'app/assets/javascripts/user_popovers.js'99```100## Reviewer roulette101Changes that require review have been detected!102Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:103| Category | Reviewer | Maintainer |104| -------- | -------- | ---------- |105| ~backend | [Eugie Limpin](https://gitlab.com/eugielimpin) (`@eugielimpin`) (UTC+8) | [Stan Hu](https://gitlab.com/stanhu) (`@stanhu`) (UTC-7) |106| ~frontend | [Mireya Andres](https://gitlab.com/mgandres) (`@mgandres`) (UTC+8) | [Kushal Pandya](https://gitlab.com/kushalpandya) (`@kushalpandya`) (UTC+5.5) |107| ~UX | [Veethika Mishra](https://gitlab.com/v_mishra) (`@v_mishra`) (UTC+0) | No maintainer available |108To spread load more evenly across eligible reviewers, Danger has picked a candidate for each109review slot, based on their timezone. Feel free to110[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)111if you think someone else would be better-suited112or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.113To read more on how to use the reviewer roulette, please take a look at the114[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)115and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).116Please consider assigning a reviewer or maintainer who is a117[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.118Once you've decided who will review this merge request, assign them as a reviewer!119Danger does not automatically notify them for you.120==> 'bundle exec danger --fail-on-errors=true --verbose' succeeded in 19 seconds.122Not uploading cache ruby-gems-bullseye-9 due to policy123Not uploading cache node-modules-bullseye-test-9 due to policy125Job succeeded