danger-review
Passed Started
by
@ashmckenzie

Ash McKenzie
1Running with gitlab-runner 14.8.0~beta.44.g57df0d52 (57df0d52)2 on green-1.private.runners-manager.gitlab.com/gitlab.com/gitlab-org 4bq1s9yM3 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...9Using docker image sha256:52fb185b5552937725d9638c3d47ccfd253e528f86a7395d8a7b2243fc45dd68 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:631e02e53df1292a37a2d46b80023e5d33ef20c2c1487c0737fe0a39a8c0cbef ...11Running on runner-4bq1s9ym-project-278964-concurrent-0 via runner-4bq1s9ym-private-1646375970-7b8f6623...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 97999, done. 18remote: Counting objects: 100% (97999/97999), done. 19remote: Compressing objects: 100% (69865/69865), done. 20remote: Total 97999 (delta 37145), reused 63224 (delta 24513), pack-reused 0 21Receiving objects: 100% (97999/97999), 108.27 MiB | 28.73 MiB/s, done.22Resolving deltas: 100% (37145/37145), done.24 * [new ref] 4f23162ca6751f465ba10d1d47d41aa04dbfd4b6 -> refs/pipelines/39964763625Checking out 4f23162c as refs/merge-requests/73297/merge...26Skipping Git submodules setup28Checking cache for ruby-gems-v1-9...29FATAL: file does not exist 30Failed to extract cache31Checking cache for node-modules-test-v1-9...32FATAL: file does not exist 33Failed to extract cache35Using docker image sha256:52fb185b5552937725d9638c3d47ccfd253e528f86a7395d8a7b2243fc45dd68 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:631e02e53df1292a37a2d46b80023e5d33ef20c2c1487c0737fe0a39a8c0cbef ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"38Bundler version 2.1.439production:development40Settings are listed in order of priority. The top value will be used.41path42Set for the current user (/root/.bundle/config): "/builds/gitlab-org/gitlab/vendor"43clean44Set for the current user (/root/.bundle/config): "true"45without46Set via BUNDLE_WITHOUT: [:production, :development]47install_flags48Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"49$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check50[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set with 'danger'`, and stop using this flag51The Gemfile's dependencies are satisfied52==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 409 seconds.53$ bundle pristine pg54Installing pg 1.2.3 with native extensions55==> 'bundle pristine pg' succeeded in 10 seconds.56$ run_timed_command "retry yarn install --frozen-lockfile"57$ retry yarn install --frozen-lockfile58yarn install v1.22.1059[1/5] Validating package.json...60[2/5] Resolving packages...61[3/5] Fetching packages...62info fsevents@2.1.3: The platform "linux" is incompatible with this module.63info "fsevents@2.1.3" is an optional dependency and failed compatibility check. Excluding it from installation.64[4/5] Linking dependencies...65warning "@gitlab/eslint-plugin > eslint-plugin-jest > @typescript-eslint/experimental-utils > @typescript-eslint/typescript-estree > tsutils@3.17.1" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".66warning " > eslint-import-resolver-jest@3.0.2" has unmet peer dependency "eslint-plugin-import@>=1.4.0".67warning " > eslint-import-resolver-webpack@0.13.1" has unmet peer dependency "eslint-plugin-import@>=1.4.0".68[5/5] Building fresh packages...69$ node ./scripts/frontend/postinstall.js70success Dependency postinstall check passed.71Done in 66.95s.72==> 'retry yarn install --frozen-lockfile' succeeded in 67 seconds.73$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command74$ bundle exec danger --fail-on-errors=true --verbose75danger/ci_templates/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE76danger/gitaly/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here77Results:78Warnings:79- [ ] Please add a [merge request type](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification) to this merge request.80Messages:81- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:82If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.83If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.84If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.85Markdown:86## Reviewer roulette87Changes that require review have been detected!88Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:89| Category | Reviewer | Maintainer |90| -------- | -------- | ---------- |91| ~QA | [Will Meek](https://gitlab.com/willmeek) (`@willmeek`) (UTC+0, 5 hours ahead of `@zeffmorgan`) | [Ramya Authappan](https://gitlab.com/at.ramya) (`@at.ramya`) (UTC+5.5, 10.5 hours ahead of `@zeffmorgan`) |92To spread load more evenly across eligible reviewers, Danger has picked a candidate for each93review slot, based on their timezone. Feel free to94[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)95if you think someone else would be better-suited96or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.97To read more on how to use the reviewer roulette, please take a look at the98[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)99and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).100Please consider assigning a reviewer or maintainer who is a101[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.102Once you've decided who will review this merge request, assign them as a reviewer!103Danger does not automatically notify them for you.104**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/2162485479) that generated this comment.**105==> 'bundle exec danger --fail-on-errors=true --verbose' succeeded in 9 seconds.107Not uploading cache ruby-gems-v1-9 due to policy108Not uploading cache node-modules-test-v1-9 due to policy110Job succeeded