danger-review
Passed Started
by
@acunskis

Andrejs Cunskis
1Running with gitlab-runner 14.7.0~beta.58.gfa48f33b (fa48f33b)2 on blue-4.shared-gitlab-org.runners-manager.gitlab.com/default 8cwZ3F433 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...9Using docker image sha256:52fb185b5552937725d9638c3d47ccfd253e528f86a7395d8a7b2243fc45dd68 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:631e02e53df1292a37a2d46b80023e5d33ef20c2c1487c0737fe0a39a8c0cbef ...11Running on runner-8cwz3f43-project-278964-concurrent-0 via runner-8cwz3f43-shared-gitlab-org-1644321264-182e115a...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 113281, done. 18remote: Counting objects: 100% (113281/113281), done. 19remote: Compressing objects: 100% (77969/77969), done. 20remote: Total 113281 (delta 48687), reused 75721 (delta 30762), pack-reused 0 21Receiving objects: 100% (113281/113281), 112.24 MiB | 29.35 MiB/s, done.22Resolving deltas: 100% (48687/48687), done.24 * [new ref] 3903facd991cfd5946bb89f5a0e691b52b2d06c6 -> refs/pipelines/46600899625Checking out 3903facd as refs/merge-requests/77977/merge...26Skipping Git submodules setup28Checking cache for ruby-gems-v1-9...29Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-v1-9 30Successfully extracted cache31Checking cache for node-modules-test-v1-9...32Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-test-v1-9 33Successfully extracted cache35Using docker image sha256:52fb185b5552937725d9638c3d47ccfd253e528f86a7395d8a7b2243fc45dd68 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:631e02e53df1292a37a2d46b80023e5d33ef20c2c1487c0737fe0a39a8c0cbef ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"38Successfully installed bundler-2.3.6391 gem installed40Bundler version 2.3.641production:development42Settings are listed in order of priority. The top value will be used.43clean44Set for the current user (/root/.bundle/config): true45install_flags46Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"47path48Set for the current user (/root/.bundle/config): "/builds/gitlab-org/gitlab/vendor"49without50Set via BUNDLE_WITHOUT: [:production, :development]51$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check52[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local with 'danger'`, and stop using this flag53Don't run Bundler as root. Bundler can ask for sudo if it is needed, and54installing your bundle as root will break this application for all non-root55users on this machine.56The Gemfile's dependencies are satisfied57==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 6 seconds.58$ bundle pristine pg59Installing pg 1.2.3 with native extensions60==> 'bundle pristine pg' succeeded in 11 seconds.61$ run_timed_command "retry yarn install --frozen-lockfile"62$ retry yarn install --frozen-lockfile63yarn install v1.22.1064[1/5] Validating package.json...65[2/5] Resolving packages...66success Already up-to-date.67$ node ./scripts/frontend/postinstall.js68success Dependency postinstall check passed.69Done in 1.08s.70==> 'retry yarn install --frozen-lockfile' succeeded in 2 seconds.71$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command72$ bundle exec danger --fail-on-errors=true --verbose73danger/ci_templates/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE74danger/gitaly/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here75Results:76Warnings:77- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://about.gitlab.com/handbook/engineering/ux/technical-writing/#designated-technical-writers).78For more information, see:79- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).80- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.81Messages:82- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:83If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.84If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.85If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.86Markdown:87## Reviewer roulette88Changes that require review have been detected!89Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:90| Category | Reviewer | Maintainer |91| -------- | -------- | ---------- |92| ~QA | [Tomislav Nikić](https://gitlab.com/tomi) (`@tomi`) (UTC+1, 6 hours ahead of `@zeffmorgan`) | [Dan Davison](https://gitlab.com/ddavison) (`@ddavison`) (UTC-5, same timezone as `@zeffmorgan`) |93To spread load more evenly across eligible reviewers, Danger has picked a candidate for each94review slot, based on their timezone. Feel free to95[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)96if you think someone else would be better-suited97or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.98To read more on how to use the reviewer roulette, please take a look at the99[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)100and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).101Please consider assigning a reviewer or maintainer who is a102[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.103Once you've decided who will review this merge request, assign them as a reviewer!104Danger does not automatically notify them for you.105**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/2067172433) that generated this comment.**106==> 'bundle exec danger --fail-on-errors=true --verbose' succeeded in 10 seconds.108Not uploading cache ruby-gems-v1-9 due to policy109Not uploading cache node-modules-test-v1-9 due to policy111Job succeeded