danger-review
Passed Started
by
@afontaine

Andrew Fontaine
1Running with gitlab-runner 14.7.0~beta.58.gfa48f33b (fa48f33b)2 on green-1.private.runners-manager.gitlab.com/gitlab.com/gitlab-org 4bq1s9yM3 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...9Using docker image sha256:52fb185b5552937725d9638c3d47ccfd253e528f86a7395d8a7b2243fc45dd68 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:631e02e53df1292a37a2d46b80023e5d33ef20c2c1487c0737fe0a39a8c0cbef ...11Running on runner-4bq1s9ym-project-278964-concurrent-0 via runner-4bq1s9ym-private-1644256005-93e59896...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/16Created fresh repository.17remote: Enumerating objects: 112286, done. 18remote: Counting objects: 100% (112286/112286), done. 19remote: Compressing objects: 100% (77373/77373), done. 20remote: Total 112286 (delta 47954), reused 75114 (delta 30389), pack-reused 0 21Receiving objects: 100% (112286/112286), 111.97 MiB | 30.66 MiB/s, done.22Resolving deltas: 100% (47954/47954), done.24 * [new ref] 0556f1c5d6b071368a3010bf5d005cd71fa7e253 -> refs/pipelines/46543095825Checking out 0556f1c5 as refs/merge-requests/79873/merge...26Skipping Git submodules setup28Checking cache for ruby-gems-v1-9...29cache.zip is up to date 30Successfully extracted cache31Checking cache for node-modules-test-v1-9...32Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-test-v1-9 33Successfully extracted cache35Using docker image sha256:52fb185b5552937725d9638c3d47ccfd253e528f86a7395d8a7b2243fc45dd68 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:631e02e53df1292a37a2d46b80023e5d33ef20c2c1487c0737fe0a39a8c0cbef ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"38Successfully installed bundler-2.3.6391 gem installed40Bundler version 2.3.641production:development42Settings are listed in order of priority. The top value will be used.43clean44Set for the current user (/root/.bundle/config): true45install_flags46Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"47path48Set for the current user (/root/.bundle/config): "/builds/gitlab-org/gitlab/vendor"49without50Set via BUNDLE_WITHOUT: [:production, :development]51$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check52[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local with 'danger'`, and stop using this flag53Don't run Bundler as root. Bundler can ask for sudo if it is needed, and54installing your bundle as root will break this application for all non-root55users on this machine.56The Gemfile's dependencies are satisfied57==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 6 seconds.58$ bundle pristine pg59Installing pg 1.2.3 with native extensions60==> 'bundle pristine pg' succeeded in 11 seconds.61$ run_timed_command "retry yarn install --frozen-lockfile"62$ retry yarn install --frozen-lockfile63yarn install v1.22.1064[1/5] Validating package.json...65[2/5] Resolving packages...66success Already up-to-date.67$ node ./scripts/frontend/postinstall.js68success Dependency postinstall check passed.69Done in 1.08s.70==> 'retry yarn install --frozen-lockfile' succeeded in 1 seconds.71$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command72$ bundle exec danger --fail-on-errors=true --verbose73danger/ci_templates/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE74danger/gitaly/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here75Results:76Warnings:77- [ ] 67932c4721bd723fd90004c8c12907f2cd0f45d1: The commit subject must contain at least 3 words. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).78Messages:79- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.80Markdown:81## Documentation review82The following files require a review from a technical writer:83* `doc/user/project/working_with_projects.md`84The review does not need to block merging this merge request. See the:85- [Metadata for the `*.md` files](https://docs.gitlab.com/ee/development/documentation/#metadata) that you've changed. The first few lines of each `*.md` file identify the stage and group most closely associated with your docs change.86- The [Technical Writer assigned](https://about.gitlab.com/handbook/engineering/technical-writing/#designated-technical-writers) for that stage and group.87- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.88## Reviewer roulette89Changes that require review have been detected!90Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:91| Category | Reviewer | Maintainer |92| -------- | -------- | ---------- |93| ~frontend | [Diana Zubova](https://gitlab.com/dzubova) (`@dzubova`) (UTC+1, 1 hour behind `@anna_vovchenko`) | [Natalia Tepluhina](https://gitlab.com/ntepluhina) (`@ntepluhina`) (UTC+1, 1 hour behind `@anna_vovchenko`) |94| ~"product intelligence" | [Luis Mejia](https://gitlab.com/lmejia2) (`@lmejia2`) (UTC-6, 8 hours behind `@anna_vovchenko`) | Maintainer review is optional for ~"product intelligence" |95To spread load more evenly across eligible reviewers, Danger has picked a candidate for each96review slot, based on their timezone. Feel free to97[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)98if you think someone else would be better-suited99or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.100To read more on how to use the reviewer roulette, please take a look at the101[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)102and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).103Please consider assigning a reviewer or maintainer who is a104[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.105Once you've decided who will review this merge request, assign them as a reviewer!106Danger does not automatically notify them for you.107**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/2064319944) that generated this comment.**108==> 'bundle exec danger --fail-on-errors=true --verbose' succeeded in 13 seconds.110Not uploading cache ruby-gems-v1-9 due to policy111Not uploading cache node-modules-test-v1-9 due to policy113Job succeeded