Skip to content
Snippets Groups Projects

danger-review

Passed Started by
Steve Abrams
@sabrams
1Running with gitlab-runner 14.6.0~beta.71.gf035ecbf (f035ecbf)
2 on green-2.private.runners-manager.gitlab.com/gitlab.com/gitlab-org GaSD-S1F
3 feature flags: FF_USE_FASTZIP:true
4 Resolving secrets 00:00
5 Preparing the "docker+machine" executor 00:03
6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...
7Authenticating with credentials from job payload (GitLab Registry)
8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...
9Using docker image sha256:9dce08d8ac50abdf26771114efb29dba31dac619559dc1f933882a5c055f8216 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:700ef78254e4423bd9e4800a5df749541da60388a7712ad3a7b5afdf1ea0be15 ...
10 Preparing environment 00:01
11Running on runner-gasd-s1f-project-278964-concurrent-0 via runner-gasd-s1f-private-1640293271-bec4a241...
12 Getting source from Git repository 00:25
13$ eval "$CI_PRE_CLONE_SCRIPT"
14Fetching changes with git depth set to 20...
15Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/
16Created fresh repository.
17remote: Enumerating objects: 113433, done.
18remote: Counting objects: 100% (113433/113433), done.
19remote: Compressing objects: 100% (79420/79420), done.
20remote: Total 113433 (delta 46669), reused 77078 (delta 29529), pack-reused 0
21Receiving objects: 100% (113433/113433), 115.48 MiB | 30.54 MiB/s, done.
22Resolving deltas: 100% (46669/46669), done.
23From https://gitlab.com/gitlab-org/gitlab
24 * [new ref] cba78f7d9e0832763d484f10ba82fb0cd0ad84cf -> refs/pipelines/436143743
25Checking out cba78f7d as refs/merge-requests/76983/merge...
26Skipping Git submodules setup
27 Restoring cache 00:33
28Checking cache for ruby-gems-v1-9...
29cache.zip is up to date
30Successfully extracted cache
31Checking cache for node-modules-test-v1-9...
32Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-test-v1-9
33Successfully extracted cache
34 Executing "step_script" stage of the job script 00:25
35Using docker image sha256:9dce08d8ac50abdf26771114efb29dba31dac619559dc1f933882a5c055f8216 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:700ef78254e4423bd9e4800a5df749541da60388a7712ad3a7b5afdf1ea0be15 ...
36$ source scripts/utils.sh
37$ bundle_install_script "--with danger"
38Bundler version 2.1.4
39production:development
40Settings are listed in order of priority. The top value will be used.
41path
42Set for the current user (/root/.bundle/config): "/builds/gitlab-org/gitlab/vendor"
43clean
44Set for the current user (/root/.bundle/config): "true"
45without
46Set via BUNDLE_WITHOUT: [:production, :development]
47install_flags
48Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"
49$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check
50[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set with 'danger'`, and stop using this flag
51The Gemfile's dependencies are satisfied
52==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 2 seconds.
53$ bundle pristine pg
54Installing pg 1.2.3 with native extensions
55==> 'bundle pristine pg' succeeded in 10 seconds.
56$ run_timed_command "retry yarn install --frozen-lockfile"
57$ retry yarn install --frozen-lockfile
58yarn install v1.22.10
59[1/5] Validating package.json...
60[2/5] Resolving packages...
61success Already up-to-date.
62$ node ./scripts/frontend/postinstall.js
63success Dependency postinstall check passed.
64Done in 1.26s.
65==> 'retry yarn install --frozen-lockfile' succeeded in 3 seconds.
66$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command
67$ bundle exec danger --fail-on-errors=true --verbose
68danger/ci_templates/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE
69danger/gitaly/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here
70Results:
71Markdown:
72## Reviewer roulette
73Changes that require review have been detected!
74Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
75| Category | Reviewer | Maintainer |
76| -------- | -------- | ---------- |
77| ~backend | [Ross Fuhrman](https://gitlab.com/rossfuhrman) (`@rossfuhrman`) (UTC-6) | [Tetiana Chupryna](https://gitlab.com/brytannia) (`@brytannia`) (UTC+2) |
78| ~database | [Nikola Milojevic](https://gitlab.com/nmilojevic1) (`@nmilojevic1`) (UTC+1) | [Steve Abrams](https://gitlab.com/sabrams) (`@sabrams`) (UTC-7) |
79| ~migration | No reviewer available | No maintainer available |
80To spread load more evenly across eligible reviewers, Danger has picked a candidate for each
81review slot, based on their timezone. Feel free to
82[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)
83if you think someone else would be better-suited
84or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.
85To read more on how to use the reviewer roulette, please take a look at the
86[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)
87and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).
88Please consider assigning a reviewer or maintainer who is a
89[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.
90Once you've decided who will review this merge request, assign them as a reviewer!
91Danger does not automatically notify them for you.
92**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/1917583870) that generated this comment.**
93==> 'bundle exec danger --fail-on-errors=true --verbose' succeeded in 8 seconds.
94 Saving cache for successful job 00:01
95Not uploading cache ruby-gems-v1-9 due to policy
96Not uploading cache node-modules-test-v1-9 due to policy
97 Cleaning up project directory and file based variables 00:00
98Job succeeded