danger-review
Passed Started
by
@gitlab-bot
🤖 GitLab Bot 🤖
1Running with gitlab-runner 14.3.0-rc1 (ed15bfbf)2 on docker-auto-scale-com 8a6210b83 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...9Using docker image sha256:5ba30b2efcbe583314cc76f63951dc9434780296f6f0c0927d24b4ce4fb73622 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:c4091382b5a12b75ca112f017f8cecffed2cf1a087968e3a03143d55ec67d3bf ...11Running on runner-8a6210b8-project-278964-concurrent-0 via runner-8a6210b8-gsrm-1633964904-cb7304d1...13$ eval "$CI_PRE_CLONE_SCRIPT"14Downloading archived master...15Connecting to storage.googleapis.com (172.217.193.128:443)16saving to '/tmp/gitlab.tar.gz'17gitlab.tar.gz 19% |****** | 67.9M 0:00:04 ETA18gitlab.tar.gz 81% |************************* | 280M 0:00:00 ETA19gitlab.tar.gz 100% |********************************| 346M 0:00:00 ETA20'/tmp/gitlab.tar.gz' saved21Extracting tarball into /builds/gitlab-org/gitlab...22Fetching changes with git depth set to 20...23Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/24Created fresh repository.25remote: Enumerating objects: 81, done. 26remote: Counting objects: 100% (41/41), done. 27remote: Compressing objects: 100% (7/7), done. 28remote: Total 9 (delta 7), reused 4 (delta 2), pack-reused 0 30 * [new ref] 37723ac46e66416d1a7cb3e661d51f5525ba3d8b -> refs/pipelines/38628708131Checking out 37723ac4 as refs/merge-requests/72120/head...32Skipping Git submodules setup34Checking cache for ruby-gems-v1-4...35Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-v1-4 36Successfully extracted cache37Checking cache for node-modules-test-v1-4...38Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-test-v1-4 39Successfully extracted cache41Using docker image sha256:5ba30b2efcbe583314cc76f63951dc9434780296f6f0c0927d24b4ce4fb73622 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:c4091382b5a12b75ca112f017f8cecffed2cf1a087968e3a03143d55ec67d3bf ...42$ source scripts/utils.sh43$ bundle_install_script "--with danger"44Bundler version 2.1.445production:development46Settings are listed in order of priority. The top value will be used.47path48Set for the current user (/root/.bundle/config): "/builds/gitlab-org/gitlab/vendor"49clean50Set for the current user (/root/.bundle/config): "true"51without52Set via BUNDLE_WITHOUT: [:production, :development]53install_flags54Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"55$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check56[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set with 'danger'`, and stop using this flag57The Gemfile's dependencies are satisfied58==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 2 seconds.59$ bundle pristine pg60Installing pg 1.2.3 with native extensions61==> 'bundle pristine pg' succeeded in 9 seconds.62$ run_timed_command "retry yarn install --frozen-lockfile"63$ retry yarn install --frozen-lockfile64yarn install v1.22.1065[1/5] Validating package.json...66[2/5] Resolving packages...67success Already up-to-date.68$ node ./scripts/frontend/postinstall.js69success Dependency postinstall check passed.70Done in 1.08s.71==> 'retry yarn install --frozen-lockfile' succeeded in 1 seconds.72$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command73$ bundle exec danger --fail-on-errors=true --verbose74danger/ci_templates/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE75danger/gitaly/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here76Results:77Warnings:78- [ ] You've made some app changes, but didn't add any tests.79That's OK as long as you're refactoring existing code,80but please consider adding any of the ~"tooling", ~"tooling::pipelines", ~"tooling::workflow", ~"documentation", ~"QA" labels.81Markdown:82config/feature_flags/development/use_upsert_query_for_mr_metrics.yml#L883You're about to [release the feature with the feature flag](https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/issue_templates/Feature%20Flag%20Roll%20Out.md#optional-release-the-feature-with-the-feature-flag).84This process can only be done **after** the [global rollout on production](https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/issue_templates/Feature%20Flag%20Roll%20Out.md#global-rollout-on-production).85Please make sure in [the rollout issue](https://gitlab.com/gitlab-org/gitlab/-/issues/339677) that the preliminary steps have already been done. Otherwise, changing the YAML definition might not have the desired effect.86## Reviewer roulette87Changes that require review have been detected!88Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:89| Category | Reviewer | Maintainer |90| -------- | -------- | ---------- |91| ~backend | [Alex Buijs](https://gitlab.com/alexbuijs) (`@alexbuijs`) (UTC+2, same timezone as `@ahegyi`) | [Bob Van Landuyt](https://gitlab.com/reprazent) (`@reprazent`) (UTC+2, same timezone as `@ahegyi`) |92To spread load more evenly across eligible reviewers, Danger has picked a candidate for each93review slot, based on their timezone. Feel free to94[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)95if you think someone else would be better-suited96or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.97To read more on how to use the reviewer roulette, please take a look at the98[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)99and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).100Please consider assigning a reviewer or maintainer who is a101[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.102Once you've decided who will review this merge request, assign them as a reviewer!103Danger does not automatically notify them for you.104**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/1668810536) that generated this comment.**105==> 'bundle exec danger --fail-on-errors=true --verbose' succeeded in 6 seconds.107Not uploading cache ruby-gems-v1-4 due to policy108Not uploading cache node-modules-test-v1-4 due to policy110Job succeeded