Skip to content
Snippets Groups Projects

danger-review

Passed Started by
Jose Ivan Vargas
@jivanvl
1Running with gitlab-runner 14.3.0-rc1 (ed15bfbf)
2 on green-1.private.runners-manager.gitlab.com/gitlab.com/gitlab-org 4bq1s9yM
3 feature flags: FF_USE_FASTZIP:true
4 Resolving secrets 00:00
5 Preparing the "docker+machine" executor 00:35
6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...
7Authenticating with credentials from job payload (GitLab Registry)
8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...
9Using docker image sha256:5ba30b2efcbe583314cc76f63951dc9434780296f6f0c0927d24b4ce4fb73622 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:c4091382b5a12b75ca112f017f8cecffed2cf1a087968e3a03143d55ec67d3bf ...
10 Preparing environment 00:06
11Running on runner-4bq1s9ym-project-278964-concurrent-0 via runner-4bq1s9ym-private-1633705519-123dc07c...
12 Getting source from Git repository 00:42
13$ eval "$CI_PRE_CLONE_SCRIPT"
14Downloading archived master...
15Connecting to storage.googleapis.com (172.217.193.128:443)
16saving to '/tmp/gitlab.tar.gz'
17gitlab.tar.gz 20% |****** | 71.0M 0:00:03 ETA
18gitlab.tar.gz 96% |****************************** | 334M 0:00:00 ETA
19gitlab.tar.gz 100% |********************************| 346M 0:00:00 ETA
20'/tmp/gitlab.tar.gz' saved
21Extracting tarball into /builds/gitlab-org/gitlab...
22Fetching changes with git depth set to 20...
23Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/
24Created fresh repository.
25remote: Enumerating objects: 361, done.
26remote: Counting objects: 100% (286/286), done.
27remote: Compressing objects: 100% (119/119), done.
28remote: Total 136 (delta 76), reused 56 (delta 12), pack-reused 0
29Receiving objects: 100% (136/136), 36.70 KiB | 7.34 MiB/s, done.
30Resolving deltas: 100% (76/76), completed with 62 local objects.
31From https://gitlab.com/gitlab-org/gitlab
32 * [new ref] 84e6d6823fa5f0041cd8e6c83ebcbe049dd8e933 -> refs/pipelines/385184127
33Checking out 84e6d682 as refs/merge-requests/71359/merge...
34Skipping Git submodules setup
35 Restoring cache 00:31
36Checking cache for ruby-gems-v1-4...
37Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-v1-4
38Successfully extracted cache
39Checking cache for node-modules-test-v1-4...
40Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-test-v1-4
41Successfully extracted cache
42 Executing "step_script" stage of the job script 00:25
43Using docker image sha256:5ba30b2efcbe583314cc76f63951dc9434780296f6f0c0927d24b4ce4fb73622 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:c4091382b5a12b75ca112f017f8cecffed2cf1a087968e3a03143d55ec67d3bf ...
44$ source scripts/utils.sh
45$ bundle_install_script "--with danger"
46Bundler version 2.1.4
47production:development
48Settings are listed in order of priority. The top value will be used.
49path
50Set for the current user (/root/.bundle/config): "/builds/gitlab-org/gitlab/vendor"
51clean
52Set for the current user (/root/.bundle/config): "true"
53without
54Set via BUNDLE_WITHOUT: [:production, :development]
55install_flags
56Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"
57$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check
58[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set with 'danger'`, and stop using this flag
59The Gemfile's dependencies are satisfied
60==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 3 seconds.
61$ bundle pristine pg
62Installing pg 1.2.3 with native extensions
63==> 'bundle pristine pg' succeeded in 10 seconds.
64$ run_timed_command "retry yarn install --frozen-lockfile"
65$ retry yarn install --frozen-lockfile
66yarn install v1.22.10
67[1/5] Validating package.json...
68[2/5] Resolving packages...
69success Already up-to-date.
70$ node ./scripts/frontend/postinstall.js
71success Dependency postinstall check passed.
72Done in 1.06s.
73$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command
74==> 'retry yarn install --frozen-lockfile' succeeded in 1 seconds.
75$ bundle exec danger --fail-on-errors=true --verbose
76danger/ci_templates/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE
77danger/gitaly/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here
78Results:
79Messages:
80- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:
81If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.
82If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.
83If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.
84Markdown:
85## Reviewer roulette
86Changes that require review have been detected!
87Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
88| Category | Reviewer | Maintainer |
89| -------- | -------- | ---------- |
90| ~frontend | [Scott Stern](https://gitlab.com/sstern) (`@sstern`) (UTC-7, 18 hours behind `@tigerwnz`) | [Jose Ivan Vargas](https://gitlab.com/jivanvl) (`@jivanvl`) (UTC-5, 16 hours behind `@tigerwnz`) |
91To spread load more evenly across eligible reviewers, Danger has picked a candidate for each
92review slot, based on their timezone. Feel free to
93[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)
94if you think someone else would be better-suited
95or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.
96To read more on how to use the reviewer roulette, please take a look at the
97[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)
98and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).
99Please consider assigning a reviewer or maintainer who is a
100[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.
101Once you've decided who will review this merge request, assign them as a reviewer!
102Danger does not automatically notify them for you.
103**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/1663159970) that generated this comment.**
104==> 'bundle exec danger --fail-on-errors=true --verbose' succeeded in 9 seconds.
105 Saving cache for successful job 00:01
106Not uploading cache ruby-gems-v1-4 due to policy
107Not uploading cache node-modules-test-v1-4 due to policy
108 Cleaning up project directory and file based variables 00:00
109Job succeeded