danger-review
Passed Started
by
@jannik_lehmann
Jannik Lehmann
1Running with gitlab-runner 14.3.0-rc1 (ed15bfbf)2 on docker-auto-scale-com d5ae8d253 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...9Using docker image sha256:5ba30b2efcbe583314cc76f63951dc9434780296f6f0c0927d24b4ce4fb73622 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:c4091382b5a12b75ca112f017f8cecffed2cf1a087968e3a03143d55ec67d3bf ...11Running on runner-d5ae8d25-project-278964-concurrent-0 via runner-d5ae8d25-gsrm-1632944943-ff9625bb...13$ eval "$CI_PRE_CLONE_SCRIPT"14Downloading archived master...15Connecting to storage.googleapis.com (172.217.193.128:443)16saving to '/tmp/gitlab.tar.gz'17gitlab.tar.gz 24% |******* | 84.0M 0:00:03 ETA18gitlab.tar.gz 100% |********************************| 344M 0:00:00 ETA19'/tmp/gitlab.tar.gz' saved20Extracting tarball into /builds/gitlab-org/gitlab...21Fetching changes with git depth set to 20...22Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/23Created fresh repository.24remote: Enumerating objects: 504, done. 25remote: Counting objects: 100% (297/297), done. 26remote: Compressing objects: 100% (137/137), done. 27remote: Total 161 (delta 112), reused 55 (delta 24), pack-reused 0 28Receiving objects: 100% (161/161), 18.59 KiB | 6.20 MiB/s, done.29Resolving deltas: 100% (112/112), completed with 55 local objects.31 * [new ref] ec564e93aecae71f62b0ed076dceb9ea006567fa -> refs/pipelines/37972286632Checking out ec564e93 as refs/merge-requests/70901/merge...33Skipping Git submodules setup35Checking cache for ruby-gems-v1-4...36cache.zip is up to date 37Successfully extracted cache38Checking cache for node-modules-test-v1-4...39cache.zip is up to date 40Successfully extracted cache42Using docker image sha256:5ba30b2efcbe583314cc76f63951dc9434780296f6f0c0927d24b4ce4fb73622 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:c4091382b5a12b75ca112f017f8cecffed2cf1a087968e3a03143d55ec67d3bf ...43$ source scripts/utils.sh44$ bundle_install_script "--with danger"45Bundler version 2.1.446production:development47Settings are listed in order of priority. The top value will be used.48path49Set for the current user (/root/.bundle/config): "/builds/gitlab-org/gitlab/vendor"50clean51Set for the current user (/root/.bundle/config): "true"52without53Set via BUNDLE_WITHOUT: [:production, :development]54install_flags55Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"56$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check57[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set with 'danger'`, and stop using this flag58The Gemfile's dependencies are satisfied59==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 3 seconds.60$ bundle pristine pg61Installing pg 1.2.3 with native extensions62==> 'bundle pristine pg' succeeded in 12 seconds.63$ run_timed_command "retry yarn install --frozen-lockfile"64$ retry yarn install --frozen-lockfile65yarn install v1.22.1066[1/5] Validating package.json...67[2/5] Resolving packages...68success Already up-to-date.69$ node ./scripts/frontend/postinstall.js70success Dependency postinstall check passed.71Done in 1.02s.72==> 'retry yarn install --frozen-lockfile' succeeded in 2 seconds.73$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command74$ bundle exec danger --fail-on-errors=true --verbose75danger/ci_templates/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE76danger/gitaly/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here77Results:78Warnings:79- [ ] The merge request title must contain at least 3 words. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).80- [ ] 6aeb477f3b386dfbf209167718dc1e59cbdba84c: The commit subject must contain at least 3 words. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).81- [ ] This merge request does not refer to an existing milestone.82- [ ] Reviewer roulette failed to load team data: Failed to read https://gitlab-org.gitlab.io/gitlab-roulette/roulette.json: 302 Found83- [ ] You've made some app changes, but didn't add any tests.84That's OK as long as you're refactoring existing code,85but please consider adding any of the ~"tooling", ~"tooling::pipelines", ~"tooling::workflow", ~"documentation", ~"QA" labels.86Messages:87- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:88If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.89If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.90If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.91Markdown:92## Reviewer roulette93Changes that require review have been detected!94Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:95| Category | Reviewer | Maintainer |96| -------- | -------- | ---------- |97| ~frontend | No reviewer available | No maintainer available |98To spread load more evenly across eligible reviewers, Danger has picked a candidate for each99review slot, based on their timezone. Feel free to100[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)101if you think someone else would be better-suited102or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.103To read more on how to use the reviewer roulette, please take a look at the104[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)105and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).106Please consider assigning a reviewer or maintainer who is a107[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.108Once you've decided who will review this merge request, assign them as a reviewer!109Danger does not automatically notify them for you.110**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/1635435396) that generated this comment.**111==> 'bundle exec danger --fail-on-errors=true --verbose' succeeded in 7 seconds.113Not uploading cache ruby-gems-v1-4 due to policy114Not uploading cache node-modules-test-v1-4 due to policy116Job succeeded