danger-review
Passed Started
by
@peterhegman
Peter Hegman
1Running with gitlab-runner 14.3.0-rc1 (ed15bfbf)2 on green-2.private.runners-manager.gitlab.com/gitlab.com/gitlab-org GaSD-S1F3 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...9Using docker image sha256:5ba30b2efcbe583314cc76f63951dc9434780296f6f0c0927d24b4ce4fb73622 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:c4091382b5a12b75ca112f017f8cecffed2cf1a087968e3a03143d55ec67d3bf ...11Running on runner-gasd-s1f-project-278964-concurrent-0 via runner-gasd-s1f-private-1632933286-eaa772bc...13$ eval "$CI_PRE_CLONE_SCRIPT"14Downloading archived master...15Connecting to storage.googleapis.com (172.217.193.128:443)16saving to '/tmp/gitlab.tar.gz'17gitlab.tar.gz 41% |************* | 143M 0:00:01 ETA18gitlab.tar.gz 100% |********************************| 344M 0:00:00 ETA19'/tmp/gitlab.tar.gz' saved20Extracting tarball into /builds/gitlab-org/gitlab...21Fetching changes with git depth set to 20...22Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/23Created fresh repository.24remote: Enumerating objects: 187, done. 25remote: Counting objects: 100% (123/123), done. 26remote: Compressing objects: 100% (54/54), done. 27remote: Total 63 (delta 43), reused 14 (delta 6), pack-reused 0 29 * [new ref] 6c9cdce57f0e700f6c83b722659fe2d1068e9cb5 -> refs/pipelines/37967945930Checking out 6c9cdce5 as refs/merge-requests/70878/merge...31Skipping Git submodules setup33Checking cache for ruby-gems-v1-4...34cache.zip is up to date 35Successfully extracted cache36Checking cache for node-modules-test-v1-4...37cache.zip is up to date 38Successfully extracted cache40Using docker image sha256:5ba30b2efcbe583314cc76f63951dc9434780296f6f0c0927d24b4ce4fb73622 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:c4091382b5a12b75ca112f017f8cecffed2cf1a087968e3a03143d55ec67d3bf ...41$ source scripts/utils.sh42$ bundle_install_script "--with danger"43Bundler version 2.1.444production:development45Settings are listed in order of priority. The top value will be used.46path47Set for the current user (/root/.bundle/config): "/builds/gitlab-org/gitlab/vendor"48clean49Set for the current user (/root/.bundle/config): "true"50without51Set via BUNDLE_WITHOUT: [:production, :development]52install_flags53Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"54$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check55[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set with 'danger'`, and stop using this flag56The Gemfile's dependencies are satisfied57==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 2 seconds.58$ bundle pristine pg59Installing pg 1.2.3 with native extensions60==> 'bundle pristine pg' succeeded in 11 seconds.61$ run_timed_command "retry yarn install --frozen-lockfile"62$ retry yarn install --frozen-lockfile63yarn install v1.22.1064[1/5] Validating package.json...65[2/5] Resolving packages...66[3/5] Fetching packages...67info fsevents@2.1.3: The platform "linux" is incompatible with this module.68info "fsevents@2.1.3" is an optional dependency and failed compatibility check. Excluding it from installation.69[4/5] Linking dependencies...70warning "@gitlab/eslint-plugin > eslint-plugin-jest > @typescript-eslint/experimental-utils > @typescript-eslint/typescript-estree > tsutils@3.17.1" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".71warning " > eslint-import-resolver-jest@3.0.2" has unmet peer dependency "eslint-plugin-import@>=1.4.0".72warning " > eslint-import-resolver-webpack@0.13.1" has unmet peer dependency "eslint-plugin-import@>=1.4.0".73[5/5] Building fresh packages...74$ node ./scripts/frontend/postinstall.js75success Dependency postinstall check passed.76Done in 85.72s.77==> 'retry yarn install --frozen-lockfile' succeeded in 86 seconds.78$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command79$ bundle exec danger --fail-on-errors=true --verbose80danger/ci_templates/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE81danger/gitaly/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here82Results:83Warnings:84- [ ] 937895ccfc10e6000573c15b9027942b917e5662: The commit subject must start with a capital letter. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).85- [ ] 399a16809067e7999e2154a95fbf3c22b885f353: The commit subject must contain at least 3 words. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).86- [ ] You've made some app changes, but didn't add any tests.87That's OK as long as you're refactoring existing code,88but please consider adding any of the ~"tooling", ~"tooling::pipelines", ~"tooling::workflow", ~"documentation", ~"QA" labels.89Messages:90- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:91If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.92If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.93If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.94Markdown:95## Reviewer roulette96Changes that require review have been detected!97Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:98| Category | Reviewer | Maintainer |99| -------- | -------- | ---------- |100| ~frontend | [Sheldon Led](https://gitlab.com/sheldonled) (`@sheldonled`) (UTC+1) | [Miguel Rincon](https://gitlab.com/mrincon) (`@mrincon`) (UTC+2) |101To spread load more evenly across eligible reviewers, Danger has picked a candidate for each102review slot, based on their timezone. Feel free to103[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)104if you think someone else would be better-suited105or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.106To read more on how to use the reviewer roulette, please take a look at the107[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)108and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).109Please consider assigning a reviewer or maintainer who is a110[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.111Once you've decided who will review this merge request, assign them as a reviewer!112Danger does not automatically notify them for you.113**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/1635190839) that generated this comment.**114==> 'bundle exec danger --fail-on-errors=true --verbose' succeeded in 8 seconds.116Not uploading cache ruby-gems-v1-4 due to policy117Not uploading cache node-modules-test-v1-4 due to policy119Job succeeded