danger-review
Passed Started
by
@gitlab-bot
🤖 GitLab Bot 🤖
1Running with gitlab-runner 14.3.0-rc1 (ed15bfbf)2 on docker-auto-scale-com d5ae8d253 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...9Using docker image sha256:5ba30b2efcbe583314cc76f63951dc9434780296f6f0c0927d24b4ce4fb73622 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:c4091382b5a12b75ca112f017f8cecffed2cf1a087968e3a03143d55ec67d3bf ...11Running on runner-d5ae8d25-project-278964-concurrent-0 via runner-d5ae8d25-gsrm-1632932223-5947d55a...13$ eval "$CI_PRE_CLONE_SCRIPT"14Downloading archived master...15Connecting to storage.googleapis.com (172.217.193.128:443)16saving to '/tmp/gitlab.tar.gz'17gitlab.tar.gz 27% |******** | 95.7M 0:00:02 ETA18gitlab.tar.gz 100% |********************************| 344M 0:00:00 ETA19'/tmp/gitlab.tar.gz' saved20Extracting tarball into /builds/gitlab-org/gitlab...21Fetching changes with git depth set to 20...22Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/23Created fresh repository.24remote: Enumerating objects: 1860, done. 25remote: Counting objects: 100% (891/891), done. 26remote: Compressing objects: 100% (268/268), done. 27remote: Total 418 (delta 324), reused 196 (delta 141), pack-reused 0 28Receiving objects: 100% (418/418), 80.57 KiB | 3.84 MiB/s, done.29Resolving deltas: 100% (324/324), completed with 189 local objects.31 * [new ref] c961d713ce276cf358ce20aea5119841cb99ecf3 -> refs/pipelines/37963595632Checking out c961d713 as refs/merge-requests/71273/merge...33Skipping Git submodules setup35Checking cache for ruby-gems-v1-4...36Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-v1-4 37Successfully extracted cache38Checking cache for node-modules-test-v1-4...39cache.zip is up to date 40Successfully extracted cache42Using docker image sha256:5ba30b2efcbe583314cc76f63951dc9434780296f6f0c0927d24b4ce4fb73622 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:c4091382b5a12b75ca112f017f8cecffed2cf1a087968e3a03143d55ec67d3bf ...43$ source scripts/utils.sh44$ bundle_install_script "--with danger"45Bundler version 2.1.446production:development47Settings are listed in order of priority. The top value will be used.48path49Set for the current user (/root/.bundle/config): "/builds/gitlab-org/gitlab/vendor"50clean51Set for the current user (/root/.bundle/config): "true"52without53Set via BUNDLE_WITHOUT: [:production, :development]54install_flags55Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"56$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check57[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set with 'danger'`, and stop using this flag58The Gemfile's dependencies are satisfied59==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 2 seconds.60$ bundle pristine pg61Installing pg 1.2.3 with native extensions62==> 'bundle pristine pg' succeeded in 13 seconds.63$ run_timed_command "retry yarn install --frozen-lockfile"64$ retry yarn install --frozen-lockfile65yarn install v1.22.1066[1/5] Validating package.json...67[2/5] Resolving packages...68success Already up-to-date.69$ node ./scripts/frontend/postinstall.js70success Dependency postinstall check passed.71Done in 1.13s.72==> 'retry yarn install --frozen-lockfile' succeeded in 1 seconds.73$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command74$ bundle exec danger --fail-on-errors=true --verbose75danger/ci_templates/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE76danger/gitaly/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here77Results:78Messages:79- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:80If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.81If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.82If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.83Markdown:84## Reviewer roulette85Changes that require review have been detected!86Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:87| Category | Reviewer | Maintainer |88| -------- | -------- | ---------- |89| ~QA | [Tiffany Rea](https://gitlab.com/treagitlab) (`@treagitlab`) (UTC-7, 10 hours behind `@acunskis`) | [Sanad Liaquat](https://gitlab.com/sliaquat) (`@sliaquat`) (UTC+5, 2 hours ahead of `@acunskis`) |90To spread load more evenly across eligible reviewers, Danger has picked a candidate for each91review slot, based on their timezone. Feel free to92[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)93if you think someone else would be better-suited94or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.95To read more on how to use the reviewer roulette, please take a look at the96[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)97and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).98Please consider assigning a reviewer or maintainer who is a99[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.100Once you've decided who will review this merge request, assign them as a reviewer!101Danger does not automatically notify them for you.102**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/1634948807) that generated this comment.**103==> 'bundle exec danger --fail-on-errors=true --verbose' succeeded in 6 seconds.105Not uploading cache ruby-gems-v1-4 due to policy106Not uploading cache node-modules-test-v1-4 due to policy108Job succeeded