danger-review
Passed Started
by
@gitlab-bot
🤖 GitLab Bot 🤖
1Running with gitlab-runner 14.3.0-rc1 (ed15bfbf)2 on green-2.private.runners-manager.gitlab.com/gitlab.com/gitlab-org GaSD-S1F3 feature flags: FF_USE_FASTZIP:true, FF_SCRIPT_SECTIONS:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...9Using docker image sha256:5ba30b2efcbe583314cc76f63951dc9434780296f6f0c0927d24b4ce4fb73622 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:c4091382b5a12b75ca112f017f8cecffed2cf1a087968e3a03143d55ec67d3bf ...11Running on runner-gasd-s1f-project-278964-concurrent-0 via runner-gasd-s1f-private-1632812124-25427fd5...14Downloading archived master...15Connecting to storage.googleapis.com (172.217.203.128:443)16saving to '/tmp/gitlab.tar.gz'17gitlab.tar.gz 38% |************ | 132M 0:00:01 ETA18gitlab.tar.gz 100% |********************************| 345M 0:00:00 ETA19'/tmp/gitlab.tar.gz' saved20Extracting tarball into /builds/gitlab-org/gitlab...21Fetching changes with git depth set to 20...22Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/23Created fresh repository.24remote: Enumerating objects: 905, done. 25remote: Counting objects: 100% (653/653), done. 26remote: Compressing objects: 100% (149/149), done. 27remote: Total 217 (delta 178), reused 96 (delta 63), pack-reused 0 28Receiving objects: 100% (217/217), 36.51 KiB | 4.06 MiB/s, done.29Resolving deltas: 100% (178/178), completed with 113 local objects.31 * [new ref] 8a18ae4220832329cf71f2ff9ebbc4ddf2d80a8e -> refs/pipelines/37845025732Checking out 8a18ae42 as refs/merge-requests/71197/merge...33Skipping Git submodules setup35Checking cache for ruby-gems-v1-4...36cache.zip is up to date 37Successfully extracted cache38Checking cache for node-modules-test-v1-4...39Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-test-v1-4 40Successfully extracted cache42Using docker image sha256:5ba30b2efcbe583314cc76f63951dc9434780296f6f0c0927d24b4ce4fb73622 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.16-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:c4091382b5a12b75ca112f017f8cecffed2cf1a087968e3a03143d55ec67d3bf ...45Bundler version 2.1.446production:development47Settings are listed in order of priority. The top value will be used.48path49Set for the current user (/root/.bundle/config): "/builds/gitlab-org/gitlab/vendor"50clean51Set for the current user (/root/.bundle/config): "true"52without53Set via BUNDLE_WITHOUT: [:production, :development]54install_flags55Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"56$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check57[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set with 'danger'`, and stop using this flag58The Gemfile's dependencies are satisfied59==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 2 seconds.60$ bundle pristine pg61Installing pg 1.2.3 with native extensions62==> 'bundle pristine pg' succeeded in 9 seconds.64$ retry yarn install --frozen-lockfile65yarn install v1.22.1066[1/5] Validating package.json...67[2/5] Resolving packages...68success Already up-to-date.69$ node ./scripts/frontend/postinstall.js70success Dependency postinstall check passed.71Done in 0.96s.72==> 'retry yarn install --frozen-lockfile' succeeded in 2 seconds.74$ bundle exec danger --fail-on-errors=true --verbose75danger/ci_templates/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE76danger/gitaly/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here77Results:78Warnings:79- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://about.gitlab.com/handbook/engineering/ux/technical-writing/#designated-technical-writers).80For more information, see:81- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).82- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.83Markdown:84## Reviewer roulette85Changes that require review have been detected!86Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:87| Category | Reviewer | Maintainer |88| -------- | -------- | ---------- |89| ~frontend | [Alexander Turinske](https://gitlab.com/aturinske) (`@aturinske`) (UTC-6, 9 hours behind `@anna_vovchenko`) | [Ezekiel Kigbo](https://gitlab.com/ekigbo) (`@ekigbo`) (UTC+10, 7 hours ahead of `@anna_vovchenko`) |90To spread load more evenly across eligible reviewers, Danger has picked a candidate for each91review slot, based on their timezone. Feel free to92[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)93if you think someone else would be better-suited94or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.95To read more on how to use the reviewer roulette, please take a look at the96[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)97and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).98Please consider assigning a reviewer or maintainer who is a99[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.100Once you've decided who will review this merge request, assign them as a reviewer!101Danger does not automatically notify them for you.102**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/1628712692) that generated this comment.**103==> 'bundle exec danger --fail-on-errors=true --verbose' succeeded in 6 seconds.105Not uploading cache ruby-gems-v1-4 due to policy106Not uploading cache node-modules-test-v1-4 due to policy108Job succeeded