Skip to content
Snippets Groups Projects

danger-review

Passed Started by
Francisco Javier López
@fjsanpedro
1Running with gitlab-runner 14.2.0 (58ba2b95)
2 on blue-1.private.runners-manager.gitlab.com/gitlab.com/gitlab-org 1zzGUpzq
3 feature flags: FF_USE_FASTZIP:true, FF_SCRIPT_SECTIONS:true
4 Resolving secrets 00:00
5 Preparing the "docker+machine" executor 00:04
6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.14-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...
7Authenticating with credentials from job payload (GitLab Registry)
8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.14-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...
9Using docker image sha256:2d2d820babccdf44a703e353eee2c88ce089eb1de130ddf7d2c729ef8ee98c4d for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.14-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:9be586657c93d4bb1a61071e6c0649da6a64fba31283ffe36b8e4ec5d042595a ...
10 Preparing environment 00:01
11Running on runner-1zzgupzq-project-278964-concurrent-0 via runner-1zzgupzq-private-1631780478-a625e613...
12 Getting source from Git repository 00:34
13 $ eval "$CI_PRE_CLONE_SCRIPT" 00:13
14Downloading archived master...
15Connecting to storage.googleapis.com (172.217.193.128:443)
16saving to '/tmp/gitlab.tar.gz'
17gitlab.tar.gz 36% |*********** | 125M 0:00:01 ETA
18gitlab.tar.gz 100% |********************************| 347M 0:00:00 ETA
19'/tmp/gitlab.tar.gz' saved
20Extracting tarball into /builds/gitlab-org/gitlab...
21Fetching changes with git depth set to 20...
22Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/
23Created fresh repository.
24remote: Enumerating objects: 102, done.
25remote: Counting objects: 100% (54/54), done.
26remote: Compressing objects: 100% (8/8), done.
27remote: Total 12 (delta 9), reused 7 (delta 4), pack-reused 0
28From https://gitlab.com/gitlab-org/gitlab
29 * [new ref] d92dd8b94c49cda712893f406eee34557c1a9623 -> refs/pipelines/371808027
30Checking out d92dd8b9 as refs/merge-requests/70495/head...
31Skipping Git submodules setup
32 Restoring cache 00:38
33Checking cache for ruby-gems-v1-4...
34cache.zip is up to date
35Successfully extracted cache
36Checking cache for node-modules-test-v1-4...
37Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-test-v1-4
38Successfully extracted cache
39 Executing "step_script" stage of the job script 00:30
40Using docker image sha256:2d2d820babccdf44a703e353eee2c88ce089eb1de130ddf7d2c729ef8ee98c4d for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.patched-golang-1.14-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:9be586657c93d4bb1a61071e6c0649da6a64fba31283ffe36b8e4ec5d042595a ...
41 $ source scripts/utils.sh 00:00
42 $ bundle_install_script "--with danger" 00:20
43Bundler version 2.1.4
44production:development
45Settings are listed in order of priority. The top value will be used.
46path
47Set for the current user (/root/.bundle/config): "/builds/gitlab-org/gitlab/vendor"
48clean
49Set for the current user (/root/.bundle/config): "true"
50without
51Set via BUNDLE_WITHOUT: [:production, :development]
52install_flags
53Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"
54$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check
55[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set with 'danger'`, and stop using this flag
56The Gemfile's dependencies are satisfied
57==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 3 seconds.
58$ bundle pristine pg
59Installing pg 1.2.3 with native extensions
60==> 'bundle pristine pg' succeeded in 15 seconds.
61 $ run_timed_command "retry yarn install --frozen-lockfile" 00:03
62$ retry yarn install --frozen-lockfile
63yarn install v1.22.10
64[1/5] Validating package.json...
65[2/5] Resolving packages...
66success Already up-to-date.
67$ node ./scripts/frontend/postinstall.js
68success Dependency postinstall check passed.
69Done in 1.10s.
70==> 'retry yarn install --frozen-lockfile' succeeded in 3 seconds.
71 $ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command 00:06
72$ bundle exec danger --fail-on-errors=true --verbose
73danger/ci_templates/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE
74danger/gitaly/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here
75Results:
76Warnings:
77- [ ] Please add a [merge request type](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification) to this merge request.
78Markdown:
79## Reviewer roulette
80Changes that require review have been detected!
81Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
82| Category | Reviewer | Maintainer |
83| -------- | -------- | ---------- |
84| ~backend | [Sashi Kumar Kumaresan](https://gitlab.com/sashi_kumar) (`@sashi_kumar`) (UTC+5.5, 3.5 hours ahead of `@fjsanpedro`) | [James Fargher](https://gitlab.com/proglottis) (`@proglottis`) (UTC+12, 10 hours ahead of `@fjsanpedro`) |
85To spread load more evenly across eligible reviewers, Danger has picked a candidate for each
86review slot, based on their timezone. Feel free to
87[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)
88if you think someone else would be better-suited
89or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.
90To read more on how to use the reviewer roulette, please take a look at the
91[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)
92and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).
93Please consider assigning a reviewer or maintainer who is a
94[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.
95Once you've decided who will review this merge request, assign them as a reviewer!
96Danger does not automatically notify them for you.
97**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/1595733735) that generated this comment.**
98==> 'bundle exec danger --fail-on-errors=true --verbose' succeeded in 6 seconds.
99 Saving cache for successful job 00:00
100Not uploading cache ruby-gems-v1-4 due to policy
101Not uploading cache node-modules-test-v1-4 due to policy
102 Cleaning up file based variables 00:01
103Job succeeded