danger-review
Passed Started
by
@.luke

Luke Duncalfe
1Running with gitlab-runner 14.1.0-rc1 (e9489c8a)2 on docker-auto-scale-com 9538b0ab3 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.2.patched-golang-1.14-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.2.patched-golang-1.14-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...9Using docker image sha256:9b06bf3dd0ab8d484e8c9e9c611f75eab098939f568d587a7fd23a3c96eceb87 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.2.patched-golang-1.14-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:eb4fdeb3196481dd022d7d166468834e40a046b46a29e3349fb3bf3657176290 ...11Running on runner-9538b0ab-project-278964-concurrent-0 via runner-9538b0ab-gsrm-1628741754-046c2391...13$ eval "$CI_PRE_CLONE_SCRIPT"14Downloading archived master...15Connecting to storage.googleapis.com (172.217.193.128:443)16saving to '/tmp/gitlab.tar.gz'17gitlab.tar.gz 73% |*********************** | 254M 0:00:00 ETA18gitlab.tar.gz 100% |********************************| 346M 0:00:00 ETA19'/tmp/gitlab.tar.gz' saved20Extracting tarball into /builds/gitlab-org/gitlab...21Fetching changes with git depth set to 20...22Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/23Created fresh repository.24remote: Enumerating objects: 237, done. 25remote: Counting objects: 100% (170/170), done. 26remote: Compressing objects: 100% (65/65), done. 27remote: Total 84 (delta 71), reused 27 (delta 17), pack-reused 0 29 * [new ref] ed12a148c4fe764ac68f2493143e6d9648d333eb -> refs/pipelines/35196494130Checking out ed12a148 as refs/merge-requests/66487/merge...31Skipping Git submodules setup33Checking cache for ruby-gems-v1-4...34Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-v1-4 35Successfully extracted cache36Checking cache for node-modules-test-v1-4...37Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-test-v1-4 38Successfully extracted cache40Using docker image sha256:9b06bf3dd0ab8d484e8c9e9c611f75eab098939f568d587a7fd23a3c96eceb87 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.2.patched-golang-1.14-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:eb4fdeb3196481dd022d7d166468834e40a046b46a29e3349fb3bf3657176290 ...41$ source scripts/utils.sh42$ bundle_install_script "--with danger"43Bundler version 2.1.444production:development45Settings are listed in order of priority. The top value will be used.46path47Set for the current user (/root/.bundle/config): "vendor"48clean49Set for the current user (/root/.bundle/config): "true"50without51Set via BUNDLE_WITHOUT: [:production, :development]52install_flags53Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"54$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check55[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set with 'danger'`, and stop using this flag56The Gemfile's dependencies are satisfied57==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 1 seconds.58$ bundle pristine pg59Installing pg 1.2.3 with native extensions60==> 'bundle pristine pg' succeeded in 9 seconds.61$ run_timed_command "retry yarn install --frozen-lockfile"62$ retry yarn install --frozen-lockfile63yarn install v1.22.1064[1/5] Validating package.json...65[2/5] Resolving packages...66success Already up-to-date.67$ node ./scripts/frontend/postinstall.js68success Dependency postinstall check passed.69Done in 1.09s.70==> 'retry yarn install --frozen-lockfile' succeeded in 1 seconds.71$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command72$ bundle exec danger --fail-on-errors=true --verbose73danger/ci_templates/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE74danger/gitaly/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here75Results:76Messages:77- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:78If you want to create a changelog entry for GitLab FOSS, add the `Changelog` trailer to the commit message you want to add to the changelog.79If you want to create a changelog entry for GitLab EE, also [add the `EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes) to your commit message.80If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.81Markdown:82## Reviewer roulette83Changes that require review have been detected!84Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:85| Category | Reviewer | Maintainer |86| -------- | -------- | ---------- |87| ~backend | [Sashi Kumar Kumaresan](https://gitlab.com/sashi_kumar) (`@sashi_kumar`) (UTC+5.5, 3.5 hours ahead of `@Andysoiron`) | [Kerri Miller](https://gitlab.com/kerrizor) (`@kerrizor`) (UTC-7, 9 hours behind `@Andysoiron`) |88To spread load more evenly across eligible reviewers, Danger has picked a candidate for each89review slot, based on their timezone. Feel free to90[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)91if you think someone else would be better-suited92or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.93To read more on how to use the reviewer roulette, please take a look at the94[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)95and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).96Please consider assigning a reviewer or maintainer who is a97[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.98Once you've decided who will review this merge request, assign them as a reviewer!99Danger does not automatically notify them for you.100**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/1497535469) that generated this comment.**101==> 'bundle exec danger --fail-on-errors=true --verbose' succeeded in 8 seconds.103Not uploading cache ruby-gems-v1-4 due to policy104Not uploading cache node-modules-test-v1-4 due to policy106Job succeeded