There was an error fetching the job.
danger-review
Passed Started
by
@shampton
Scott Hampton
1Running with gitlab-runner 13.11.0-rc1 (286f7013)2 on prm-com-gitlab-org bd0915563 feature flags: FF_USE_FASTZIP:true, FF_GITLAB_REGISTRY_HELPER_IMAGE:true, FF_SKIP_DOCKER_MACHINE_PROVISION_ON_CREATION_FAILURE:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.2.patched-golang-1.14-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.2.patched-golang-1.14-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...9Using docker image sha256:9b06bf3dd0ab8d484e8c9e9c611f75eab098939f568d587a7fd23a3c96eceb87 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.2.patched-golang-1.14-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:eb4fdeb3196481dd022d7d166468834e40a046b46a29e3349fb3bf3657176290 ...11Running on runner-bd091556-project-278964-concurrent-0 via runner-bd091556-prm-1620335169-f4299e5e...13$ eval "$CI_PRE_CLONE_SCRIPT"14Downloading archived master...15Connecting to storage.googleapis.com (172.217.193.128:443)16saving to '/tmp/gitlab.tar.gz'17gitlab.tar.gz 8% |** | 35.5M 0:00:10 ETA18gitlab.tar.gz 65% |******************** | 277M 0:00:01 ETA19gitlab.tar.gz 100% |********************************| 424M 0:00:00 ETA20'/tmp/gitlab.tar.gz' saved21Extracting tarball into /builds/gitlab-org/gitlab...22Fetching changes with git depth set to 20...23Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/24Created fresh repository.25remote: Enumerating objects: 1003, done. 26remote: Counting objects: 100% (678/678), done. 27remote: Compressing objects: 100% (227/227), done. 28remote: Total 352 (delta 269), reused 195 (delta 121), pack-reused 0 29Receiving objects: 100% (352/352), 50.65 KiB | 12.66 MiB/s, done.30Resolving deltas: 100% (269/269), completed with 123 local objects.32 * [new ref] 70857ec0e2c838fd1dc43fc2bdac0e077ab6be73 -> refs/pipelines/29872561933Checking out 70857ec0 as refs/merge-requests/57791/merge...34Skipping Git submodules setup36Checking cache for danger-review-v1-4...37Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/danger-review-v1-4 38Successfully extracted cache40Using docker image sha256:9b06bf3dd0ab8d484e8c9e9c611f75eab098939f568d587a7fd23a3c96eceb87 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.2.patched-golang-1.14-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:eb4fdeb3196481dd022d7d166468834e40a046b46a29e3349fb3bf3657176290 ...41$ source ./scripts/utils.sh42$ run_timed_command "bundle install --jobs=$(nproc) --path=vendor --retry=3 --quiet --with danger"43$ bundle install --jobs=2 --path=vendor --retry=3 --quiet --with danger44[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set with 'danger'`, and stop using this flag45==> 'bundle install --jobs=2 --path=vendor --retry=3 --quiet --with danger' succeeded in 1 seconds.46$ run_timed_command "retry yarn install --frozen-lockfile"47$ retry yarn install --frozen-lockfile48yarn install v1.22.1049[1/5] Validating package.json...50[2/5] Resolving packages...51success Already up-to-date.52$ node ./scripts/frontend/postinstall.js53success Dependency postinstall check passed.54Done in 1.05s.55==> 'retry yarn install --frozen-lockfile' succeeded in 1 seconds.56$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command57$ bundle exec danger --fail-on-errors=true --verbose58danger/feature_flag/Dangerfile:4: warning: already initialized constant Danger::Dangerfile::SEE_DOC59danger/changelog/Dangerfile:6: warning: previous definition of SEE_DOC was here60danger/feature_flag/Dangerfile:7: warning: already initialized constant Danger::Dangerfile::SUGGEST_MR_COMMENT61danger/changelog/Dangerfile:8: warning: previous definition of SUGGEST_MR_COMMENT was here62danger/roulette/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::MESSAGE63danger/pipeline/Dangerfile:3: warning: previous definition of MESSAGE was here64Results:65Messages:66- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:67If you want to create a changelog entry for GitLab FOSS, run the following:68 bin/changelog -m 57791 "Make code quality badge in diff view link to modal"69If you want to create a changelog entry for GitLab EE, run the following instead:70 bin/changelog --ee -m 57791 "Make code quality badge in diff view link to modal"71If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.72- [ ] We are in the process of rolling out a new workflow for adding changelog entries. This new workflow uses Git commit subjects and Git trailers to generate changelogs. This new approach will soon replace the current YAML based approach.73To ease the transition process, we recommend you start using both the old and new approach in parallel. This is not required at this time, but will make it easier to transition to the new approach in the future. To do so, pick the commit that should go in the changelog and add a `Changelog` trailer to it. For example:74```75This is my commit's subject line76This is the optional commit body.77Changelog: added78```79The value of the `Changelog` trailer should be one of the following: added, fixed, changed, deprecated, removed, security, performance, other.80For more information, take a look at the following resources:83If you'd like to see the new approach in action, take a look at the commits in [the Omnibus repository](https://gitlab.com/gitlab-org/omnibus-gitlab/-/commits/master).84Markdown:85## Reviewer roulette86Changes that require review have been detected! A merge request is normally87reviewed by both a reviewer and a maintainer in its primary category (e.g.88~frontend or ~backend), and by a maintainer in all other categories.89To spread load more evenly across eligible reviewers, Danger has picked a candidate for each90review slot, based on their timezone. Feel free to91[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)92if you think someone else would be better-suited93or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.94To read more on how to use the reviewer roulette, please take a look at the95[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)96and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).97Please consider assigning a reviewer or maintainer who is a98[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.99Once you've decided who will review this merge request, assign them as a reviewer!100Danger does not automatically notify them for you.101| Category | Reviewer | Maintainer |102| -------- | -------- | ---------- |103| ~frontend | [Scott Stern](https://gitlab.com/sstern) (`@sstern`) (UTC-7, 1 hour behind `@mfluharty`) | [Natalia Tepluhina](https://gitlab.com/ntepluhina) (`@ntepluhina`) (UTC+2, 8 hours ahead of `@mfluharty`) |104**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/1242831254) that generated this comment.**105==> 'bundle exec danger --fail-on-errors=true --verbose' succeeded in 8 seconds.107Not uploading cache danger-review-v1-4 due to policy109Job succeeded