danger-review

Passed Started 4 years ago by

1Running with gitlab-runner 13.9.0-rc2 (69c049fd)
2  on prm-com-gitlab-org ae3bfce2
3  feature flags: FF_GITLAB_REGISTRY_HELPER_IMAGE:true
 4  Resolving secrets  
  00:00
 5  Preparing the "docker+machine" executor  
  00:07
6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...
7Authenticating with credentials from job payload (GitLab Registry)
8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...
9Using docker image sha256:8495bfd0ebce3c2fee2de64384f04247f8b30547b44af9932a55393c85c4f9b9 for registry.gitlab.com/gitlab-org/gitlab-build-images:danger with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:04ae9c358e62eceb7e8f8f2e6ebf87d22b1f173ed45c34aa6756f3695b8a84a1 ...
 10  Preparing environment  
  00:01
11Running on runner-ae3bfce2-project-278964-concurrent-0 via runner-ae3bfce2-prm-1614760468-c4ae20c7...
 12  Getting source from Git repository  
  00:24
13$ eval "$CI_PRE_CLONE_SCRIPT"
14Downloading archived master...
15Connecting to storage.googleapis.com (172.217.193.128:443)
16saving to '/tmp/gitlab.tar.gz'
17gitlab.tar.gz         62% |********************            |  248M  0:00:00 ETA
18gitlab.tar.gz        100% |********************************|  396M  0:00:00 ETA
19'/tmp/gitlab.tar.gz' saved
20Extracting tarball into /builds/gitlab-org/gitlab...
21Fetching changes with git depth set to 20...
22Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/
23remote: Enumerating objects: 1210, done.        
24remote: Counting objects: 100% (645/645), done.        
25remote: Compressing objects: 100% (251/251), done.        
26remote: Total 320 (delta 256), reused 117 (delta 65), pack-reused 0        
27Receiving objects: 100% (320/320), 40.31 KiB | 1.83 MiB/s, done.
28Resolving deltas: 100% (256/256), completed with 119 local objects.
29From https://gitlab.com/gitlab-org/gitlab
30 * [new ref]               4996f4cc3b5cc82b8b493bfd2a4ced37e8cf757c -> refs/pipelines/264732587
31Checking out 4996f4cc as refs/merge-requests/55046/merge...
32Skipping Git submodules setup
 33  Restoring cache  
  00:38
34Checking cache for yarn-v1-3...
35Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/yarn-v1-3 
36Successfully extracted cache
 37  Executing "step_script" stage of the job script  
  01:44
38Using docker image sha256:8495bfd0ebce3c2fee2de64384f04247f8b30547b44af9932a55393c85c4f9b9 for registry.gitlab.com/gitlab-org/gitlab-build-images:danger with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:04ae9c358e62eceb7e8f8f2e6ebf87d22b1f173ed45c34aa6756f3695b8a84a1 ...
39$ source ./scripts/utils.sh
40$ run_timed_command "retry yarn install --frozen-lockfile"
41$ retry yarn install --frozen-lockfile
42yarn install v1.21.1
43[1/5] Validating package.json...
44[2/5] Resolving packages...
45[3/5] Fetching packages...
46warning sha.js@2.4.10: Invalid bin entry for "sha.js" (in "sha.js").
47info fsevents@2.1.3: The platform "linux" is incompatible with this module.
48info "fsevents@2.1.3" is an optional dependency and failed compatibility check. Excluding it from installation.
49[4/5] Linking dependencies...
50warning "@gitlab/eslint-plugin > eslint-plugin-jest > @typescript-eslint/experimental-utils > @typescript-eslint/typescript-estree > tsutils@3.17.1" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".
51warning " > eslint-import-resolver-jest@3.0.0" has unmet peer dependency "eslint-plugin-import@>=1.4.0".
52warning " > eslint-import-resolver-webpack@0.13.0" has unmet peer dependency "eslint-plugin-import@>=1.4.0".
53warning "vue-jest > ts-jest@26.4.1" has unmet peer dependency "typescript@>=3.8 <5.0".
54[5/5] Building fresh packages...
55$ node ./scripts/frontend/postinstall.js
56success Dependency postinstall check passed.
57Done in 74.28s.
58==> 'retry yarn install --frozen-lockfile' succeeded in 75 seconds.
59$ danger --fail-on-errors=true --verbose
60danger/feature_flag/Dangerfile:4: warning: already initialized constant Danger::Dangerfile::SEE_DOC
61danger/changelog/Dangerfile:6: warning: previous definition of SEE_DOC was here
62danger/feature_flag/Dangerfile:6: warning: already initialized constant Danger::Dangerfile::SUGGEST_MR_COMMENT
63danger/changelog/Dangerfile:8: warning: previous definition of SUGGEST_MR_COMMENT was here
64danger/roulette/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::MESSAGE
65danger/pipeline/Dangerfile:3: warning: previous definition of MESSAGE was here
66Results:
67Warnings:
68- [ ] For the following files, a review from the [Data team and Product Intelligence team](https://gitlab.com/groups/gitlab-org/growth/product-intelligence/engineers/-/group_members?with_inherited_permissions=exclude) is recommended
69Please check the ~"product intelligence" [guide](https://docs.gitlab.com/ee/development/usage_ping.html) and reach out to @gitlab-org/growth/product-intelligence/engineers group for a review.
70<details>
71* `config/feature_flags/development/usage_data_i_code_review_user_time_estimate_changed.yml`
72* `config/feature_flags/development/usage_data_i_code_review_user_time_spent_changed.yml`
73* `lib/gitlab/usage_data_counters/aggregated_metrics/code_review.yml`
74* `lib/gitlab/usage_data_counters/known_events/code_review_events.yml`
75* `lib/gitlab/usage_data_counters/merge_request_activity_unique_counter.rb`
76* `spec/lib/gitlab/usage_data_counters/merge_request_activity_unique_counter_spec.rb`
77* `config/metrics/counts_28d/20210301102134_i_code_review_user_time_estimate_changed_monthly.yml`
78* `config/metrics/counts_28d/20210301102204_i_code_review_user_time_spent_changed_monthly.yml`
79* `config/metrics/counts_7d/20210302103539_i_code_review_user_time_estimate_changed_weekly.yml`
80* `config/metrics/counts_7d/20210302103615_i_code_review_user_time_spent_changed_weekly.yml`
81* `doc/development/usage_ping/dictionary.md`
82</details>
83Messages:
84- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.
85- [ ] You're adding or removing a feature flag, your MR title needs to include `[RUN ALL RSPEC] [RUN AS-IF-FOSS]` (we may have updated it automatically for you and started a new MR pipeline) to ensure everything is covered.
86Markdown:
87## Documentation review
88The following files require a review from a technical writer:
89* `doc/development/usage_ping/dictionary.md`
90The review does not need to block merging this merge request. See the:
91- [Technical Writers assignments](https://about.gitlab.com/handbook/engineering/technical-writing/#designated-technical-writers) for the appropriate technical writer for this review.
92- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.
93/label ~"product intelligence" ~"product intelligence::review pending"
94## Reviewer roulette
95Changes that require review have been detected! A merge request is normally
96reviewed by both a reviewer and a maintainer in its primary category (e.g.
97~frontend or ~backend), and by a maintainer in all other categories.
98To spread load more evenly across eligible reviewers, Danger has picked a candidate for each
99review slot, based on their timezone. Feel free to
100[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)
101if you think someone else would be better-suited
102or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.
103To read more on how to use the reviewer roulette, please take a look at the
104[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)
105and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).
106Please consider assigning a reviewer or maintainer who is a
107[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.
108Once you've decided who will review this merge request, assign them as a reviewer!
109Danger does not automatically notify them for you.
110| Category | Reviewer | Maintainer |
111| -------- | -------- | ---------- |
112| ~backend | [Tiger Watson](https://gitlab.com/tigerwnz) (`@tigerwnz`) (UTC+13, 5 hours ahead of `@patrickbajao`) | [Stan Hu](https://gitlab.com/stanhu) (`@stanhu`) (UTC-8, 16 hours behind `@patrickbajao`) |
113| ~changelog | No reviewer available | No maintainer available |
114| ~feature_flag | No reviewer available | No maintainer available |
115**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/1069712430) that generated this comment.**
 116  Saving cache for successful job  
  00:01
117Not uploading cache yarn-v1-3 due to policy
 118  Cleaning up file based variables  
  00:00
119Job succeeded

Tags: gitlab-org

Commit 4996f4cc in !55046

Merge branch '292824-track-mr-time-changes' into 'master'

Related jobs

brakeman-sast

code_quality

danger-review

db:check-migrations

db:check-schema

db:migrate-from-v12.10.0

db:migrate:reset

db:rollback

db:rollback geo

dependency_scanning bundler-audit

dependency_scanning gemnasium

dependency_scanning gemnasium-python

dependency_scanning retire-js

docs-lint links

docs-lint markdown

downtime_check

eslint-sast

gitlab:setup

gitlab_git_test

graphql-verify

jest 1/4

jest 2/4

jest 3/4

jest 4/4

jest-as-if-foss 1/2

jest-as-if-foss 2/2

jest-integration

karma

karma-as-if-foss

license_scanning

lint-yaml

memory-on-boot

memory-static

nodejs-scan-sast

qa:internal

qa:internal-as-if-foss

qa:selectors

qa:selectors-as-if-foss

rspec db-library-code pg12

rspec fail-fast

rspec fast_spec_helper

rspec integration pg11 1/8

rspec integration pg11 2/8

rspec integration pg11 3/8

rspec integration pg11 4/8

rspec integration pg11 5/8

rspec integration pg11 6/8

rspec integration pg11 7/8

rspec integration pg11 8/8

rspec integration pg11-as-if-foss 1/8

rspec integration pg11-as-if-foss 2/8

rspec integration pg11-as-if-foss 3/8

rspec integration pg11-as-if-foss 4/8

rspec integration pg11-as-if-foss 5/8

rspec integration pg11-as-if-foss 6/8

rspec integration pg11-as-if-foss 7/8

rspec integration pg11-as-if-foss 8/8

rspec migration pg11 1/5

rspec migration pg11 2/5

rspec migration pg11 3/5

rspec migration pg11 4/5

rspec migration pg11 5/5

rspec migration pg11-as-if-foss 1/5

rspec migration pg11-as-if-foss 2/5

rspec migration pg11-as-if-foss 3/5

rspec migration pg11-as-if-foss 4/5

rspec migration pg11-as-if-foss 5/5

rspec system pg11 1/24

rspec system pg11 10/24

rspec system pg11 11/24

rspec system pg11 12/24

rspec system pg11 13/24

rspec system pg11 14/24

rspec system pg11 15/24

rspec system pg11 16/24

rspec system pg11 17/24

rspec system pg11 18/24

rspec system pg11 19/24

rspec system pg11 2/24

rspec system pg11 20/24

rspec system pg11 21/24

rspec system pg11 22/24

rspec system pg11 23/24

rspec system pg11 24/24

rspec system pg11 3/24

rspec system pg11 4/24

rspec system pg11 5/24

rspec system pg11 6/24

rspec system pg11 7/24

rspec system pg11 8/24

rspec system pg11 9/24

rspec system pg11-as-if-foss 1/24

rspec system pg11-as-if-foss 10/24

rspec system pg11-as-if-foss 11/24

rspec system pg11-as-if-foss 12/24

rspec system pg11-as-if-foss 13/24

rspec system pg11-as-if-foss 14/24

rspec system pg11-as-if-foss 15/24

rspec system pg11-as-if-foss 16/24

rspec system pg11-as-if-foss 17/24

rspec system pg11-as-if-foss 18/24

rspec system pg11-as-if-foss 19/24

rspec system pg11-as-if-foss 2/24

rspec system pg11-as-if-foss 20/24

rspec system pg11-as-if-foss 21/24

rspec system pg11-as-if-foss 22/24

rspec system pg11-as-if-foss 23/24

rspec system pg11-as-if-foss 24/24

rspec system pg11-as-if-foss 3/24

rspec system pg11-as-if-foss 4/24

rspec system pg11-as-if-foss 5/24

rspec system pg11-as-if-foss 6/24

rspec system pg11-as-if-foss 7/24

rspec system pg11-as-if-foss 8/24

rspec system pg11-as-if-foss 9/24

rspec unit pg11 1/20

rspec unit pg11 10/20

rspec unit pg11 11/20

rspec unit pg11 12/20

rspec unit pg11 13/20

rspec unit pg11 14/20

rspec unit pg11 15/20

rspec unit pg11 16/20

rspec unit pg11 17/20

rspec unit pg11 18/20

rspec unit pg11 19/20

rspec unit pg11 2/20

rspec unit pg11 20/20

rspec unit pg11 3/20

rspec unit pg11 4/20

rspec unit pg11 5/20

rspec unit pg11 6/20

rspec unit pg11 7/20

rspec unit pg11 8/20

rspec unit pg11 9/20

rspec unit pg11-as-if-foss 1/20

rspec unit pg11-as-if-foss 10/20

rspec unit pg11-as-if-foss 11/20

rspec unit pg11-as-if-foss 12/20

rspec unit pg11-as-if-foss 13/20

rspec unit pg11-as-if-foss 14/20

rspec unit pg11-as-if-foss 15/20

rspec unit pg11-as-if-foss 16/20

rspec unit pg11-as-if-foss 17/20

rspec unit pg11-as-if-foss 18/20

rspec unit pg11-as-if-foss 19/20

rspec unit pg11-as-if-foss 2/20

rspec unit pg11-as-if-foss 20/20

rspec unit pg11-as-if-foss 3/20

rspec unit pg11-as-if-foss 4/20

rspec unit pg11-as-if-foss 5/20

rspec unit pg11-as-if-foss 6/20

rspec unit pg11-as-if-foss 7/20

rspec unit pg11-as-if-foss 8/20

rspec unit pg11-as-if-foss 9/20

rspec-ee integration pg11 1/4

rspec-ee integration pg11 2/4

rspec-ee integration pg11 3/4

rspec-ee integration pg11 4/4

rspec-ee integration pg11 geo

rspec-ee migration pg11 1/2

rspec-ee migration pg11 2/2

rspec-ee system pg11 1/6

rspec-ee system pg11 2/6

rspec-ee system pg11 3/6

rspec-ee system pg11 4/6

rspec-ee system pg11 5/6

rspec-ee system pg11 6/6

rspec-ee system pg11 geo

rspec-ee unit pg11 1/10

rspec-ee unit pg11 10/10

rspec-ee unit pg11 2/10

rspec-ee unit pg11 3/10

rspec-ee unit pg11 4/10

rspec-ee unit pg11 5/10

rspec-ee unit pg11 6/10

rspec-ee unit pg11 7/10

rspec-ee unit pg11 8/10

rspec-ee unit pg11 9/10

rspec-ee unit pg11 geo 1/2

rspec-ee unit pg11 geo 2/2

run-dev-fixtures

run-dev-fixtures-ee

secrets-sast

static-analysis 1/4

static-analysis 2/4

static-analysis 3/4

static-analysis 4/4

ui-docs-links lint

verify-tests-yml

webpack-dev-server

rspec migration pg11 4/5